From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35147D2CE12 for ; Tue, 22 Oct 2024 18:20:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0+D36PD0oyWEGdZT46EpzFiJXC/Bkh6tdCG+WE7z8AQ=; b=35kXVisNMldlXvNb3UCP0NyF2f z9/L/TmD6ljKUXIEfaS9nVwGJU2nVwjySHxP8TzcD4j2iZ6QgoQbJqoFVBOyEN62zXiRjrm2cNjKs 4rXLVxhZTSBWFfXHhDgjwMm5TX5R2tIUP7YGgxredc2LRrE5wO2R94TS3aSoAbaElsMiSymBTqxuH vAfM8/W4Y1pDXR9pIt1/I8BgyrmYJNoLRJ/DVn+6iatg3hO8ZOY3nLRKJpUExTYTsBmkRwXW+TO1n HbvK4zt5Fajr3PJG+L8YTHVNQ5YJZPHVf2N8+r6WyKaQne4XCglKbn3iyh3Dx2qX4UC9kQ0Sx1kv/ EtH6yDLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3JUZ-0000000Bnhx-1Vmb; Tue, 22 Oct 2024 18:20:27 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3JSs-0000000BnPZ-0IWj; Tue, 22 Oct 2024 18:18:43 +0000 Received: by mail-pj1-x102b.google.com with SMTP id 98e67ed59e1d1-2e2e050b1c3so81550a91.0; Tue, 22 Oct 2024 11:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729621120; x=1730225920; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0+D36PD0oyWEGdZT46EpzFiJXC/Bkh6tdCG+WE7z8AQ=; b=TxqgZK8WJTiFgtQTmE0lXHcvuekBJt7e274565lCRAgsie61ba3gkwNqXa6lpJq3rZ By6LrW4CX3B5qlEICBH7acXtB3Cr7aukpQFSVsAeZk5E3S1lW9u/xBsH0G88zKw/4VrM uAuYJv6wjSgfyl9z9Su0GPaEJKB2YJK7Mxlzk09yDR56S18g3zV6jDsaImooBUQskyn6 4do0Mj5cFRSCY524W1G/BzCpRVJwvk/AH30fod2yjYGrOIuWPbbt0Uu65Iwq4O/5ZNd/ YNhyR9WNJaMlwZHa37XroJivQ7YEHXi3PRKp9IwaVwyR2NkJ7HftUCa9+g8TeweXvqxK 4axQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729621120; x=1730225920; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0+D36PD0oyWEGdZT46EpzFiJXC/Bkh6tdCG+WE7z8AQ=; b=kO1viyNL0AMvA2YFH0oTopFyZuku0z06ka41H6byEHrSLY8Rz2HRdGFZEY+S8b/H0I ZHAGpeRAUQQ29rB5euYP2Dnw0sBiLYyoqI2n8pT1c2JwsioAzFG0Si00IJBFqWzhSghw gB9uPYx5goRB1Mqfk54dTR+MZn8mANIM+Nz3aPr38L4SqT1PYTmzNb490k3tBNGKW/4C i1OUhm10KgOSMEi1+weGexCkhnexz5rMcWonESB5hA5np29GXwsVZLJ3NkqhzN1b6uTc YsO7hqfKG/o/QFbrAvjq6foDFciWqRm+KxJvynnGZpN7U9Iss1L//htUgpdsm3FS0amF Oy3g== X-Forwarded-Encrypted: i=1; AJvYcCWd6aLPN69ksEEsINSZooK5ZCS75R7ImTCr25V82hkB9B+DtGO5iLByo17muXAaVuDXgtQKllw2bEtiOiSVfEwH@lists.infradead.org, AJvYcCXI8yKGgOltvtcZ2/mZYkN/SN/ivaV1gNu6dlhwvOqIQ69YLDgEJcUvgR9Q/TgtqnCPg/r/ahJgnv1EcG1V/bo=@lists.infradead.org X-Gm-Message-State: AOJu0Yy8RGN8sFj0rIWb7hSv9zyBKVd0/sldH3/mMl7tDYEGUz+/thQt St+S5sfEUfpUvrn+54/wkru3nJ+KqWbsZT4Ejmblsqs6TJNKO3eo X-Google-Smtp-Source: AGHT+IGhTfZx7xAaEGS4TbJV+BeWoFKCAVJJE3r+eNHK2Hyv5WlycfLWfAukyPd1alfStOe3GkAHzg== X-Received: by 2002:a17:90b:108f:b0:2da:6e46:ad48 with SMTP id 98e67ed59e1d1-2e76a6e4830mr60264a91.1.1729621119846; Tue, 22 Oct 2024 11:18:39 -0700 (PDT) Received: from CNSZTL-DEB.lan ([2408:8262:245d:4d65:bc4b:53ff:fead:2725]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e5e2691e4csm2025468a91.23.2024.10.22.11.18.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2024 11:18:38 -0700 (PDT) From: Tianling Shen To: Jonas Karlman Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Chris Morgan , Andy Yan , Jagan Teki , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add FriendlyARM NanoPi R3S board Date: Wed, 23 Oct 2024 02:18:29 +0800 Message-ID: <20241022181829.897547-1-cnsztl@gmail.com> X-Mailer: git-send-email 2.47.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241022_111842_133355_F22D18DB X-CRM114-Status: GOOD ( 28.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jonas, On Wed, Oct 23, 2024 at 1:56 AM Jonas Karlman wrote: > > Hi Tianling, > > On 2024-10-22 19:38, Tianling Shen wrote: > > Hi Jonas, > > > > On Wed, Oct 23, 2024 at 12:49 AM Jonas Karlman wrote: > >> > >> Hi Tianling, > >> > >> On 2024-10-20 19:39, Tianling Shen wrote: > >>> The NanoPi R3S(as "R3S") is an open source platform with dual-Gbps > >>> Ethernet ports designed and developed by FriendlyElec for IoT > >>> applications. > >>> > >>> Specification: > >>> - Rockchip RK3566 > >>> - 2GB LPDDR4X RAM > >>> - optional 32GB eMMC module > >>> - SD card slot > >>> - 2x 1000 Base-T > >>> - 3x LEDs (POWER, LAN, WAN) > >>> - 2x Buttons (Reset, MaskROM) > >>> - 1x USB 3.0 Port > >>> - Type-C 5V 2A Power > >>> > >>> Signed-off-by: Tianling Shen > >>> --- > >>>  arch/arm64/boot/dts/rockchip/Makefile   Â  Â  Â  |   1 + > >>>  .../boot/dts/rockchip/rk3566-nanopi-r3s.dts   | 554 ++++++++++++++++++ > >>>  2 files changed, 555 insertions(+) > >>>  create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts > >>> > >>> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile > >>> index 8e1025cb5d20..e641033d23d1 100644 > >>> --- a/arch/arm64/boot/dts/rockchip/Makefile > >>> +++ b/arch/arm64/boot/dts/rockchip/Makefile > >>> @@ -109,6 +109,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-soquartz-model-a.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lckfb-tspi.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb > >>> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb > >>>  dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb > >>> diff --git a/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts > >>> new file mode 100644 > >>> index 000000000000..951dd9bcb4b0 > >>> --- /dev/null > >>> +++ b/arch/arm64/boot/dts/rockchip/rk3566-nanopi-r3s.dts > >>> @@ -0,0 +1,554 @@ > >>> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT > >>> +/* > >>> + * Copyright (c) 2020 Rockchip Electronics Co., Ltd. > >>> + * > >>> + * Copyright (c) 2024 FriendlyElec Computer Tech. Co., Ltd. > >>> + * (http://www.friendlyarm.com/ > > This could probably be updated to use https://www.friendlyelec.com/ Yes! > > >>> + * > >>> + * Copyright (c) 2024 Tianling Shen > >>> + */ > >>> + > >>> +/dts-v1/; > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include > >>> +#include "rk3566.dtsi" > >>> + > >>> +/ { > >>> +   Â  model = "FriendlyARM NanoPi R3S"; > >> > >> Please use the marketing name, and the name added in binding: > >> > >>   Â FriendlyElec NanoPi R3S > > > > Sorry for the copy & paste error, will fix it in new patch. > > The commit subject could probably also be updated :-) > > > > >> > >>> +   Â  compatible = "friendlyarm,nanopi-r3s", "rockchip,rk3566"; > >>> + > >>> +   Â  aliases { > >>> +   Â  Â  Â  Â  Â  ethernet0 = &gmac1; > >>> +   Â  Â  Â  Â  Â  mmc0 = &sdmmc0; > >>> +   Â  Â  Â  Â  Â  mmc1 = &sdhci; > >> > >> This board comes with on-board eMMC this please use mmc0 as alias for > >> &sdhci; and mmc1 for sd-card. > > > > Is using mmc0 for sdhci a common practice for eMMC boards? > > The eMMC module on R3S is optional and users may get boards without it. > > Typically any non-removable storage (emmc) is listed before removable > storage (sd-card) options. Also U-Boot will try to override and use > mmc0=sdhci and mmc1=sdmmc0 for all rk356x boards, so for EFI booing > using control FDT the alias may be different. > Thank you for the details! May I have your Suggested-by tag for all of these fixes? Thanks, Tianling. > Regards, > Jonas > > [snip]