diff for duplicates of <20241023124014.GU402847@kernel.org> diff --git a/a/1.txt b/N1/1.txt index 79eccfc..34b411a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,40 +1,54 @@ -+ Jiri +>+ Jiri +> +>On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote: +>> From: Jinjian Song <songjinjian@hotmail.com> +>> +>> Add support for userspace to switch on the debug port(ADB,MIPC). +>> - ADB port: /dev/wwan0adb0 +>> - MIPC port: /dev/wwan0mipc0 +>> +>> Application can use ADB (Android Debg Bridge) port to implement +>> functions (shell, pull, push ...) by ADB protocol commands. +>> E.g., ADB commands: +>> - A_OPEN: OPEN(local-id, 0, "destination") +>> - A_WRTE: WRITE(local-id, remote-id, "data") +>> - A_OKEY: READY(local-id, remote-id, "") +>> - A_CLSE: CLOSE(local-id, remote-id, "") +>> +>> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md +>> +>> Application can use MIPC (Modem Information Process Center) port +>> to debug antenna tunner or noise profiling through this MTK modem +>> diagnostic interface. +>> +>> By default, debug ports are not exposed, so using the command +>> to enable or disable debug ports. +>> +>> Switch on debug port: +>> - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode +>> +>> Switch off debug port: +>> - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode +> +>Hi, +> +>I am somewhat surprised to see vendor-specific sysfs controls being added. +>And I am wondering if another mechanism was considered. It seems to +>me that devlink would be appropriate. Jiri (CCed) may have an opinion on +>that. +> +>... -On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote: -> From: Jinjian Song <songjinjian@hotmail.com> -> -> Add support for userspace to switch on the debug port(ADB,MIPC). -> - ADB port: /dev/wwan0adb0 -> - MIPC port: /dev/wwan0mipc0 -> -> Application can use ADB (Android Debg Bridge) port to implement -> functions (shell, pull, push ...) by ADB protocol commands. -> E.g., ADB commands: -> - A_OPEN: OPEN(local-id, 0, "destination") -> - A_WRTE: WRITE(local-id, remote-id, "data") -> - A_OKEY: READY(local-id, remote-id, "") -> - A_CLSE: CLOSE(local-id, remote-id, "") -> -> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md -> -> Application can use MIPC (Modem Information Process Center) port -> to debug antenna tunner or noise profiling through this MTK modem -> diagnostic interface. -> -> By default, debug ports are not exposed, so using the command -> to enable or disable debug ports. -> -> Switch on debug port: -> - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode -> -> Switch off debug port: -> - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode +Hi Jiri, -Hi, +T7XX is MTK WWAN device platform, ADB and MIPC channel is common in all MTK +platform, the ports used to debug, and we need a way to create the channels +to usespace, so use the sysfs to trigger that. -I am somewhat surprised to see vendor-specific sysfs controls being added. -And I am wondering if another mechanism was considered. It seems to -me that devlink would be appropriate. Jiri (CCed) may have an opinion on -that. +The previous plan consider using devlink framework to set param to create +ports inside t7xx driver, but later after communicating with Loic and Jiri +, it was replaced with the current plan. +https://lore.kernel.org/all/CAMZdPi-qZ3JjZmEAtEmJETNzKd+k6UcLnLkM0MZoSZ1hKaOXuA@mail.gmail.com/ -... +Best Regards, +Jinjian, diff --git a/a/content_digest b/N1/content_digest index 11e7896..4df5495 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,75 +1,90 @@ "ref\020241021121934.16317-1-jinjian.song@fibocom.com\0" "ref\020241021121934.16317-3-jinjian.song@fibocom.com\0" - "From\0Simon Horman <horms@kernel.org>\0" + "From\0Jinjian Song <jinjian.song@fibocom.com>\0" "Subject\0Re: [net-next,RESEND v6 2/2] net: wwan: t7xx: Add debug port\0" - "Date\0Wed, 23 Oct 2024 13:40:14 +0100\0" - "To\0Jinjian Song <jinjian.song@fibocom.com>\0" - "Cc\0chandrashekar.devegowda@intel.com" + "Date\0Thu, 24 Oct 2024 18:02:56 +0800\0" + "To\0horms@kernel.org\0" + "Cc\0angelogioacchino.delregno@collabora.com" + chandrashekar.devegowda@intel.com chiranjeevi.rapolu@linux.intel.com - haijun.liu@mediatek.com - m.chetan.kumar@linux.intel.com - ricardo.martinez@linux.intel.com - loic.poulain@linaro.org - ryazanov.s.a@gmail.com - johannes@sipsolutions.net + corbet@lwn.net + danielwinkler@google.com davem@davemloft.net edumazet@google.com + haijun.liu@mediatek.com + helgaas@kernel.org + jinjian.song@fibocom.com + jiri@resnulli.us + johannes@sipsolutions.net + korneld@google.com kuba@kernel.org - pabeni@redhat.com - linux-kernel@vger.kernel.org - netdev@vger.kernel.org - linux-doc@vger.kernel.org - angelogioacchino.delregno@collabora.com linux-arm-kernel@lists.infradead.org - matthias.bgg@gmail.com - corbet@lwn.net + linux-doc@vger.kernel.org + linux-kernel@vger.kernel.org linux-mediatek@lists.infradead.org - helgaas@kernel.org - danielwinkler@google.com - korneld@google.com - Jinjian Song <songjinjian@hotmail.com> - " Jiri Pirko <jiri@resnulli.us>\0" + loic.poulain@linaro.org + m.chetan.kumar@linux.intel.com + matthias.bgg@gmail.com + netdev@vger.kernel.org + pabeni@redhat.com + ricardo.martinez@linux.intel.com + ryazanov.s.a@gmail.com + " songjinjian@hotmail.com\0" "\00:1\0" "b\0" - "+ Jiri\n" + ">+ Jiri\n" + ">\n" + ">On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote:\n" + ">> From: Jinjian Song <songjinjian@hotmail.com>\n" + ">> \n" + ">> Add support for userspace to switch on the debug port(ADB,MIPC).\n" + ">> - ADB port: /dev/wwan0adb0\n" + ">> - MIPC port: /dev/wwan0mipc0\n" + ">> \n" + ">> Application can use ADB (Android Debg Bridge) port to implement\n" + ">> functions (shell, pull, push ...) by ADB protocol commands.\n" + ">> E.g., ADB commands:\n" + ">> - A_OPEN: OPEN(local-id, 0, \"destination\")\n" + ">> - A_WRTE: WRITE(local-id, remote-id, \"data\")\n" + ">> - A_OKEY: READY(local-id, remote-id, \"\")\n" + ">> - A_CLSE: CLOSE(local-id, remote-id, \"\")\n" + ">> \n" + ">> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md\n" + ">> \n" + ">> Application can use MIPC (Modem Information Process Center) port\n" + ">> to debug antenna tunner or noise profiling through this MTK modem\n" + ">> diagnostic interface.\n" + ">> \n" + ">> By default, debug ports are not exposed, so using the command\n" + ">> to enable or disable debug ports.\n" + ">> \n" + ">> Switch on debug port:\n" + ">> - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode\n" + ">> \n" + ">> Switch off debug port:\n" + ">> - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode\n" + ">\n" + ">Hi,\n" + ">\n" + ">I am somewhat surprised to see vendor-specific sysfs controls being added.\n" + ">And I am wondering if another mechanism was considered. It seems to\n" + ">me that devlink would be appropriate. Jiri (CCed) may have an opinion on\n" + ">that.\n" + ">\n" + ">...\n" "\n" - "On Mon, Oct 21, 2024 at 08:19:34PM +0800, Jinjian Song wrote:\n" - "> From: Jinjian Song <songjinjian@hotmail.com>\n" - "> \n" - "> Add support for userspace to switch on the debug port(ADB,MIPC).\n" - "> - ADB port: /dev/wwan0adb0\n" - "> - MIPC port: /dev/wwan0mipc0\n" - "> \n" - "> Application can use ADB (Android Debg Bridge) port to implement\n" - "> functions (shell, pull, push ...) by ADB protocol commands.\n" - "> E.g., ADB commands:\n" - "> - A_OPEN: OPEN(local-id, 0, \"destination\")\n" - "> - A_WRTE: WRITE(local-id, remote-id, \"data\")\n" - "> - A_OKEY: READY(local-id, remote-id, \"\")\n" - "> - A_CLSE: CLOSE(local-id, remote-id, \"\")\n" - "> \n" - "> Link: https://android.googlesource.com/platform/packages/modules/adb/+/refs/heads/main/README.md\n" - "> \n" - "> Application can use MIPC (Modem Information Process Center) port\n" - "> to debug antenna tunner or noise profiling through this MTK modem\n" - "> diagnostic interface.\n" - "> \n" - "> By default, debug ports are not exposed, so using the command\n" - "> to enable or disable debug ports.\n" - "> \n" - "> Switch on debug port:\n" - "> - debug: 'echo debug > /sys/bus/pci/devices/${bdf}/t7xx_mode\n" - "> \n" - "> Switch off debug port:\n" - "> - normal: 'echo normal > /sys/bus/pci/devices/${bdf}/t7xx_mode\n" + "Hi Jiri,\n" "\n" - "Hi,\n" + "T7XX is MTK WWAN device platform, ADB and MIPC channel is common in all MTK\n" + "platform, the ports used to debug, and we need a way to create the channels\n" + "to usespace, so use the sysfs to trigger that.\n" "\n" - "I am somewhat surprised to see vendor-specific sysfs controls being added.\n" - "And I am wondering if another mechanism was considered. It seems to\n" - "me that devlink would be appropriate. Jiri (CCed) may have an opinion on\n" - "that.\n" + "The previous plan consider using devlink framework to set param to create \n" + "ports inside t7xx driver, but later after communicating with Loic and Jiri\n" + ", it was replaced with the current plan.\n" + "https://lore.kernel.org/all/CAMZdPi-qZ3JjZmEAtEmJETNzKd+k6UcLnLkM0MZoSZ1hKaOXuA@mail.gmail.com/\n" "\n" - ... + "Best Regards,\n" + Jinjian, -09905a9f39cd5cb9f322c62166ef32d4de81f7aa8dc13e11bde8730b862c25c6 +9473f12e391621b43bfaa7fdd57d78f240d6fb3b44198718915be0375f50c486
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox