From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33DC0CE8E83 for ; Thu, 24 Oct 2024 14:45:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=hb5uWuVYU/rqGL1GIPplx9l1z15+fQd6PJ83L3EcL68=; b=X7v6m+ZjFkuThdbxp2/IQllb4v 4HhG03egEhx0MXtF7G0jhyTYXukV0GwHxWxWlL5XQrf8asMI/f8TXjF0YZuFMWUTDDeiC5zfy1pFn Sv7fBG+Ileo1hX3Q/e5DqbWUI6iIMYKSyyxj7dVgoFjXnk6qlaA6q/C4al0szimNyeYbqzD/4lHsK prRnWlcAeHtqXuoXfh/+gWhNQYPjyEy/ldqiuzJDzHIcB8mXIAemP6JjrUQJzUI4Qtf0wB5mxJD6r eMFtXxjtkFd5hwH9hJo4LQYmjwCkp4w4Xg/23RlNsbPJfQkEXrU/Q6Z1sZ680CqJyjD9/d+Xg0NNZ 3/1n2OlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t3z5k-00000000nY7-3Giz; Thu, 24 Oct 2024 14:45:36 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t3z0q-00000000mCP-16U7; Thu, 24 Oct 2024 14:40:33 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AD5FE5C061B; Thu, 24 Oct 2024 14:40:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 80094C4CEC7; Thu, 24 Oct 2024 14:40:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1729780831; bh=PLdPNWEGAxUx7bs29I+xXhoPOoEWXEpUgtcBm+uEJq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oTa5I9R+zDvC61UZ/jQMxvUG/O2HJqLMjvYPNxvWoWZRvvUWKA+82QBebsQE4uVWI cPQIsEMF2VEIUjP6vYa6m8QRoSxuqSBBv2zbcYgnKtouSQoHvYzTpJ05nF1lUt/Rr4 3oucgT721Ii9Q7Q/C2N7aUFOC7OsXN0MT9uGr9r2HzSYq62Y6ZTdoKQ4BznXZzJzQL 4/OgXqYKXftwcyU3F68cLHDuUmaCJgulC0slRXttv88DVD35DHA1rjQTUupm/zeZPW rxVjJJ3R+Rh1IZtk08zn6WYA/gzf4cOfeivuNFzTPr06y9nd1a3LUNt+GO5XRMzZpl kMy+7rETutDsw== Date: Thu, 24 Oct 2024 16:40:28 +0200 From: Maxime Ripard To: Dave Stevenson Cc: =?utf-8?B?TWHDrXJh?= Canal , Raspberry Pi Kernel Maintenance , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Ray Jui , Scott Branden , Michael Turquette , Stephen Boyd , Javier Martinez Canillas , Catalin Marinas , Will Deacon , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Dom Cobley Subject: Re: [PATCH 31/37] clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks Message-ID: <20241024-intelligent-proficient-python-720a0c@houat> References: <20241023-drm-vc4-2712-support-v1-0-1cc2d5594907@raspberrypi.com> <20241023-drm-vc4-2712-support-v1-31-1cc2d5594907@raspberrypi.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="osg67ubcsv3cmq32" Content-Disposition: inline In-Reply-To: <20241023-drm-vc4-2712-support-v1-31-1cc2d5594907@raspberrypi.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241024_074032_453525_33CB9FBF X-CRM114-Status: GOOD ( 16.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --osg67ubcsv3cmq32 Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH 31/37] clk: bcm: rpi: Allow cpufreq driver to also adjust gpu clocks MIME-Version: 1.0 On Wed, Oct 23, 2024 at 05:50:28PM +0100, Dave Stevenson wrote: > From: Dom Cobley >=20 > For performance/power it is beneficial to adjust gpu clocks with arm cloc= k. > This is how the downstream cpufreq driver works >=20 > Signed-off-by: Dom Cobley > Signed-off-by: Dave Stevenson > --- > drivers/clk/bcm/clk-raspberrypi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/clk/bcm/clk-raspberrypi.c b/drivers/clk/bcm/clk-rasp= berrypi.c > index 6d5ee1cddded..274176a938c6 100644 > --- a/drivers/clk/bcm/clk-raspberrypi.c > +++ b/drivers/clk/bcm/clk-raspberrypi.c > @@ -156,7 +156,7 @@ static int raspberrypi_clock_property(struct rpi_firm= ware *firmware, > struct raspberrypi_firmware_prop msg =3D { > .id =3D cpu_to_le32(data->id), > .val =3D cpu_to_le32(*val), > - .disable_turbo =3D cpu_to_le32(1), > + .disable_turbo =3D cpu_to_le32(0), I guess we can simply remove that line? Maxime --osg67ubcsv3cmq32 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZxpcVwAKCRAnX84Zoj2+ dhWuAYD5PMJD9prMYHyBdObDqF92o81SwNrQ04NtnD5jG5jYeEpmA3MzmyqCAh/o 7YBXa68BgIzZ4yp54frmW6KMod1/8J/vZSTgQD/IZkrDqafE7+wZ06WmivkbUo6B zfJw7nahEg== =mmzK -----END PGP SIGNATURE----- --osg67ubcsv3cmq32--