Re: [PATCH 03/10] dt-bindings: dmaengine: Add Allwinner suniv F1C100s DMA

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1455 bytes --]

On Thu, Oct 24, 2024 at 08:49:24AM +0200, Csókás, Bence wrote:
> Add compatible string for Allwinner suniv F1C100s DMA.

> [ csokas.bence: reimplemented in YAML ]

This implies you took someone else's work and modified it, so I would
expect to see them mentioned here. However, I don't personally think a
compatible name is copyrightable and would suggest just dropping this.

<2 minutes later> I checked the rest of the series, you've got a lot of
missing signoffs from yourself on other patches. You sent them, so you
need to sign off even if you didn;t author them.

Otherwise,
Acked-by: Conor Dooley <conor.dooley@microchip.com>

> Signed-off-by: Csókás, Bence <csokas.bence@prolan.hu>
> ---
>  .../devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml      | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml
> index 02d5bd035409..9b5180c0a7c4 100644
> --- a/Documentation/devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/allwinner,sun4i-a10-dma.yaml
> @@ -22,7 +22,9 @@ properties:
>        number.
>  
>    compatible:
> -    const: allwinner,sun4i-a10-dma
> +    enum:
> +      - allwinner,sun4i-a10-dma
> +      - allwinner,suniv-f1c100s-dma
>  
>    reg:
>      maxItems: 1
> -- 
> 2.34.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]