Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Gowthami Thiagarajan <gthiagarajan@marvell.com>
Cc: mark.rutland@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, bbhushan2@marvell.com,
	gcherian@marvell.com, sgoutham@marvell.com,
	jonathan.cameron@huawei.com
Subject: Re: [PATCH v9 1/5] perf/marvell: Refactor to extract platform data - no functional change
Date: Thu, 24 Oct 2024 13:09:26 +0100	[thread overview]
Message-ID: <20241024120925.GB30510@willie-the-truck> (raw)
In-Reply-To: <20241016080153.3546353-2-gthiagarajan@marvell.com>

On Wed, Oct 16, 2024 at 01:31:49PM +0530, Gowthami Thiagarajan wrote:
> This commit introduces a refactor to the Marvell DDR pmu driver,
> specifically targeting the extraction of platform data
> (referred to as "pdata") from the existing driver. The purpose of
> this refactor is to prepare for the upcoming support of the next
> version of the Performance Monitoring Unit (PMU) in this
> driver.
> 
> No functional changes are introduced in this refactor. Its sole
> purpose is to improve code organization and pave the way for
> future enhancements to the driver.
> 
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com>
> ---
>  drivers/perf/marvell_cn10k_ddr_pmu.c | 160 +++++++++++++++++++--------
>  1 file changed, 112 insertions(+), 48 deletions(-)

Please read the "Describe your changes" section of
Documentation/process/submitting-patches.rst. Specifically, we're
supposed to use the imperative mood and avoid saying "This patch" (This
commit).

Your other commit messages have the same problems.

Will


  reply	other threads:[~2024-10-24 12:11 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-16  8:01 [PATCH v9 0/5] Marvell Odyssey uncore performance monitor support Gowthami Thiagarajan
2024-10-16  8:01 ` [PATCH v9 1/5] perf/marvell: Refactor to extract platform data - no functional change Gowthami Thiagarajan
2024-10-24 12:09   ` Will Deacon [this message]
2024-11-08  4:01     ` Gowthami Thiagarajan
2024-10-16  8:01 ` [PATCH v9 2/5] perf/marvell: Refactor to extract platform specific ops " Gowthami Thiagarajan
2024-10-16  8:01 ` [PATCH v9 3/5] perf/marvell: Odyssey DDR Performance monitor support Gowthami Thiagarajan
2024-10-24 12:07   ` Will Deacon
2024-11-08  3:59     ` Gowthami Thiagarajan
2024-10-16  8:01 ` [PATCH v9 4/5] perf/marvell : Refactor to extract platform data - no functional change Gowthami Thiagarajan
2024-10-16  8:01 ` [PATCH v9 5/5] perf/marvell : Odyssey LLC-TAD performance monitor support Gowthami Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241024120925.GB30510@willie-the-truck \
    --to=will@kernel.org \
    --cc=bbhushan2@marvell.com \
    --cc=gcherian@marvell.com \
    --cc=gthiagarajan@marvell.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox