Re: [PATCH 6/7] iio: light: stk3310: simplify code in write_event_config callback

Jonathan Cameron
2024-10-26T12:33:10Z

On Thu, 24 Oct 2024 11:11:28 +0200
Julien Stephan <jstephan@baylibre.com> wrote:

> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
This one is odd. The field is 1 bit so I've no idea why checking against 7
would ever have made sense.

Applied, but if anyone is familiar with this part I would like more
eyes on that code to see if there is a bug hiding there.

Jonathan

> ---
> drivers/iio/light/stk3310.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
> index ed20b67145463d253a0dff28a4c1c3e02e710319..c6f950af5afa0f77a617bd2baf0a08eef5ec26f0 100644
> --- a/drivers/iio/light/stk3310.c
> +++ b/drivers/iio/light/stk3310.c
> @@ -330,9 +330,6 @@ static int stk3310_write_event_config(struct iio_dev *indio_dev,
> struct stk3310_data *data = iio_priv(indio_dev);
> struct i2c_client *client = data->client;
>
> - if (state < 0 || state > 7)
> - return -EINVAL;
> -
> /* Set INT_PS value */
> mutex_lock(&data->lock);
> ret = regmap_field_write(data->reg_int_ps, state);
>