Re: [PATCH 2/7] iio: light: ltr390: simplify code in write_event_config callback

Jonathan Cameron
2024-10-26T12:24:57Z

On Thu, 24 Oct 2024 11:11:24 +0200
Julien Stephan <jstephan@baylibre.com> wrote:

> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> drivers/iio/light/ltr390.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/iio/light/ltr390.c b/drivers/iio/light/ltr390.c
> index 8e0a3fc3d923a6f65d2a629c87e7bfd35d82a507..ff6b5d8b582b33eba60b769dff529caa00fb7244 100644
> --- a/drivers/iio/light/ltr390.c
> +++ b/drivers/iio/light/ltr390.c
> @@ -558,9 +558,6 @@ static int ltr390_write_event_config(struct iio_dev *indio_dev,
> struct ltr390_data *data = iio_priv(indio_dev);
> int ret;
>
> - if (state != 1 && state != 0)
> - return -EINVAL;
> -
> if (state == 0)

Once you apply the final patch, the == 0 here will make less sense.
Can tidy that up here or in that final patch by just making this
if (!state) etc

> return regmap_clear_bits(data->regmap, LTR390_INT_CFG, LTR390_LS_INT_EN);
>
>