* [PATCH] drm/imx/dcss: include drm/drm_bridge.h header
@ 2024-10-28 16:35 Arnd Bergmann
2024-11-04 12:10 ` Laurentiu Palcu
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2024-10-28 16:35 UTC (permalink / raw)
To: Laurentiu Palcu, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Ville Syrjälä
Cc: Arnd Bergmann, Lucas Stach, David Airlie, Simona Vetter,
Shawn Guo, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
Javier Martinez Canillas, dri-devel, imx, linux-arm-kernel,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Compile-testing random configurations leads to failures in
dcss-kms.c from a missing declaration:
drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
95 | ret = drm_bridge_attach(encoder, bridge, NULL,
| ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
96 | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
| ^
Include the header directly.
Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index 3ec721afc30c..63a335c62296 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -5,6 +5,7 @@
#include <drm/drm_atomic.h>
#include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
#include <drm/drm_bridge_connector.h>
#include <drm/drm_client_setup.h>
#include <drm/drm_drv.h>
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header
2024-10-28 16:35 [PATCH] drm/imx/dcss: include drm/drm_bridge.h header Arnd Bergmann
@ 2024-11-04 12:10 ` Laurentiu Palcu
2024-11-04 12:24 ` Dmitry Baryshkov
0 siblings, 1 reply; 4+ messages in thread
From: Laurentiu Palcu @ 2024-11-04 12:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann,
Ville Syrjälä, Arnd Bergmann, Lucas Stach, David Airlie,
Simona Vetter, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, Javier Martinez Canillas, dri-devel, imx,
linux-arm-kernel, linux-kernel
Hi Arnd,
On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing random configurations leads to failures in
> dcss-kms.c from a missing declaration:
>
> drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
> 95 | ret = drm_bridge_attach(encoder, bridge, NULL,
> | ^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
> 96 | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> | ^
>
> Include the header directly.
>
> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
Ville, can you help push this?
Thanks,
Laurentiu
> ---
> drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 3ec721afc30c..63a335c62296 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -5,6 +5,7 @@
>
> #include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_bridge.h>
> #include <drm/drm_bridge_connector.h>
> #include <drm/drm_client_setup.h>
> #include <drm/drm_drv.h>
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header
2024-11-04 12:10 ` Laurentiu Palcu
@ 2024-11-04 12:24 ` Dmitry Baryshkov
2024-11-04 12:42 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2024-11-04 12:24 UTC (permalink / raw)
To: Laurentiu Palcu
Cc: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Ville Syrjälä, Arnd Bergmann,
Lucas Stach, David Airlie, Simona Vetter, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Javier Martinez Canillas,
dri-devel, imx, linux-arm-kernel, linux-kernel
On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote:
> Hi Arnd,
>
> On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> >
> > Compile-testing random configurations leads to failures in
> > dcss-kms.c from a missing declaration:
> >
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
> > 95 | ret = drm_bridge_attach(encoder, bridge, NULL,
> > | ^
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
> > 96 | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> > | ^
> >
> > Include the header directly.
> >
> > Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
>
> Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
> Ville, can you help push this?
I can pick it up.
However I think it is:
Fixes: e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")
With that
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
>
> Thanks,
> Laurentiu
>
> > ---
> > drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > index 3ec721afc30c..63a335c62296 100644
> > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > @@ -5,6 +5,7 @@
> >
> > #include <drm/drm_atomic.h>
> > #include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_bridge.h>
> > #include <drm/drm_bridge_connector.h>
> > #include <drm/drm_client_setup.h>
> > #include <drm/drm_drv.h>
> > --
> > 2.39.5
> >
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/imx/dcss: include drm/drm_bridge.h header
2024-11-04 12:24 ` Dmitry Baryshkov
@ 2024-11-04 12:42 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2024-11-04 12:42 UTC (permalink / raw)
To: Dmitry Baryshkov, Laurentiu Palcu
Cc: Arnd Bergmann, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Ville Syrjälä, Lucas Stach,
Dave Airlie, Simona Vetter, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, Javier Martinez Canillas,
dri-devel, imx, linux-arm-kernel, linux-kernel
On Mon, Nov 4, 2024, at 13:24, Dmitry Baryshkov wrote:
> On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote:
>> On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
>>> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
>>
> I can pick it up.
>
> However I think it is:
>
> Fixes: e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")
It's probably both commits. My randconfig builds showed it only
failing on x86, which means that it was still working by
accident on all builds that include ARCH_MXC && ARM64, between
the two commits. The commit you pointed out should have added
the #include, but that seems to come indirectly from
include/drm/drm_of on all arm64 builds.
> With that
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Thanks,
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-04 12:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-28 16:35 [PATCH] drm/imx/dcss: include drm/drm_bridge.h header Arnd Bergmann
2024-11-04 12:10 ` Laurentiu Palcu
2024-11-04 12:24 ` Dmitry Baryshkov
2024-11-04 12:42 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).