Re: [PATCH v2 2/3] dt-bindings: lcdif: Expand the imx6sl/imx6sll fallbacks

Andreas Kemnade
2024-10-29T18:22:44Z

Am Tue, 29 Oct 2024 09:02:35 -0300
schrieb Fabio Estevam <festevam@gmail.com>:

> From: Fabio Estevam <festevam@denx.de>
>
> imx6sl.dtsi and imx6sll.dtsi have the following lcdif entries:
>
> compatible = "fsl,imx6sl-lcdif", "fsl,imx28-lcdif";
>
> This causes dt-schema warnings as the current binding only
> allow 'fsl,imx6sx-lcdif' as fallback.
>
> ['fsl,imx6sl-lcdif', 'fsl,imx28-lcdif'] is too long
> ['fsl,imx6sll-lcdif', 'fsl,imx28-lcdif'] is too long
>
> The imx6sx-lcdif programming model has more advanced features, such
> as overlay plane and the CRC32 support than the imx28-lcdif IP.
>
> Expand the imx6sl/imx6sll lcdif fallbacks to accept a less specific
> fsl,imx28-lcdif fallback:
>
> compatible = "fsl,imx6sl-lcdif", "fsl,imx6sx-lcdif",
> "fsl,imx28-lcdif";
>
> This helps keeping DT compatibility as well as using the more advanced
> lcdif features found on imx6sl and imx6sll.
>
> Signed-off-by: Fabio Estevam <festevam@denx.de>
> ---
> Changes since v1:
> - Newly introduced.
>
> .../devicetree/bindings/display/fsl,lcdif.yaml | 14
> +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml index
> 836955de3bc9..08ce19638fbd 100644 ---
> a/Documentation/devicetree/bindings/display/fsl,lcdif.yaml +++
> b/Documentation/devicetree/bindings/display/fsl,lcdif.yaml @@ -32,11
> +32,23 @@ properties:
> - fsl,imx8mn-lcdif
> - fsl,imx8mq-lcdif
> - const: fsl,imx6sx-lcdif
> + - items:
> + - const: fsl,imx6sl-lcdif
> + - const: fsl,imx6sx-lcdif
> + - const: fsl,imx28-lcdif
> + - items:
> + - const: fsl,imx6sll-lcdif
> + - const: fsl,imx6sx-lcdif
> + - const: fsl,imx28-lcdif
> + - items:
> + - enum:
> + - fsl,imx6sl-lcdif
> + - fsl,imx6sll-lcdif
> + - const: fsl,imx28-lcdif

What do we need this for? Either imx6sx-lcdif is a useful fallback
compatible or not. But not sometimes. Looking at the kernel driver: It
is. So IMHO only the three element variants should be allowed.

Regards,
Andreas