Re: [PATCH net-next 0/7] Support external snapshots on dwmac1000

[Maxime Chevallier <maxime.chevallier@bootlin.com>]

Hi Alexis,

On Tue, 29 Oct 2024 15:45:07 +0100
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:

> Hello Maxime,
> 
> On 10/29/24 12:54, Maxime Chevallier wrote:
> > Hi,
> > 
> > This series is another take on the pervious work [1] done by
> > Alexis Lothoré, that fixes the support for external snapshots
> > timestamping in GMAC3-based devices.
> >   
> 
> [...]
> 
> > [1]: https://lore.kernel.org/netdev/20230616100409.164583-1-alexis.lothore@bootlin.com/
> > 
> > Thanks Alexis for laying the groundwork for this,
> > 
> > Best regards,
> > 
> > Maxime  
> 
> Thanks for making this topic move forward. I suspect the series to be missing
> some bits: in the initial series you mention in [1], I also reworked
> stmmac_hwtstamp_set in stmmac_main.c, which is also currently assuming a GMAC4
> layout ([2]). I suspect that in your series current state, any new call to
> stmmac_hwtstamp_set will overwrite any previously configured hardware timestamping.

You are correct indeed, I missed this bit in the series. I'll update
that for v2. 

Thanks,

Maxime