Re: [PATCH v2 13/15] iio: light: apds9306: simplifies if branch in apds9306_write_event_config

Jonathan Cameron
2024-11-01T16:52:09Z

On Thu, 31 Oct 2024 16:27:08 +0100
Julien Stephan <jstephan@baylibre.com> wrote:

> Simplifies the regmap_wite if branch in apds9306_write_event_config.
Applied.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
> ---
> drivers/iio/light/apds9306.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/apds9306.c b/drivers/iio/light/apds9306.c
> index 8adc74040db2bddf93fbb773e3519abcc726b9a6..9c08e7c3ad0c17519689a630d42fe9b90438dfe8 100644
> --- a/drivers/iio/light/apds9306.c
> +++ b/drivers/iio/light/apds9306.c
> @@ -1125,10 +1125,7 @@ static int apds9306_write_event_config(struct iio_dev *indio_dev,
> }
> }
> case IIO_EV_TYPE_THRESH_ADAPTIVE:
> - if (state)
> - return regmap_field_write(rf->int_thresh_var_en, 1);
> - else
> - return regmap_field_write(rf->int_thresh_var_en, 0);
> + return regmap_field_write(rf->int_thresh_var_en, state);
> default:
> return -EINVAL;
> }
>