Re: [PATCH v2 02/15] iio: proximity: hx9023s: simplify code in write_event_config callback

Jonathan Cameron
2024-11-01T16:46:26Z

On Thu, 31 Oct 2024 16:26:57 +0100
Julien Stephan <jstephan@baylibre.com> wrote:

> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Applied to the togreg branch of iio.git and pushed out as testing.
Note if anyone else has time to review, I can still add tags for now.

I'll probably push it out as an (in theory) not rebasing tree early
next week to give a bit of time in next before a pull request.

Jonathan

> ---
> drivers/iio/proximity/hx9023s.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c
> index d8fb34060d3db88a3ba5ecdc209b14be8e42e8b9..38441b1ee040c7c26047b0cb2ac443ecb8396df3 100644
> --- a/drivers/iio/proximity/hx9023s.c
> +++ b/drivers/iio/proximity/hx9023s.c
> @@ -879,7 +879,7 @@ static int hx9023s_write_event_config(struct iio_dev *indio_dev,
> struct hx9023s_data *data = iio_priv(indio_dev);
>
> if (test_bit(chan->channel, &data->chan_in_use)) {
> - hx9023s_ch_en(data, chan->channel, !!state);
> + hx9023s_ch_en(data, chan->channel, state);
> __assign_bit(chan->channel, &data->chan_event,
> data->ch_data[chan->channel].enable);
> }
>