Re: [PATCH v2 03/15] iio: light: tsl2772: simplify code in write_event_config callback

Jonathan Cameron
2024-11-01T15:38:28Z

On Thu, 31 Oct 2024 16:26:58 +0100
Julien Stephan <jstephan@baylibre.com> wrote:

> iio_ev_state_store is actually using kstrtobool to check user
> input, then gives the converted boolean value to the write_event_config
> callback.
>
> Remove useless code in write_event_config callback.
>
> Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Applied.
> ---
> drivers/iio/light/tsl2772.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/iio/light/tsl2772.c b/drivers/iio/light/tsl2772.c
> index cab468a82b616a23394977da1d8822d29d8941d3..26082f239c4c3aeabfe73ed100d6e885f5266329 100644
> --- a/drivers/iio/light/tsl2772.c
> +++ b/drivers/iio/light/tsl2772.c
> @@ -1086,9 +1086,9 @@ static int tsl2772_write_interrupt_config(struct iio_dev *indio_dev,
> struct tsl2772_chip *chip = iio_priv(indio_dev);
>
> if (chan->type == IIO_INTENSITY)
> - chip->settings.als_interrupt_en = val ? true : false;
> + chip->settings.als_interrupt_en = val;
> else
> - chip->settings.prox_interrupt_en = val ? true : false;
> + chip->settings.prox_interrupt_en = val;
>
> return tsl2772_invoke_change(indio_dev);
> }
>