From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42361D1BDD2 for ; Mon, 4 Nov 2024 17:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ofU3iDgizx6YzKehUMFHWoGtFbTl4IysRdu8b/3youA=; b=KMc3+UOI12Rx4n0gPiM2VXFK9I C0H95lnc73s5zAdwEHqCZ+a9j/2A88tn1aPDGhbv9qRfH3VIatKrXDEtw+YtrqEG0g6j+WU8enyqQ 2/WkHQyfiXMW2GyqjOG/hCHm3GA7GQA0s6i80YoSDsgUn0avLgizI4yu2WTEk3W5KXj3URNO0AOCq nANhGF13pXhm/Mmo2M9PglHYFg2WBDn8TW4twupxudd4PK2WRdnOf5j1AfvS09/Y7wbilaUIXvdhs dfdDb57wZWz95Jumgc/Hk5zsbAHpPlPwA14+uxtDEaDUgtRUP/wURQmT2zgl5tEDzSQTZBEue0jAV qNrm2r7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1t80v0-0000000EXQ9-2fK8; Mon, 04 Nov 2024 17:31:10 +0000 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1t7yeA-0000000E9Rr-1xPC for linux-arm-kernel@lists.infradead.org; Mon, 04 Nov 2024 15:05:40 +0000 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-20cf3e36a76so45890615ad.0 for ; Mon, 04 Nov 2024 07:05:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1730732736; x=1731337536; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=ofU3iDgizx6YzKehUMFHWoGtFbTl4IysRdu8b/3youA=; b=UuyBsdRPEXxXvZB0fuPJAZrBz4Duvw+Aodkmyo0F6A1DULMH4hQPGQKmeDbR1h0NPz 9O2Xk/pfV3MAaSJ0CX2THp252Bfnk1C4njPBedtUdbPxa/SiFqk0T6sRVvveLQXlfmU6 fx3LQb9PVAZ95GjniU5YTbCpMwXFYc8REAgARoNj1wnTZyv13Ly9r5tyAHHJqy7GB9Bk ACzhbzfP8Mn+ENMzAuuLX/az00QW5od2sMs9Lt7rYZ1gRPotRWNU21JP3OEHBOGC2pQ3 FNktYQLrBhgnn2uursrVLi6bFxBFdVtCJdyfWLMxntf/QpzAuwhLKsYeLP5ThgAKDSq2 Bisg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730732736; x=1731337536; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ofU3iDgizx6YzKehUMFHWoGtFbTl4IysRdu8b/3youA=; b=v0EFHTKgmX7N8loblxinWB9d2UfZ12KiVjrNvy66CUUyJYyZM4jwmMFp9MW2b879Md K4SDmDP2p/2iCkCN5c1uirdNbgVt3KRY8Qbp1s06RObbhcEgUJj5VxCaYxZM2T9w6o46 HFWEN30pDunldf7rzP0v4P9oAbA27glK9Is5S50szxCZsN09Xnhr6qYa2uJZyVrZj/GX Fc3tBv+otstXvFLkT+vioiS9EvmjYyARhVGXdYEYF/TDqm7cLLWhAKgheBbxfF4uQJnk 95srBkoUboXog8z3g319S4MFsU4ZlbcxuG0CpsZyd4FWH7WOLgIbuW6t30X8Rv6xS6pw 3IsQ== X-Forwarded-Encrypted: i=1; AJvYcCUbhfDm2tGIeaFzkWBDxIMEjZbmlgErgdxMLW2b86bC1t5v9fY66n+sqvySgz6522o7FqJbPuPMF8lihlrEZxUL@lists.infradead.org X-Gm-Message-State: AOJu0Yx+D8roy63adZH9WuQz/+DM+qcS5ar/Eos/XctwipJn+DvH3xRu VBVmMKKLTPKlSj/TThJaBy0pQAk0N4iBXg6fajwamJJ0JoZDtpVy1mdwa8ISJw== X-Google-Smtp-Source: AGHT+IEl021krn6b1t/Wx5zX8WUa7/rO/gAFqJnTZVCNoxsul5bGUWlMYoB+HQZUJuohLeUfjZctig== X-Received: by 2002:a17:903:943:b0:205:68a4:b2d8 with SMTP id d9443c01a7336-21103aaa063mr240018155ad.11.1730732736068; Mon, 04 Nov 2024 07:05:36 -0800 (PST) Received: from thinkpad ([2409:40f4:3049:1cc7:217b:63a:40ce:2e01]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-7ee5da842absm4782828a12.17.2024.11.04.07.05.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 07:05:35 -0800 (PST) Date: Mon, 4 Nov 2024 20:35:21 +0530 From: Manivannan Sadhasivam To: Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , Krzysztof Wilczynski , Bjorn Helgaas , Linus Walleij , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Stefan Wahren , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn Subject: Re: [PATCH v3 05/12] PCI: of_property: Assign PCI instead of CPU bus address to dynamic bridge nodes Message-ID: <20241104150521.r4hbsurw4dbzlxpg@thinkpad> References: <20241102170908.fa5n6pz5ldxb66zk@thinkpad> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241104_070538_515929_FA51DAAE X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 04, 2024 at 09:54:57AM +0100, Andrea della Porta wrote: > Hi Manivannan, > > On 22:39 Sat 02 Nov , Manivannan Sadhasivam wrote: > > On Mon, Oct 28, 2024 at 03:07:22PM +0100, Andrea della Porta wrote: > > > When populating "ranges" property for a PCI bridge, of_pci_prop_ranges() > > > incorrectly use the CPU bus address of the resource. Since this is a PCI-PCI > > > bridge, the window should instead be in PCI address space. Call > > > pci_bus_address() on the resource in order to obtain the PCI bus > > > address. > > > > > > > of_pci_prop_ranges() could be called for PCI devices also (not just PCI > > bridges), right? > > Correct. Please note however that while the PCI-PCI bridge has the parent > address in CPU space, an endpoint device has it in PCI space: here we're > focusing on the bridge part. It probably used to work before since in many > cases the CPU and PCI address are the same, but it breaks down when they > differ. > When you say 'focusing', you are specifically referring to the bridge part of this API I believe. But I don't see a check for the bridge in your change, which is what concerning me. Am I missing something? - Mani -- மணிவண்ணன் சதாசிவம்