* [PATCH] clk: sunxi-ng: Use of_property_present() for non-boolean properties
@ 2024-11-04 19:04 Rob Herring (Arm)
2024-11-05 16:04 ` Chen-Yu Tsai
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2024-11-04 19:04 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Chen-Yu Tsai, Jernej Skrabec,
Samuel Holland
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel
The use of of_property_read_bool() for non-boolean properties is
deprecated in favor of of_property_present() when testing for property
presence.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
index 87e23d16ed0f..724b202863a8 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
@@ -356,7 +356,7 @@ int sun6i_rtc_ccu_probe(struct device *dev, void __iomem *reg)
const char *fw_name;
/* ext-osc32k was the only input clock in the old binding. */
- fw_name = of_property_read_bool(dev->of_node, "clock-names")
+ fw_name = of_property_present(dev->of_node, "clock-names")
? "ext-osc32k" : NULL;
ext_osc32k_clk = devm_clk_get_optional(dev, fw_name);
if (IS_ERR(ext_osc32k_clk))
--
2.45.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: sunxi-ng: Use of_property_present() for non-boolean properties
2024-11-04 19:04 [PATCH] clk: sunxi-ng: Use of_property_present() for non-boolean properties Rob Herring (Arm)
@ 2024-11-05 16:04 ` Chen-Yu Tsai
0 siblings, 0 replies; 2+ messages in thread
From: Chen-Yu Tsai @ 2024-11-05 16:04 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Jernej Skrabec, Samuel Holland,
Rob Herring (Arm)
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel
On Mon, 04 Nov 2024 13:04:55 -0600, Rob Herring (Arm) wrote:
> The use of of_property_read_bool() for non-boolean properties is
> deprecated in favor of of_property_present() when testing for property
> presence.
>
>
Applied to clk-for-6.13 in git@github.com:linux-sunxi/linux-sunxi.git, thanks!
[1/1] clk: sunxi-ng: Use of_property_present() for non-boolean properties
commit: 1054861bc258fb5798b7132453593cc3eb0639ba
Best regards,
--
Chen-Yu Tsai <wens@csie.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-05 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-04 19:04 [PATCH] clk: sunxi-ng: Use of_property_present() for non-boolean properties Rob Herring (Arm)
2024-11-05 16:04 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).