Re: [PATCH 03/21] dt-bindings: gpu: img: Power domain details

Conor Dooley
2024-11-05T18:18:58Z

[-- Attachment #1: Type: text/plain, Size: 2519 bytes --]

On Tue, Nov 05, 2024 at 06:05:54PM +0000, Conor Dooley wrote:
> On Tue, Nov 05, 2024 at 03:58:09PM +0000, Matt Coster wrote:
> > The single existing GPU (AXE-1-16M) only requires a single power domain.
> > Subsequent patches will add support for BXS-4-64 MC1, which has two power
> > domains. Add infrastructure now to allow for this.
> >
> > Signed-off-by: Matt Coster <matt.coster@imgtec.com>
> > ---
> > .../devicetree/bindings/gpu/img,powervr-rogue.yaml | 29 +++++++++++++++++++++-
> > 1 file changed, 28 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > index 6924831d3e9dd9b2b052ca8f9d7228ff25526532..55f422be1bc5b7564e3e81f24c4b93857f3e12fe 100644
> > --- a/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > +++ b/Documentation/devicetree/bindings/gpu/img,powervr-rogue.yaml
> > @@ -49,7 +49,16 @@ properties:
> > maxItems: 1
> >
> > power-domains:
> > - maxItems: 1
> > + minItems: 1
> > + maxItems: 2
> > +
> > + power-domain-names:
> > + oneOf:
> > + - items:
> > + - const: a
> > + - items:
> > + - const: a
> > + - const: b

Additionally, a & b? Are those actually the names for the power domains?

> >
> > required:
> > - compatible
> > @@ -57,10 +66,27 @@ required:
> > - clocks
> > - clock-names
> > - interrupts
> > + - power-domains
> > + - power-domain-names
>
> A new required property is an ABI break. Please explain why this is
> acceptable in your commit message.
>
> >
> > additionalProperties: false
> >
> > allOf:
> > + # Cores with a single power domain
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + anyOf:
> > + - const: img,img-axe-1-16m
> > + then:
> > + properties:
> > + power-domains:
> > + minItems: 1
> > + maxItems: 1
> > + power-domain-names:
> > + items:
> > + - const: a
> > # Vendor integrations using a single clock domain
> > - if:
> > properties:
> > @@ -90,4 +116,5 @@ examples:
> > clock-names = "core";
> > interrupts = <GIC_SPI 86 IRQ_TYPE_LEVEL_HIGH>;
> > power-domains = <&k3_pds 187 TI_SCI_PD_EXCLUSIVE>;
> > + power-domain-names = "a";
> > };
> >
> > --
> > 2.47.0
> >

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]