From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
Cristian Marussi <cristian.marussi@arm.com>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Brian Norris <briannorris@chromium.org>,
Julius Werner <jwerner@chromium.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Conor Dooley <conor.dooley@microchip.com>,
Daire McNamara <daire.mcnamara@microchip.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Gabriel Somlo <somlo@cmu.edu>,
"Michael S. Tsirkin" <mst@redhat.com>,
Florian Fainelli <florian.fainelli@broadcom.com>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Dinh Nguyen <dinguyen@kernel.org>,
Michal Simek <michal.simek@amd.com>,
Stefan Wahren <wahrenst@gmx.net>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Jay Buddhabhatti <jay.buddhabhatti@amd.com>,
Ronak Jain <ronak.jain@amd.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>,
arm-scmi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, chrome-platform@lists.linux.dev,
imx@lists.linux.dev, linux-riscv@lists.infradead.org,
linux-mediatek@lists.infradead.org, qemu-devel@nongnu.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] firmware: Switch back to struct platform_driver::remove()
Date: Tue, 12 Nov 2024 12:39:32 +0100 [thread overview]
Message-ID: <2024111223-gizzard-scabby-eb98@gregkh> (raw)
In-Reply-To: <36974feb6035201d53384557259ec72fe311053b.1731397962.git.u.kleine-koenig@baylibre.com>
On Tue, Nov 12, 2024 at 09:35:20AM +0100, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/firmware to use .remove(),
> with the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> I did a single patch for all of drivers/firmware. While I usually prefer
> to do one logical change per patch, this seems to be overengineering
> here as the individual changes are really trivial and shouldn't be much
> in the way for stable backports.
>
> There is no dedicated maintainer for drivers/firmware, maybe Sudeep as
> biggest committer there can take it? Or would it be sensible to split
> this patch?
I'll just take it now, thanks!
greg k-h
next prev parent reply other threads:[~2024-11-12 12:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-12 8:35 [PATCH] firmware: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-11-12 11:39 ` Greg Kroah-Hartman [this message]
2024-12-11 22:33 ` patchwork-bot+linux-riscv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024111223-gizzard-scabby-eb98@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=arm-scmi@vger.kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=briannorris@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=conor.dooley@microchip.com \
--cc=cristian.marussi@arm.com \
--cc=daire.mcnamara@microchip.com \
--cc=dinguyen@kernel.org \
--cc=festevam@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=imx@lists.linux.dev \
--cc=jay.buddhabhatti@amd.com \
--cc=jwerner@chromium.org \
--cc=kernel@pengutronix.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=michal.simek@amd.com \
--cc=mst@redhat.com \
--cc=praveen.teja.kundanala@amd.com \
--cc=qemu-devel@nongnu.org \
--cc=radhey.shyam.pandey@amd.com \
--cc=ronak.jain@amd.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=somlo@cmu.edu \
--cc=sudeep.holla@arm.com \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox