From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 048F1D6DDEC for ; Fri, 15 Nov 2024 08:54:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ib8VZEqrv/1oaZ9/wInvIKIw+crJoKvU0ii4qjb2l6A=; b=cG4WTvhem4e/Xc28hn8kPMBDI2 WtPm8WgyWDMkKL2JNTZECFwGpw9YnL4N6JJ3CtmOdCBvVoci0SYtd5Z9pWoEy5FV6Zz9f/mGXf/15 IPmYETVu0YD0kqFscoAD9D0s1l3yhvtRDZmRO1FkPKhhrqwtyMiw+L8BZCRr1KClZF4dzhnA2NME1 sbzk+TrSzpb1kuZ6IfDr9EZJVodW9pOGBZcR688U8NbxF71JV42BJdt+ca3cPPgvrYd59ZQIFbBv+ X8eDJlZVgish1gpKDsJB5MoGv/5WnWnPzTz5xc2HY42bai7I+cVC7HNT2/mKM6Xjn9U8eO8rv/leH PyrHnM6A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tBs5e-000000026OS-1bwW; Fri, 15 Nov 2024 08:54:06 +0000 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tBs3v-0000000264B-0zmn for linux-arm-kernel@lists.infradead.org; Fri, 15 Nov 2024 08:52:20 +0000 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-20e576dbc42so5117285ad.0 for ; Fri, 15 Nov 2024 00:52:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1731660738; x=1732265538; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Ib8VZEqrv/1oaZ9/wInvIKIw+crJoKvU0ii4qjb2l6A=; b=WYHRJLDZFxAE+anyRnVSszKIUAuJhWaI3rvZydajNj5zGah5EC8u/eHQeaYkFsucjZ oEdK3zb18FdlRz67TW+c8C7UOTnKOKeJGLI5kFV9ihrqmXJsJ6/a1AUoq2wOD2VRu0px G1ssrOAw6VOPSItb7y4yUoa9wjmLXn25D2MomSqqcTf3IUZSB0CDXwtHwPAOUGcB7EM/ j15g58wo8S0esoTBPdbpThFfn7JvdFucOXSccqCb1toAgNw4RLeKwtt2uCxqK9K8KtQy RafSngLrKXm/1x/KCZSgnR8drFtd+qB0TvDiFehvH6O4PrpSLcXT4YWdLifhl+XdlTKX bSHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731660738; x=1732265538; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ib8VZEqrv/1oaZ9/wInvIKIw+crJoKvU0ii4qjb2l6A=; b=qXBpQuJ4WOcHV2XfmC/EmQSBcL4K806ZQ1QgbLwbd1jebCTEyZP/dQ3z3ts79a+r1c vQAZb83UwadENxHr45sLDJlHA6FUmFqf4H8F+lC+/rVW85KDSjivL/ycRcbc4CgOWaRk k4LIYCIxBuu3DCOurQqkCiEG393s8rptZoImythq0qQoelnGyAePHe23aUa4rujXTVu8 Piuh80gt1pgrACoS/7+HyoUovep4+9xIkNiQgOmrZ1Hww1Ha0e3lAIAzp7TVvqQtdIWc phlpcH2qb9qvFSxEbLjlIsRpJpwUoi3RNu2ufME6yeyddfnPrigEyUtAFgjf/r7873AQ qMpQ== X-Forwarded-Encrypted: i=1; AJvYcCW4n/R76/j7W5anai8dhkdSw35Ht/LbA+gWgVIgkwKNbef/mid3Cvb9u0O16J2pJXV2EZ0s3PxnDk75L9roWAex@lists.infradead.org X-Gm-Message-State: AOJu0Yxo2QTClotE+YNO1hxjl6Cb7pCTe5UldQmOKsYlbY5/rX59c0TL b0g3kM25dpCR3OQvcVXoCQvCcTeeV4UZp5ArlJr7+jdQ5+jTYiMJVPjDBPhTm3tsPv88bI1yiMA = X-Google-Smtp-Source: AGHT+IHdGj34kZwTu+86oRWdYE8Hh+iSzm8/CcDrLHSTWam/KJWm+8OMU1/DV2v8HzbHvL2Xyw2aBA== X-Received: by 2002:a17:902:cf10:b0:20c:ea0a:9665 with SMTP id d9443c01a7336-211d0d83a21mr33312155ad.32.1731660738461; Fri, 15 Nov 2024 00:52:18 -0800 (PST) Received: from thinkpad ([117.193.208.47]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-211d0dc51a1sm8044215ad.57.2024.11.15.00.52.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 00:52:17 -0800 (PST) Date: Fri, 15 Nov 2024 14:22:09 +0530 From: Manivannan Sadhasivam To: Lorenzo Bianconi Cc: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] PCI: mediatek-gen3: Add missing reset_control_deassert() for mac_rst in mtk_pcie_en7581_power_up() Message-ID: <20241115085209.v3tyiybaaeoeu6t4@thinkpad> References: <20241109-pcie-en7581-fixes-v2-0-0ea3a4af994f@kernel.org> <20241109-pcie-en7581-fixes-v2-1-0ea3a4af994f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241109-pcie-en7581-fixes-v2-1-0ea3a4af994f@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241115_005219_332607_73852920 X-CRM114-Status: GOOD ( 18.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Nov 09, 2024 at 10:28:37AM +0100, Lorenzo Bianconi wrote: > Even if this is not a real issue since Airoha EN7581 SoC does not require > the mac reset line, add missing reset_control_deassert() for mac reset > line in mtk_pcie_en7581_power_up() callback. > > Signed-off-by: Lorenzo Bianconi Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 66ce4b5d309bb6d64618c70ac5e0a529e0910511..0fac0b9fd785e463d26d29d695b923db41eef9cc 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -897,6 +897,9 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > */ > mdelay(PCIE_EN7581_RESET_TIME_MS); > > + /* MAC power on and enable transaction layer clocks */ > + reset_control_deassert(pcie->mac_reset); > + > pm_runtime_enable(dev); > pm_runtime_get_sync(dev); > > @@ -931,6 +934,7 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > err_clk_prepare: > pm_runtime_put_sync(dev); > pm_runtime_disable(dev); > + reset_control_assert(pcie->mac_reset); > reset_control_bulk_assert(pcie->soc->phy_resets.num_resets, pcie->phy_resets); > err_phy_deassert: > phy_power_off(pcie->phy); > > -- > 2.47.0 > -- மணிவண்ணன் சதாசிவம்