[PATCH sound-next] ASoC: rockchip: i2s-tdm: Fix a useless call issue

[PATCH sound-next] ASoC: rockchip: i2s-tdm: Fix a useless call issue

[Dheeraj Reddy Jonnalagadda]

This commit fixes a useless call issue detected by Coverity
(CID 1507978). The call to rockchip_i2s_ch_to_io is unnecessary as its
return value is never checked or used.

Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
---
 sound/soc/rockchip/rockchip_i2s_tdm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/rockchip/rockchip_i2s_tdm.c b/sound/soc/rockchip/rockchip_i2s_tdm.c
index d1f28699652f..10f46fbe5175 100644
--- a/sound/soc/rockchip/rockchip_i2s_tdm.c
+++ b/sound/soc/rockchip/rockchip_i2s_tdm.c
@@ -577,7 +577,6 @@ static int rockchip_i2s_io_multiplex(struct snd_pcm_substream *substream,
 			return -EINVAL;
 		}
 
-		rockchip_i2s_ch_to_io(val, true);
 	} else {
 		struct snd_pcm_str *capture_str =
 			&substream->pcm->streams[SNDRV_PCM_STREAM_CAPTURE];
-- 
2.34.1

Re: [PATCH sound-next] ASoC: rockchip: i2s-tdm: Fix a useless call issue

[kernel test robot]

Hi Dheeraj,

kernel test robot noticed the following build warnings:

[auto build test WARNING on rockchip/for-next]
[also build test WARNING on linus/master v6.12-rc7 next-20241115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Dheeraj-Reddy-Jonnalagadda/ASoC-rockchip-i2s-tdm-Fix-a-useless-call-issue/20241115-195011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next
patch link:    https://lore.kernel.org/r/20241115114924.23843-1-dheeraj.linuxdev%40gmail.com
patch subject: [PATCH sound-next] ASoC: rockchip: i2s-tdm: Fix a useless call issue
config: loongarch-randconfig-r054-20241117 (https://download.01.org/0day-ci/archive/20241117/202411170713.FymmFfl3-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241117/202411170713.FymmFfl3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411170713.FymmFfl3-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> sound/soc/rockchip/rockchip_i2s_tdm.c:517:12: warning: 'rockchip_i2s_ch_to_io' defined but not used [-Wunused-function]
     517 | static int rockchip_i2s_ch_to_io(unsigned int ch, bool substream_capture)
         |            ^~~~~~~~~~~~~~~~~~~~~


vim +/rockchip_i2s_ch_to_io +517 sound/soc/rockchip/rockchip_i2s_tdm.c

081068fd641403 Nicolas Frattaroli 2021-10-01  516  
081068fd641403 Nicolas Frattaroli 2021-10-01 @517  static int rockchip_i2s_ch_to_io(unsigned int ch, bool substream_capture)
081068fd641403 Nicolas Frattaroli 2021-10-01  518  {
081068fd641403 Nicolas Frattaroli 2021-10-01  519  	if (substream_capture) {
081068fd641403 Nicolas Frattaroli 2021-10-01  520  		switch (ch) {
081068fd641403 Nicolas Frattaroli 2021-10-01  521  		case I2S_CHN_4:
081068fd641403 Nicolas Frattaroli 2021-10-01  522  			return I2S_IO_6CH_OUT_4CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  523  		case I2S_CHN_6:
081068fd641403 Nicolas Frattaroli 2021-10-01  524  			return I2S_IO_4CH_OUT_6CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  525  		case I2S_CHN_8:
081068fd641403 Nicolas Frattaroli 2021-10-01  526  			return I2S_IO_2CH_OUT_8CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  527  		default:
081068fd641403 Nicolas Frattaroli 2021-10-01  528  			return I2S_IO_8CH_OUT_2CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  529  		}
081068fd641403 Nicolas Frattaroli 2021-10-01  530  	} else {
081068fd641403 Nicolas Frattaroli 2021-10-01  531  		switch (ch) {
081068fd641403 Nicolas Frattaroli 2021-10-01  532  		case I2S_CHN_4:
081068fd641403 Nicolas Frattaroli 2021-10-01  533  			return I2S_IO_4CH_OUT_6CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  534  		case I2S_CHN_6:
081068fd641403 Nicolas Frattaroli 2021-10-01  535  			return I2S_IO_6CH_OUT_4CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  536  		case I2S_CHN_8:
081068fd641403 Nicolas Frattaroli 2021-10-01  537  			return I2S_IO_8CH_OUT_2CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  538  		default:
081068fd641403 Nicolas Frattaroli 2021-10-01  539  			return I2S_IO_2CH_OUT_8CH_IN;
081068fd641403 Nicolas Frattaroli 2021-10-01  540  		}
081068fd641403 Nicolas Frattaroli 2021-10-01  541  	}
081068fd641403 Nicolas Frattaroli 2021-10-01  542  }
081068fd641403 Nicolas Frattaroli 2021-10-01  543  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki