From: Rob Herring <robh@kernel.org>
To: Jacky Chou <jacky_chou@aspeedtech.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, joel@jms.id.au, andrew@codeconstruct.com.au,
hkallweit1@gmail.com, linux@armlinux.org.uk,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [net-next 2/3] net: mdio: aspeed: Add support for AST2700
Date: Tue, 19 Nov 2024 12:20:41 -0600 [thread overview]
Message-ID: <20241119182041.GB1962443-robh@kernel.org> (raw)
In-Reply-To: <20241118104735.3741749-3-jacky_chou@aspeedtech.com>
On Mon, Nov 18, 2024 at 06:47:34PM +0800, Jacky Chou wrote:
> The Aspeed 7th generation SoC features three Aspeed MDIO.
> The design of AST2700 MDIO controller is the same as AST2600.
> Therefore, just add AST2700 compatible here.
If they are "the same", you don't need to add the compatible here. You
still need to add it to the binding, but make ast2600 a fallback
compatible.
>
> Signed-off-by: Jacky Chou <jacky_chou@aspeedtech.com>
> ---
> drivers/net/mdio/mdio-aspeed.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/mdio/mdio-aspeed.c b/drivers/net/mdio/mdio-aspeed.c
> index e55be6dc9ae7..4d5a115baf85 100644
> --- a/drivers/net/mdio/mdio-aspeed.c
> +++ b/drivers/net/mdio/mdio-aspeed.c
> @@ -188,6 +188,7 @@ static void aspeed_mdio_remove(struct platform_device *pdev)
>
> static const struct of_device_id aspeed_mdio_of_match[] = {
> { .compatible = "aspeed,ast2600-mdio", },
> + { .compatible = "aspeed,ast2700-mdio", },
> { },
> };
> MODULE_DEVICE_TABLE(of, aspeed_mdio_of_match);
> --
> 2.25.1
>
next prev parent reply other threads:[~2024-11-19 18:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 10:47 [net-next 0/3] Add Aspeed G7 MDIO support Jacky Chou
2024-11-18 10:47 ` [net-next 1/3] dt-bindings: net: add support for AST2700 Jacky Chou
2024-11-19 18:18 ` Rob Herring
2024-11-18 10:47 ` [net-next 2/3] net: mdio: aspeed: Add " Jacky Chou
2024-11-19 18:20 ` Rob Herring [this message]
2024-11-18 10:47 ` [net-next 3/3] net: mdio: aspeed: Add dummy read for fire control Jacky Chou
2024-11-18 23:05 ` Andrew Jeffery
2024-11-19 1:52 ` Andrew Lunn
2024-11-19 1:50 ` [net-next 0/3] Add Aspeed G7 MDIO support Andrew Lunn
[not found] ` <SEYPR06MB513475D2B233EA9BDF52AD259D202@SEYPR06MB5134.apcprd06.prod.outlook.com>
2024-11-19 13:25 ` 回覆: " Andrew Lunn
[not found] ` <SEYPR06MB513478C462915513DE7BE1AE9DFCA@SEYPR06MB5134.apcprd06.prod.outlook.com>
2025-10-27 12:34 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241119182041.GB1962443-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jacky_chou@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).