From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EFF19D6C2AF for ; Tue, 19 Nov 2024 21:47:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Type:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To :Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5G2ddViU/A3u+50BSZ1Qr+Wx9vIcymFDZsXMX1SXY1U=; b=M4Cfurz0lHxpMMtnm+xIdT+Zna WDdr16S/IDPuMq3SnIFgmU8r/DR6tueRpdKhR6124NHReDx3zyRo9xB4qGhsObI+daUbMgViqrFtk DnBOjvXN+nF+EKH0VfdHAnlrx+77fgmL1VMoCXadYCQFdNbyxuv6nVrWEOhSawRL6oUedfPQhsfc2 Eq+A8DwhVOY2dpCZV+ZFOMtVB0lYb7sG06chDTl9t3746gieeZcWFf+cj/wCOe4KVtlv4rJFwfUbj dwAtMpid9Un4bFBtWfdfCtc9gsxJpv2a9id/0AsAgwVntKJhFeEsvrLZNXPtI/rZT/REg03lBDq55 uFhRFIeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tDW3x-0000000Dpyo-3yHP; Tue, 19 Nov 2024 21:47:09 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tDV06-0000000Djfq-3HFQ for linux-arm-kernel@lists.infradead.org; Tue, 19 Nov 2024 20:39:08 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 197C45C540C; Tue, 19 Nov 2024 20:38:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 90738C4CECF; Tue, 19 Nov 2024 20:39:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732048745; bh=OOWExM1N60jCy1dSIf8NXBKIEYTUdBfF3QKNExZ85/s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fUdJEGNf8LcVFkS4Y/CHZrJRYqDVlgSp1kQtKjHAybajS3sjie9VoShoEaevbBPhW ki94a71CZqVvrGOo7s8W5Z8fuJrxDtqPccHIBE7cCLqVvZoLC/enAP39ybhA6173Jb N35VyndijJVXdMzwKFBuX2F3xs91DDblYtFFXUu9r0JyVn7yF9EkOG8vjwhP0wnhm1 bWRtfU2PxlVb7B3BGn1flApnJG5KGRClE4rdvYQSP0+7B+tJU6rQTLS5/Sio/VYXqw UkSeXTNVdJvqhYlvthufmgJg0GDqQAcuW1FkEUwYk+0M8gpYjDUg/Aqyq7U9aRYOg5 FrpeQC+YJuDTw== Date: Tue, 19 Nov 2024 14:39:03 -0600 From: Rob Herring To: "Jan Petrous (OSS)" Subject: Re: [PATCH v5 13/16] dt-bindings: net: Add DT bindings for DWMAC on NXP S32G/R SoCs Message-ID: <20241119203903.GA2249015-robh@kernel.org> References: <20241119-upstream_s32cc_gmac-v5-0-7dcc90fcffef@oss.nxp.com> <20241119-upstream_s32cc_gmac-v5-13-7dcc90fcffef@oss.nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241119-upstream_s32cc_gmac-v5-13-7dcc90fcffef@oss.nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241119_123906_912715_5FC75015 X-CRM114-Status: GOOD ( 19.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , NXP S32 Linux Team , Emil Renner Berthing , imx@lists.linux.dev, Alexandre Torgue , Claudiu Beznea , Eric Dumazet , Iyappan Subramanian , Quan Nguyen , Fabio Estevam , linux-stm32@st-md-mailman.stormreply.com, Russell King , Jose Abreu , Jakub Kicinski , Paolo Abeni , Richard Cochran , devicetree@vger.kernel.org, Conor Dooley , Maxime Coquelin , linux-arm-msm@vger.kernel.org, Sascha Hauer , Keyur Chudgar , Minda Chen , Giuseppe Cavallaro , linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Vinod Koul , Pengutronix Kernel Team , Krzysztof Kozlowski , Shawn Guo , "David S. Miller" , Heiner Kallweit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 19, 2024 at 04:00:19PM +0100, Jan Petrous (OSS) wrote: > Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx > and S32R45 automotive series SoCs. > > Signed-off-by: Jan Petrous (OSS) > --- > .../devicetree/bindings/net/nxp,s32-dwmac.yaml | 105 +++++++++++++++++++++ > .../devicetree/bindings/net/snps,dwmac.yaml | 3 + > 2 files changed, 108 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml > new file mode 100644 > index 000000000000..a141e826a295 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nxp,s32-dwmac.yaml > @@ -0,0 +1,105 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2021-2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nxp,s32-dwmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP S32G2xx/S32G3xx/S32R45 GMAC ethernet controller > + > +maintainers: > + - Jan Petrous (OSS) > + > +description: > + This device is a Synopsys DWC IP, integrated on NXP S32G/R SoCs. > + The SoC series S32G2xx and S32G3xx feature one DWMAC instance, > + the SoC S32R45 has two instances. The devices can use RGMII/RMII/MII > + interface over Pinctrl device or the output can be routed > + to the embedded SerDes for SGMII connectivity. > + > +properties: > + compatible: > + oneOf: > + - const: nxp,s32g2-dwmac > + - items: > + - enum: > + - nxp,s32g3-dwmac > + - nxp,s32r45-dwmac > + - const: nxp,s32g2-dwmac > + > + reg: > + items: > + - description: Main GMAC registers > + - description: GMAC PHY mode control register > + > + interrupts: > + maxItems: 1 > + > + interrupt-names: > + const: macirq > + > + clocks: > + items: > + - description: Main GMAC clock > + - description: Transmit clock > + - description: Receive clock > + - description: PTP reference clock > + > + clock-names: > + items: > + - const: stmmaceth > + - const: tx > + - const: rx > + - const: ptp_ref > + > +required: > + - clocks > + - clock-names > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + ethernet@4033c000 { > + compatible = "nxp,s32g2-dwmac"; > + reg = <0x0 0x4033c000 0x0 0x2000>, /* gmac IP */ > + <0x0 0x4007c004 0x0 0x4>; /* GMAC_0_CTRL_STS */ > + interrupt-parent = <&gic>; > + interrupts = ; > + interrupt-names = "macirq"; > + snps,mtl-rx-config = <&mtl_rx_setup>; > + snps,mtl-tx-config = <&mtl_tx_setup>; > + clocks = <&clks 24>, <&clks 17>, <&clks 16>, <&clks 15>; > + clock-names = "stmmaceth", "tx", "rx", "ptp_ref"; > + phy-mode = "rgmii-id"; > + phy-handle = <&phy0>; > + > + mtl_rx_setup: rx-queues-config { > + snps,rx-queues-to-use = <5>; > + }; > + > + mtl_tx_setup: tx-queues-config { > + snps,tx-queues-to-use = <5>; > + }; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "snps,dwmac-mdio"; > + > + phy0: ethernet-phy@0 { > + reg = <0>; > + }; > + }; > + }; > + }; > diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > index 4e2ba1bf788c..a88d1c236eaf 100644 > --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml > +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml > @@ -66,6 +66,9 @@ properties: > - ingenic,x2000-mac > - loongson,ls2k-dwmac > - loongson,ls7a-dwmac > + - nxp,s32g2-dwmac > + - nxp,s32g3-dwmac > + - nxp,s32r-dwmac You really only need to add nxp,s32g2-dwmac since it's always present. Other than the yamllint issue, Reviewed-by: Rob Herring (Arm)