From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E3A16E6ADD5 for ; Sat, 23 Nov 2024 09:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xZiVNGou0sUPR+VUZtEVpUsLh0jpbMmext51WC1uOek=; b=0l2wJX6yoZh+NoeqsypkTMSwGi jHWP3y2swZqn3uGWoUeQG9u5c81lZsNcDatQ7Bqp7zFZ5iQsI6biVqDyp4LcUnQNlI9tlpleIibWZ GBxoWu5sqAxA2MF7R0xN0OrGA8r2ca1BukUirCCEpvqSoatcl3rqhXOUoOWVu6WjNIb0nvPpQ0O/v pajWudnzbhy8E/+b0kr02vnzS8tNoCY2982HJf/2jXvlsymGzpJO5/h92Da36U0a6wGTD6ry1qFlK BVXkQNFILAIDn1U5rZlI6SiOIlnHNJjLja35LPygBxZV4//h0M2s8BvFS2gPgsUoEjcr1jatlS9sg 7r0/uxLA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tEm6V-0000000408A-3cvX; Sat, 23 Nov 2024 09:06:59 +0000 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tEm5X-00000003zsU-3lWP for linux-arm-kernel@lists.infradead.org; Sat, 23 Nov 2024 09:06:01 +0000 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-724f74d6457so173240b3a.0 for ; Sat, 23 Nov 2024 01:05:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1732352759; x=1732957559; darn=lists.infradead.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xZiVNGou0sUPR+VUZtEVpUsLh0jpbMmext51WC1uOek=; b=GdiUXVrDK8aGY53Rfw2AgomWvZutleNHfJ/P28MfA4TNjmBnVdAxURU150rm4GrraM dpKkDMkXGmfjvMkDYr2a+/R0N/md3hO8fC/HzwU+MplvOWLJaaphe53ppuusUoTA1fRu bwIokPPzLJI3jT/xz6k1Ifkin+jFoQnLnVbyoJzVjnVyQiR83MslJ13XgUQE4lwQ+6dg tfbFSLXfUpraH7BjWj5dyHAF7ogwnbi3wUfTr+13nLexnvuSWykvW4axFFl7cKC0EJIL mb5KoltQ1r0zh2T8yqXl80MwoKLDERyG8hBUk+MFRpbyQdeF+cJ3LF162lR5LGGKzKTI zsvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732352759; x=1732957559; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xZiVNGou0sUPR+VUZtEVpUsLh0jpbMmext51WC1uOek=; b=dAspMPlwIY/ooCyiSV5Y/PyKsUNw+QVxGzYU9JzSb2W/6XcDu7EMGz8mS8JQZKs55w 2WCeXiv3FW12ceyxNW2IvBHieb1hxBYhTncyOor2nWuUVlHiWkGA2fzKk5FHtdkm6ruE 6VFF0IHhLa6wQgVAN7ydGEp2NUaJfLauH3OX4iUd1ODAW/oq0sCw3PrDtgEndwl1jCOO qTIOceHMO2atLWq/2ElZ5rKt8kap3MuKARf1U9E/QgHgHHoQUETWlm+YsaU08vnSoRre mXbaKiO3xGpD1DVwOc9lkhSsx+pVRFPgawB9vkTduOZy2QZn5bRX1vIiJDJHvasOFfr+ Jrvg== X-Forwarded-Encrypted: i=1; AJvYcCUtZodcAzvO4lOcOovTHA3Ptz8yYGGTjNczdmCFtgcNbewE192rbAjMAd9bXsqgeDdUpVb6rcoBcaAoMNtv+Cw3@lists.infradead.org X-Gm-Message-State: AOJu0YywlWgMZ0s3bktdFWxzrk2zJqJNvIBI8AcyMkUfIJcKqRFnwMfl LN8ILjzrtxiQmcdA0gUjEbNzQ8SKEJJAA1MQM3ragAL72sNQiyQR07sloHymug== X-Gm-Gg: ASbGncu43QUo1nI7dBQ8abXDLXv0+MwSJ2aozzVjsJfRrpBWZ6FLAMvzB3ar/4qouwf JX55gqyrckWObrfQ4fsLZtKs+2LxSv5GMktV6xEviWI+Aglh8zK+7TfeWW4isDjTcBP2riMFu+Z 1+YjOLRZ0kgi8KE/2BYPjIGReWTLvo8pMo9rls0yvtHMbW2OkdmGcsmhOb4Tx8sELGiQcPLccwg Sv8pJGwsZNeIFW2Ga2IPnvbuv/8aKhmBnkRTGF+A2WQw2ZKbBpojppD1SeXFHJbuA== X-Google-Smtp-Source: AGHT+IGmEszMNhZtwje0Xvl4SgF09bMp9/3Vg2UfRxuTgmP2VK0VjGMW/4vV+mCtT1R8tU+WzR0uag== X-Received: by 2002:a05:6a00:244e:b0:724:591e:ea20 with SMTP id d2e1a72fcca58-724df66d881mr7872246b3a.14.1732352758798; Sat, 23 Nov 2024 01:05:58 -0800 (PST) Received: from thinkpad ([2409:40f2:101e:13d7:85cf:a1c4:6490:6f75]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de532db3sm2877085b3a.93.2024.11.23.01.05.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Nov 2024 01:05:58 -0800 (PST) Date: Sat, 23 Nov 2024 14:35:49 +0530 From: Manivannan Sadhasivam To: Lorenzo Bianconi Cc: Ryder Lee , Jianjun Wang , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Bjorn Helgaas , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v4 2/6] PCI: mediatek-gen3: rely on clk_bulk_prepare_enable() in mtk_pcie_en7581_power_up() Message-ID: <20241123090549.epzrv5o2i5q2mgz7@thinkpad> References: <20241118-pcie-en7581-fixes-v4-0-24bb61703ad7@kernel.org> <20241118-pcie-en7581-fixes-v4-2-24bb61703ad7@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20241118-pcie-en7581-fixes-v4-2-24bb61703ad7@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241123_010559_949134_7DFBE71D X-CRM114-Status: GOOD ( 17.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 18, 2024 at 09:04:54AM +0100, Lorenzo Bianconi wrote: > Replace clk_bulk_prepare() and clk_bulk_enable() with > clk_bulk_prepare_enable() in mtk_pcie_en7581_power_up() routine. > > Reviewed-by: AngeloGioacchino Del Regno > Signed-off-by: Lorenzo Bianconi Reviewed-by: Manivannan Sadhasivam - Mani > --- > drivers/pci/controller/pcie-mediatek-gen3.c | 14 +++----------- > 1 file changed, 3 insertions(+), 11 deletions(-) > > diff --git a/drivers/pci/controller/pcie-mediatek-gen3.c b/drivers/pci/controller/pcie-mediatek-gen3.c > index 4d1c797a32c236faf79428eb8a83708e9c4f21d8..3cfcb45d31508142d28d338ff213f70de9b4e608 100644 > --- a/drivers/pci/controller/pcie-mediatek-gen3.c > +++ b/drivers/pci/controller/pcie-mediatek-gen3.c > @@ -948,12 +948,6 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > pm_runtime_enable(dev); > pm_runtime_get_sync(dev); > > - err = clk_bulk_prepare(pcie->num_clks, pcie->clks); > - if (err) { > - dev_err(dev, "failed to prepare clock\n"); > - goto err_clk_prepare; > - } > - > val = FIELD_PREP(PCIE_VAL_LN0_DOWNSTREAM, 0x47) | > FIELD_PREP(PCIE_VAL_LN1_DOWNSTREAM, 0x47) | > FIELD_PREP(PCIE_VAL_LN0_UPSTREAM, 0x41) | > @@ -966,17 +960,15 @@ static int mtk_pcie_en7581_power_up(struct mtk_gen3_pcie *pcie) > FIELD_PREP(PCIE_K_FINETUNE_MAX, 0xf); > writel_relaxed(val, pcie->base + PCIE_PIPE4_PIE8_REG); > > - err = clk_bulk_enable(pcie->num_clks, pcie->clks); > + err = clk_bulk_prepare_enable(pcie->num_clks, pcie->clks); > if (err) { > dev_err(dev, "failed to prepare clock\n"); > - goto err_clk_enable; > + goto err_clk_prepare_enable; > } > > return 0; > > -err_clk_enable: > - clk_bulk_unprepare(pcie->num_clks, pcie->clks); > -err_clk_prepare: > +err_clk_prepare_enable: > pm_runtime_put_sync(dev); > pm_runtime_disable(dev); > reset_control_assert(pcie->mac_reset); > > -- > 2.47.0 > -- மணிவண்ணன் சதாசிவம்