From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9546AE668AB for ; Sun, 24 Nov 2024 13:09:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3jhO9VUH6Et5fIdconOSnmX2TV4k0Jrfk9ixokIPYRI=; b=1orbpnKBfej0VelB6PohyHBeVB zTQk9p4p+iUxi6pmwwKzAagQsvgju2pL4rtvbgu6fvUTqD465I1jnWlMbYnB3Ia8CxvSOJQ0u+hgC HNu38mcfjInjaS1ZcMo1oJZRlTXwFna/lWD6w8uiiSWd1Aoj1PpiptbysZdeH+rfTpAqgB7Hz9mPq Hkq+1lmRcNp8fYxQycVSSCz1j48BkUlbYz/lG4nmghvFyuUEnXv1slLW1f1BsM3J7lb1ddxgj3REf GHBHtxN6tm2P8trXklEE1/n2i7cvJwIO1hcjpAlkGbj2gaJxlKOGw858qVObUiksJSHiMIudfkAV9 GVX/TKcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tFCMU-00000005r9i-36BC; Sun, 24 Nov 2024 13:09:14 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tFCCI-00000005oqF-3ghc for linux-arm-kernel@lists.infradead.org; Sun, 24 Nov 2024 12:58:44 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C4F4E5C0FF7; Sun, 24 Nov 2024 12:57:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 68850C4CECC; Sun, 24 Nov 2024 12:58:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732453122; bh=EYUPj0mv8QNgvzoMAVNtGMp7DumB52AqR8hSylp93w4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=d2j5507Zj6Y4CnZ40A6HiQfNzCrpFS9pYT19UUBzUBqWcKnhPaSHA1fuWDEOmx0PJ t1pkgNjMPIg7veZUzoe63GI7DjeRlpTiID8unNbWsj/Bg2VssqZvMlRqw2ezpZaWsV djBJo6bfiqDJc82QxX3OPuEbiKbJlmWwKaCLD4kGurouegQh9/BhXWXX6oSGKJPnec KI7NHhbaIZoIAnmdSfrG9BHyaFWxQ2xiakePNf0v/22PfGHA9RiK0zChL3IiIuc67R r4vqodvUdEKhyYqs6C3VCaaFTb1s1fhMxie9a3eMS34QktTE7lUWyLkYYpZMnFaNak wcQP33dCriEeA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Andy Shevchenko , Greg Kroah-Hartman , Linus Walleij , Bartosz Golaszewski , Sasha Levin , daniel@zonque.org, haojian.zhuang@gmail.com, robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org Subject: [PATCH AUTOSEL 5.4 5/5] USB: gadget: pxa27x_udc: Avoid using GPIOF_ACTIVE_LOW Date: Sun, 24 Nov 2024 07:58:05 -0500 Message-ID: <20241124125817.3341248-5-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20241124125817.3341248-1-sashal@kernel.org> References: <20241124125817.3341248-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.4.286 Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241124_045842_974102_3909CDD7 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Andy Shevchenko [ Upstream commit 62d2a940f29e6aa5a1d844a90820ca6240a99b34 ] Avoid using GPIOF_ACTIVE_LOW as it's deprecated and subject to remove. Signed-off-by: Andy Shevchenko Acked-by: Greg Kroah-Hartman Reviewed-by: Linus Walleij Link: https://lore.kernel.org/r/20241104093609.156059-6-andriy.shevchenko@linux.intel.com Signed-off-by: Bartosz Golaszewski Signed-off-by: Sasha Levin --- drivers/usb/gadget/udc/pxa27x_udc.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 014233252299c..43bb5c66b2b61 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2360,18 +2360,19 @@ static int pxa_udc_probe(struct platform_device *pdev) struct pxa_udc *udc = &memory; int retval = 0, gpio; struct pxa2xx_udc_mach_info *mach = dev_get_platdata(&pdev->dev); - unsigned long gpio_flags; if (mach) { - gpio_flags = mach->gpio_pullup_inverted ? GPIOF_ACTIVE_LOW : 0; gpio = mach->gpio_pullup; if (gpio_is_valid(gpio)) { retval = devm_gpio_request_one(&pdev->dev, gpio, - gpio_flags, + GPIOF_OUT_INIT_LOW, "USB D+ pullup"); if (retval) return retval; udc->gpiod = gpio_to_desc(mach->gpio_pullup); + + if (mach->gpio_pullup_inverted ^ gpiod_is_active_low(udc->gpiod)) + gpiod_toggle_active_low(udc->gpiod); } udc->udc_command = mach->udc_command; } else { -- 2.43.0