From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 977C3D6EC0E for ; Fri, 29 Nov 2024 14:08:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=quLx9MdYvZvRG/vgEjL5/P3DbPIJS33OHNE2fWBF6II=; b=p1fuH4PbPmwjEHWE7utlCrmwEX GrDTxnlWq8VRmKeiqs7mSunKrFjM6fSACq6DXlUNoB8b+MMlOGoxOjH0Np69zaakvzBjQiU2HSh23 iZRuxJ1wWGrrhNGXDhuqX1RDsx+h6M+NZK6CcPJ0URkY7y+zwv1qEXvZihAQQJ6vXcy21vAfJlUD0 uy2D+VdAh4TS/WQe6FelHqx8UU7cphYJD1g2J8KvhVO7/PyCBsVM7XgpAoutnLcKUjwtPG+646I6R MEzmLz+nI90cec0cWnTWhtM/GrA/7kfPSDiMUoS3VWf1kkwijbZxlvs1CIemepq5CWJN33k4UhjLI wS/uUp8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tH1ex-00000000H8s-2Iym; Fri, 29 Nov 2024 14:07:51 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tH1dw-00000000Gy9-2YQg; Fri, 29 Nov 2024 14:06:49 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6C69E5C4540; Fri, 29 Nov 2024 14:06:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06E69C4CECF; Fri, 29 Nov 2024 14:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732889207; bh=hk1dUhkqjezd5sMyR4uDv6jROMQ7Fj21mY6aqTI1bHA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AKLNmRw0/SmMLjWf+LL6tx7jA+Cty4jeXsBltSfyWq2f8yPLdphKCN3NDf6CH77Lh xubeGc/YpGEJLFEQPoomgCxfU3hdIf2sXi9pn+eN6Fm06No8TT1X6PzCVxBeIIkQKh D3wuBSYp9RT9pGEZsI/t3POtxx1pDYW7UnWNDEQew8lM024tMt1CKZLqxwWdCUP9ub Q7EVqGZ6UyETBDNPtkkwLaBhVmUOhJ9W56axmGbD3C6FP1IEYYzMjBVH8ZyIkfPaWo L9lmL/0r+QQJ96h83+71s/Jj2rzfYtjFGfW6kiRJDtiaW3Ge3ykLrWBtW39JzRNODc mvAxNcQL6leAw== Date: Fri, 29 Nov 2024 15:06:45 +0100 From: Maxime Ripard To: Geert Uytterhoeven Cc: Nathan Chancellor , Arnd Bergmann , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Andy Yan , Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Algea Cao , Cristian Ciocaltea , Arnd Bergmann , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: avoid 64-bit division Message-ID: <20241129-mottled-satisfied-dormouse-7caf27@houat> References: <20241018151016.3496613-1-arnd@kernel.org> <20241104172950.GA741087@thelio-3990X> <20241122-rebel-donkey-of-atheism-a0b8b6@houat> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="7i2k3qplgecpqbs7" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241129_060648_735486_5435FB9D X-CRM114-Status: GOOD ( 33.38 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --7i2k3qplgecpqbs7 Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH] drm/rockchip: avoid 64-bit division MIME-Version: 1.0 On Mon, Nov 25, 2024 at 11:35:58AM +0100, Geert Uytterhoeven wrote: > Hi Maxime, >=20 > On Fri, Nov 22, 2024 at 10:15=E2=80=AFAM Maxime Ripard wrote: > > On Fri, Nov 22, 2024 at 09:36:16AM +0100, Geert Uytterhoeven wrote: > > > On Mon, Nov 4, 2024 at 6:30=E2=80=AFPM Nathan Chancellor wrote: > > > > On Fri, Oct 18, 2024 at 03:10:10PM +0000, Arnd Bergmann wrote: > > > > > From: Arnd Bergmann > > > > > > > > > > Dividing a 64-bit integer prevents building this for 32-bit targe= ts: > > > > > > > > > > ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rock= chipdrm.ko] undefined! > > > > > > > > > > As this function is not performance criticial, just Use the div_u= 64() helper. > > > > > > > > > > Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output = support") > > > > > Signed-off-by: Arnd Bergmann > > > > > > > > Reviewed-by: Nathan Chancellor > > > > > > > > Can someone please pick this up? It is still broken in next-2024110= 4... > > > > > > > > https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-inte= gration2/builds/2oNvJFRj8tkDieb6VfrMf4rh1Kn/build.log > > > > > > > > > --- > > > > > drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c b/dri= vers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > > > > > index 9c796ee4c303..c8b362cc2b95 100644 > > > > > --- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > > > > > +++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c > > > > > @@ -82,7 +82,7 @@ static void dw_hdmi_qp_rockchip_encoder_enable(= struct drm_encoder *encoder) > > > > > * comment in rk_hdptx_phy_power_on() from > > > > > * drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c > > > > > */ > > > > > - phy_set_bus_width(hdmi->phy, rate / 100); > > > > > + phy_set_bus_width(hdmi->phy, div_u64(rate, 100)); > > > > > } > > > > > } > > > > > > noreply@ellerman.id.au has just told me this build issue is now upstr= eam: > > > > > > FAILED linus/m68k-allmodconfig/m68k-gcc8.1 Fri Nov 22, 05:34 > > > http://kisskb.ellerman.id.au/kisskb/buildresult/15277242/ > > > > > > Commit: Merge tag 'drm-next-2024-11-21' of > > > https://gitlab.freedesktop.org/drm/kernel > > > 28eb75e178d389d325f1666e422bc13bbbb9804c > > > Compiler: m68k-linux-gcc (GCC) 8.1.0 / GNU ld (GNU Binutils) 2.30 > > > > > > ERROR: modpost: "__udivdi3" > > > [drivers/gpu/drm/rockchip/rockchipdrm.ko] undefined! > > > > > > Applying this patch fixes it, so > > > Acked-by: Geert Uytterhoeven > > > > > > Do we really need +5 weeks to apply a fix for a reported build issue? > > > > Do we really need that kind of comments? > > > > It was applied already, I made sure it's part of the next PR we send to > > Linus. And it should be in linux-next tomorrow. >=20 > Thank you, I can confirm it is now commit 818956c76517e127 > ("drm/rockchip: avoid 64-bit division") in drm-misc/for-linux-next > and next-20241125. >=20 > Interestingly, the commit description contains: >=20 > (cherry picked from commit 4b64b4a81fcd51f570c046cf904aef19ec756d45) >=20 > which is not in any tree on git.kernel.org, but the github collective > does know about it: > https://github.com/torvalds/linux/commit/4b64b4a81fcd51f570c046cf904aef19= ec756d45 The commit is in drm-misc-next, which will land in 6.14. > Probably you want to drop that line. We don't rebase anyway :/ Maxime --7i2k3qplgecpqbs7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCZ0nKdAAKCRAnX84Zoj2+ dikEAYDvsIQwG9bew2mXnojYuIclQccLNeCFpo3HINAJB6xIl9WdMYU4OfeC95n2 u/XxOu4Bf0YtqfO3bC542YUr94xAXt80D93ZW1hfv0QIXyOCiVmf7WvGrzYqIYOT VzevyU2hMg== =f5Cd -----END PGP SIGNATURE----- --7i2k3qplgecpqbs7--