From: Marc Zyngier <maz@kernel.org>
To: iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev,
linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org
Cc: "Joerg Roedel" <joro@8bytes.org>,
"Suravee Suthikulpanit" <suravee.suthikulpanit@amd.com>,
"David Woodhouse" <dwmw2@infradead.org>,
"Lu Baolu" <baolu.lu@linux.intel.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"WANG Xuerui" <kernel@xen0n.name>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Anup Patel" <anup@brainfault.org>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Toan Le" <toan@os.amperecomputing.com>,
"Alyssa Rosenzweig" <alyssa@rosenzweig.io>
Subject: [PATCH 02/11] genirq/msi: Add helper for creating MSI-parent irq domains
Date: Wed, 4 Dec 2024 12:45:40 +0000 [thread overview]
Message-ID: <20241204124549.607054-3-maz@kernel.org> (raw)
In-Reply-To: <20241204124549.607054-1-maz@kernel.org>
Creating an irq domain that serves as an MSI parent requires
a substantial amount of esoteric boiler-plate code, some of
which is often provided twice (such as the bus token).
To make things a bit simpler for the unsuspecting MSI tinkerer,
provide a helper that does it for them, and serves as documentation
of what needs to be provided.
Signed-off-by: Marc Zyngier <maz@kernel.org>
---
include/linux/msi.h | 7 +++++++
kernel/irq/msi.c | 40 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 47 insertions(+)
diff --git a/include/linux/msi.h b/include/linux/msi.h
index b10093c4d00ea..f08d14cf07103 100644
--- a/include/linux/msi.h
+++ b/include/linux/msi.h
@@ -594,6 +594,13 @@ struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
struct msi_domain_info *info,
struct irq_domain *parent);
+struct irq_domain *msi_create_parent_irq_domain(struct fwnode_handle *fwnode,
+ const struct msi_parent_ops *msi_parent_ops,
+ const struct irq_domain_ops *ops,
+ unsigned long flags, unsigned long size,
+ void *host_data,
+ struct irq_domain *parent);
+
bool msi_create_device_irq_domain(struct device *dev, unsigned int domid,
const struct msi_domain_template *template,
unsigned int hwsize, void *domain_data,
diff --git a/kernel/irq/msi.c b/kernel/irq/msi.c
index 396a067a8a56b..037d85cf0b21c 100644
--- a/kernel/irq/msi.c
+++ b/kernel/irq/msi.c
@@ -885,6 +885,46 @@ struct irq_domain *msi_create_irq_domain(struct fwnode_handle *fwnode,
return __msi_create_irq_domain(fwnode, info, 0, parent);
}
+/**
+ * msi_create_parent_irq_domain - Create an MSI-parent interrupt domain
+ * @fwnode: Optional fwnode of the interrupt controller
+ * @msi_parent_ops: MSI parent callbacks and configuration
+ * @ops: Interrupt domain ballbacks
+ * @flags: Interrupt domain flags
+ * @size: Interrupt domain size (0 if arbitrarily large)
+ * @host_data: Interrupt domain private data
+ * @parent: Parent irq domain
+ *
+ * Return: pointer to the created &struct irq_domain or %NULL on failure
+ */
+struct irq_domain *msi_create_parent_irq_domain(struct fwnode_handle *fwnode,
+ const struct msi_parent_ops *msi_parent_ops,
+ const struct irq_domain_ops *ops,
+ unsigned long flags, unsigned long size,
+ void *host_data,
+ struct irq_domain *parent)
+{
+ struct irq_domain_info info = {
+ .fwnode = fwnode,
+ .size = size,
+ .hwirq_max = size,
+ .ops = ops,
+ .host_data = host_data,
+ .domain_flags = flags | IRQ_DOMAIN_FLAG_MSI_PARENT,
+ .parent = parent,
+ .bus_token = msi_parent_ops->bus_select_token,
+ };
+ struct irq_domain *d;
+
+ d = irq_domain_instantiate(&info);
+ if (IS_ERR(d))
+ return NULL;
+
+ d->msi_parent_ops = msi_parent_ops;
+ return d;
+}
+EXPORT_SYMBOL_GPL(msi_create_parent_irq_domain);
+
/**
* msi_parent_init_dev_msi_info - Delegate initialization of device MSI info down
* in the domain hierarchy
--
2.39.2
next prev parent reply other threads:[~2024-12-04 12:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 12:45 [PATCH 00/11] irqchip: MSI parent cleanup and PCI host driver conversion Marc Zyngier
2024-12-04 12:45 ` [PATCH 01/11] irqchip: Make irq-msi-lib.h globally available Marc Zyngier
2024-12-04 12:45 ` Marc Zyngier [this message]
2024-12-04 13:57 ` [PATCH 02/11] genirq/msi: Add helper for creating MSI-parent irq domains Thomas Gleixner
2024-12-04 12:45 ` [PATCH 03/11] irqchip/gic: Convert to msi_create_parent_irq_domain() helper Marc Zyngier
2024-12-04 12:45 ` [PATCH 04/11] irqchip/mvebu: " Marc Zyngier
2024-12-04 12:45 ` [PATCH 05/11] irqchip/riscv-imsic: " Marc Zyngier
2024-12-04 12:45 ` [PATCH 06/11] irqchip/imx-mu-msi: " Marc Zyngier
2024-12-04 22:58 ` Frank Li
2024-12-04 12:45 ` [PATCH 07/11] irqchip/loongson-pch-msi: " Marc Zyngier
2024-12-04 12:45 ` [PATCH 08/11] iommu/amd: " Marc Zyngier
2024-12-04 12:45 ` [PATCH 09/11] iommu/intel: " Marc Zyngier
2024-12-04 12:45 ` [PATCH 10/11] PCI: apple: Convert to MSI parent infrastructure Marc Zyngier
2024-12-04 12:45 ` [PATCH 11/11] PCI: xgene: " Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204124549.607054-3-maz@kernel.org \
--to=maz@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=andrew@lunn.ch \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=iommu@lists.linux.dev \
--cc=jiaxun.yang@flygoat.com \
--cc=joro@8bytes.org \
--cc=kernel@xen0n.name \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=loongarch@lists.linux.dev \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=s.hauer@pengutronix.de \
--cc=sebastian.hesselbarth@gmail.com \
--cc=shawnguo@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=tglx@linutronix.de \
--cc=toan@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).