From: Jason Gunthorpe <jgg@nvidia.com>
To: Will Deacon <will@kernel.org>
Cc: iommu@lists.linux.dev, Joerg Roedel <joro@8bytes.org>,
linux-arm-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
patches@lists.linux.dev
Subject: Re: [PATCH 3/3] iommu/arm-smmu-v3: Remove domain_alloc_paging()
Date: Mon, 9 Dec 2024 19:21:57 -0400 [thread overview]
Message-ID: <20241209232157.GE2347147@nvidia.com> (raw)
In-Reply-To: <20241209230611.GA13790@willie-the-truck>
On Mon, Dec 09, 2024 at 11:06:12PM +0000, Will Deacon wrote:
> On Thu, Dec 05, 2024 at 11:43:29AM -0400, Jason Gunthorpe wrote:
> > arm_smmu_domain_alloc_paging_flags() with a flags = 0 now does the same
> > thing as arm_smmu_domain_alloc_paging(), remove
> > arm_smmu_domain_alloc_paging().
> >
> > Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
> > ---
> > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 31 ---------------------
> > 1 file changed, 31 deletions(-)
>
> Ha! I was reviewing the previous patch and about to reply asking why we
> couldn't just implement arm_smmu_domain_alloc_paging() as a wrapper
> around arm_smmu_domain_alloc_paging() with flags of 0.
>
> Good thing I read ahead :)
Yes, the main point of the prior patch was to make this patch
possible :)
Jason
next prev parent reply other threads:[~2024-12-09 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-05 15:43 [PATCH 0/3] iommu/arm-smmuv3: Update domain_alloc_paging_flags() Jason Gunthorpe
2024-12-05 15:43 ` [PATCH 1/3] iommu/arm-smmu-v3: Remove arm_smmu_domain_finalise() during attach Jason Gunthorpe
2024-12-05 15:43 ` [PATCH 2/3] iommu/arm-smmu-v3: Make domain_alloc_paging_flags() directly determine the S1/S2 Jason Gunthorpe
2024-12-05 15:43 ` [PATCH 3/3] iommu/arm-smmu-v3: Remove domain_alloc_paging() Jason Gunthorpe
2024-12-09 23:06 ` Will Deacon
2024-12-09 23:21 ` Jason Gunthorpe [this message]
2024-12-10 0:17 ` [PATCH 0/3] iommu/arm-smmuv3: Update domain_alloc_paging_flags() Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209232157.GE2347147@nvidia.com \
--to=jgg@nvidia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=patches@lists.linux.dev \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).