From: Rob Herring <robh@kernel.org>
To: Liu Ying <victor.liu@nxp.com>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
p.zabel@pengutronix.de, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, krzk+dt@kernel.org, conor+dt@kernel.org,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, tglx@linutronix.de,
vkoul@kernel.org, kishon@kernel.org, aisheng.dong@nxp.com,
agx@sigxcpu.org, francesco@dolcini.it, frank.li@nxp.com,
dmitry.baryshkov@linaro.org, u.kleine-koenig@baylibre.com
Subject: Re: [PATCH v6 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units
Date: Tue, 10 Dec 2024 16:15:08 -0600 [thread overview]
Message-ID: <20241210221508.GA550635-robh@kernel.org> (raw)
In-Reply-To: <20241209033923.3009629-2-victor.liu@nxp.com>
On Mon, Dec 09, 2024 at 11:39:05AM +0800, Liu Ying wrote:
> Freescale i.MX8qxp Display Controller is implemented as construction set of
> building blocks with unified concept and standardized interfaces. Document
> all existing processing units.
>
> Signed-off-by: Liu Ying <victor.liu@nxp.com>
> ---
> v6:
> * No change.
>
> v5:
> * Document aliases for processing units which have multiple instances in
> the Display Controller. Drop Rob's previous R-b tag. (Maxime)
>
> v4:
> * Collect Rob's R-b tag.
>
> v3:
> * Combine fsl,imx8qxp-dc-fetchunit-common.yaml,
> fsl,imx8qxp-dc-fetchlayer.yaml and fsl,imx8qxp-dc-fetchwarp.yaml
> into 1 schema doc fsl,imx8qxp-dc-fetchunit.yaml. (Rob)
> * Document all processing units. (Rob)
>
> v2:
> * Drop fsl,dc-*-id DT properties. (Krzysztof)
> * Add port property to fsl,imx8qxp-dc-tcon.yaml. (Krzysztof)
> * Fix register range sizes in examples.
>
> .../display/imx/fsl,imx8qxp-dc-blitblend.yaml | 46 ++++++
> .../display/imx/fsl,imx8qxp-dc-clut.yaml | 49 ++++++
> .../imx/fsl,imx8qxp-dc-constframe.yaml | 49 ++++++
> .../display/imx/fsl,imx8qxp-dc-dither.yaml | 49 ++++++
> .../display/imx/fsl,imx8qxp-dc-extdst.yaml | 77 +++++++++
> .../display/imx/fsl,imx8qxp-dc-fetchunit.yaml | 147 ++++++++++++++++++
> .../display/imx/fsl,imx8qxp-dc-filter.yaml | 47 ++++++
> .../display/imx/fsl,imx8qxp-dc-framegen.yaml | 68 ++++++++
> .../display/imx/fsl,imx8qxp-dc-gammacor.yaml | 38 +++++
> .../imx/fsl,imx8qxp-dc-layerblend.yaml | 45 ++++++
> .../display/imx/fsl,imx8qxp-dc-matrix.yaml | 48 ++++++
> .../display/imx/fsl,imx8qxp-dc-rop.yaml | 48 ++++++
> .../display/imx/fsl,imx8qxp-dc-safety.yaml | 34 ++++
> .../imx/fsl,imx8qxp-dc-scaling-engine.yaml | 89 +++++++++++
> .../display/imx/fsl,imx8qxp-dc-signature.yaml | 58 +++++++
> .../display/imx/fsl,imx8qxp-dc-store.yaml | 100 ++++++++++++
> .../display/imx/fsl,imx8qxp-dc-tcon.yaml | 50 ++++++
> 17 files changed, 1042 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-blitblend.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-clut.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-constframe.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-dither.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-extdst.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-fetchunit.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-filter.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-framegen.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-gammacor.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-layerblend.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-matrix.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-rop.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-safety.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-scaling-engine.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-signature.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-store.yaml
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-tcon.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-blitblend.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-blitblend.yaml
> new file mode 100644
> index 000000000000..7f800e72c3f3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8qxp-dc-blitblend.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/imx/fsl,imx8qxp-dc-blitblend.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8qxp Display Controller Blit Blend Unit
> +
> +description: |
> + Combines two input frames to a single output frame, all frames having the
> + same dimension.
> +
> + Each Blit Blend Unit device should have an alias in the aliases node, in the
> + form of dc<x>-blitblend<y>, where <x> is an integer specifying the Display
> + Controller instance and <y> is an integer specifying the Blit Blend Unit
> + device instance.
That's really an abuse of aliases. If you need to describe connections
between components, use the graph binding like everyone else does for
display path components.
Rob
next prev parent reply other threads:[~2024-12-10 22:16 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 3:39 [PATCH v6 00/19] Add Freescale i.MX8qxp Display Controller support Liu Ying
2024-12-09 3:39 ` [PATCH v6 01/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller processing units Liu Ying
2024-12-10 22:15 ` Rob Herring [this message]
2024-12-11 3:05 ` Liu Ying
2024-12-11 14:55 ` Rob Herring
2024-12-13 3:40 ` Liu Ying
2024-12-09 3:39 ` [PATCH v6 02/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller blit engine Liu Ying
2024-12-09 3:39 ` [PATCH v6 03/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-12-09 3:39 ` [PATCH v6 04/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-12-09 3:39 ` [PATCH v6 05/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller AXI performance counter Liu Ying
2024-12-09 3:39 ` [PATCH v6 06/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller command sequencer Liu Ying
2024-12-09 3:39 ` [PATCH v6 07/19] dt-bindings: interrupt-controller: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-12-09 3:39 ` [PATCH v6 08/19] dt-bindings: display: imx: Add i.MX8qxp Display Controller Liu Ying
2024-12-09 3:39 ` [PATCH v6 09/19] drm/imx: Add i.MX8qxp Display Controller display engine Liu Ying
2024-12-12 8:02 ` Maxime Ripard
2024-12-09 3:39 ` [PATCH v6 10/19] drm/imx: Add i.MX8qxp Display Controller pixel engine Liu Ying
2024-12-12 8:02 ` Maxime Ripard
2024-12-09 3:39 ` [PATCH v6 11/19] drm/imx: Add i.MX8qxp Display Controller interrupt controller Liu Ying
2024-12-12 8:02 ` Maxime Ripard
2024-12-09 3:39 ` [PATCH v6 12/19] drm/imx: Add i.MX8qxp Display Controller KMS Liu Ying
2024-12-09 16:17 ` Dmitry Baryshkov
2024-12-11 7:43 ` Liu Ying
2024-12-11 23:35 ` Dmitry Baryshkov
2024-12-13 6:07 ` Liu Ying
2024-12-13 13:28 ` Dmitry Baryshkov
2024-12-16 6:29 ` Liu Ying
2024-12-16 9:44 ` Dmitry Baryshkov
2024-12-12 8:02 ` Maxime Ripard
2024-12-09 3:39 ` [PATCH v6 13/19] MAINTAINERS: Add maintainer for i.MX8qxp Display Controller Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 14/19] dt-bindings: phy: mixel, mipi-dsi-phy: Allow assigned-clock* properties Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 15/19] dt-bindings: firmware: imx: Add SCU controlled display pixel link nodes Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 16/19] arm64: dts: imx8qxp: Add display controller subsystem Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 17/19] arm64: dts: imx8qxp: Add MIPI-LVDS combo subsystems Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 18/19] arm64: dts: imx8qxp-mek: Enable display controller Liu Ying
2024-12-09 3:39 ` [DO NOT MERGE PATCH v6 19/19] arm64: dts: imx8qxp-mek: Add MX8-DLVDS-LCD1 display module support Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210221508.GA550635-robh@kernel.org \
--to=robh@kernel.org \
--cc=agx@sigxcpu.org \
--cc=airlied@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=francesco@dolcini.it \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=simona@ffwll.ch \
--cc=tglx@linutronix.de \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=victor.liu@nxp.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).