Re: [PATCH 1/2] dt-bindings: arm: sunxi: document RerVision A33-Vstar board

Icenowy Zheng
2024-09-14T01:57:32Z

在 2024-09-13星期五的 09:24 -0500，Rob Herring (Arm)写道：
>
> On Fri, 13 Sep 2024 18:48:44 +0800, Icenowy Zheng wrote:
> > RerVision A33-Vstar is an evaluation board of their A33-Core1 SoM.
> >
> > Add its compatible (with the SoM compatible) to the sunxi board DT
> > binding file.
> >
> > Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
> > ---
> >  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
>
>
> My bot found new DTB warnings on the .dts files added or changed in
> this
> series.
>
> Some warnings may be from an existing SoC .dtsi. Or perhaps the
> warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to
> reply
> unless the platform maintainer has comments.
>
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
>
>   pip3 install dtschema --upgrade
>
>
> New warnings running 'make CHECK_DTBS=y allwinner/sun8i-a33-
> vstar.dtb' for 20240913104845.4112986-1-uwu@icenowy.me:
>
> arch/arm/boot/dts/allwinner/sun8i-a33-vstar.dtb: hub@1: '#address-
> cells', '#size-cells', 'ethernet@4' do not match any of the regexes:
> 'pinctrl-[0-9]+'
>         from schema $id:
> http://devicetree.org/schemas/usb/genesys,gl850g.yaml#

I think I need help to properly reference usb-device.yaml to allow
cells properties. Currently it's in a allOf: section of
genesys,gl850g.yaml along with Genesys-specific per-compatible rules
(USB2/USB3 hubs), but it looks that this fails to work.

I copied the patternProperties rule from usb-hcd.yaml to allow
downstream devices, this works well.

BTW should a usb-hub.yaml be present to allow different hub bindings to
share the code for downstream devices?

>
>
>
>
>