From: Will Deacon <will@kernel.org>
To: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: julien.thierry.kdev@gmail.com, kvm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
maz@kernel.org, oliver.upton@linux.dev, apatel@ventanamicro.com,
andre.przywara@arm.com, suzuki.poulose@arm.com,
s.abdollahi22@imperial.ac.uk
Subject: Re: [PATCH RESEND kvmtool 0/4] arm: Payload memory layout change
Date: Wed, 11 Dec 2024 22:59:32 +0000 [thread overview]
Message-ID: <20241211225931.GC17836@willie-the-truck> (raw)
In-Reply-To: <20241128151246.10858-1-alexandru.elisei@arm.com>
On Thu, Nov 28, 2024 at 03:12:42PM +0000, Alexandru Elisei wrote:
> (resending because I accidently only sent the cover letter, sorry for that)
>
> The first 3 patches are fixes to kvm__arch_load_kernel_image(). I've CC'ed
> the riscv maintainer because it looks to me like riscv is similarly
> affected.
>
> Patch #4 ("arm64: Increase the payload memory region size to 512MB") might
> be controversial. Follows a bug report I received from Abdollahi Sina in
> private. Details in the commit message, but the gist of the patch is that
> the memory region where kernel + initrd + DTB are copied to are changed
> from 256MB to 512MB. As a result, the DTB and initrd are moved from below
> ram_start + 256MB to ram_start + 512MB to accomodate a larger initrd. If
> users rely on finding the DTB and initrd at the current addresses, then I'm
> not sure the patch is justified - after all, if someone really wants to use
> such a large initrd instead of a disk image with virtio, then replacing
> SZ_256M with SZ_512M locally doesn't look like a big ask.
>
> On the other hand, if there are no users that rely on the current payload
> layout, increasing the memory region size to 512MB to allow for more
> unusual use cases, while still maintaining compatibility with older
> kernels, doesn't seem unreasonable to me.
>
> Please comment, I don't feel strongly either way - I'll happy drop the last
> patch if there are objections.
Well, I won't reject an imperial.ac.uk patch on a hunch, so let's go for
the whole lot and see if anybody complains!
I'll fix the indentation issue spotted by Drew when applying (thanks!).
Will
next prev parent reply other threads:[~2024-12-12 0:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 15:12 [PATCH RESEND kvmtool 0/4] arm: Payload memory layout change Alexandru Elisei
2024-11-28 15:12 ` [PATCH kvmtool 1/4] arm: Fix off-by-one errors when computing payload memory layout Alexandru Elisei
2024-11-28 15:12 ` [PATCH kvmtool 2/4] arm: Check return value for host_to_guest_flat() Alexandru Elisei
2024-11-28 16:06 ` Andrew Jones
2024-11-28 15:12 ` [PATCH kvmtool 3/4] arm64: Use the kernel header image_size when loading into memory Alexandru Elisei
2024-11-28 15:12 ` [RFC PATCH kvmtool 4/4] arm64: Increase the payload memory region size to 512MB Alexandru Elisei
2024-12-11 22:59 ` Will Deacon [this message]
2024-12-11 23:44 ` [PATCH RESEND kvmtool 0/4] arm: Payload memory layout change Will Deacon
2024-12-12 9:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241211225931.GC17836@willie-the-truck \
--to=will@kernel.org \
--cc=alexandru.elisei@arm.com \
--cc=andre.przywara@arm.com \
--cc=apatel@ventanamicro.com \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=maz@kernel.org \
--cc=oliver.upton@linux.dev \
--cc=s.abdollahi22@imperial.ac.uk \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox