* [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property
@ 2024-12-17 3:28 David Heidelberg
2024-12-17 6:53 ` Kieran Bingham
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: David Heidelberg @ 2024-12-17 3:28 UTC (permalink / raw)
To: Kieran Bingham, Umang Jain, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam
Cc: David Heidelberg, linux-media, devicetree, imx, linux-arm-kernel,
linux-kernel
Use the reg property instead of text in the description.
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../devicetree/bindings/media/i2c/sony,imx283.yaml | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
index e4f49f1435a5..f4ee991c89a3 100644
--- ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
+++ ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
@@ -13,16 +13,15 @@ maintainers:
description:
IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active
- array size of 5472H x 3648V. It is programmable through I2C interface. The
- I2C client address is fixed to 0x1a as per sensor data sheet. Image data is
- sent through MIPI CSI-2.
+ array size of 5472H x 3648V. It is programmable through I2C interface.
+ Image data is sent through MIPI CSI-2.
properties:
compatible:
const: sony,imx283
reg:
- maxItems: 1
+ const: 0x1a
clocks:
description: Clock frequency from 6 to 24 MHz.
--
2.45.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property
2024-12-17 3:28 [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property David Heidelberg
@ 2024-12-17 6:53 ` Kieran Bingham
2024-12-17 7:41 ` Krzysztof Kozlowski
2024-12-17 18:25 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Kieran Bingham @ 2024-12-17 6:53 UTC (permalink / raw)
To: Conor Dooley, David Heidelberg, Fabio Estevam,
Krzysztof Kozlowski, Mauro Carvalho Chehab,
Pengutronix Kernel Team, Rob Herring, Sascha Hauer, Shawn Guo,
Umang Jain
Cc: David Heidelberg, linux-media, devicetree, imx, linux-arm-kernel,
linux-kernel
Quoting David Heidelberg (2024-12-17 03:28:17)
> Use the reg property instead of text in the description.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> ---
> .../devicetree/bindings/media/i2c/sony,imx283.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> index e4f49f1435a5..f4ee991c89a3 100644
> --- ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> +++ ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
> @@ -13,16 +13,15 @@ maintainers:
>
> description:
> IMX283 sensor is a Sony CMOS active pixel digital image sensor with an active
> - array size of 5472H x 3648V. It is programmable through I2C interface. The
> - I2C client address is fixed to 0x1a as per sensor data sheet. Image data is
> - sent through MIPI CSI-2.
> + array size of 5472H x 3648V. It is programmable through I2C interface.
> + Image data is sent through MIPI CSI-2.
>
> properties:
> compatible:
> const: sony,imx283
>
> reg:
> - maxItems: 1
> + const: 0x1a
>
> clocks:
> description: Clock frequency from 6 to 24 MHz.
> --
> 2.45.2
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property
2024-12-17 3:28 [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property David Heidelberg
2024-12-17 6:53 ` Kieran Bingham
@ 2024-12-17 7:41 ` Krzysztof Kozlowski
2024-12-17 18:25 ` Conor Dooley
2 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2024-12-17 7:41 UTC (permalink / raw)
To: David Heidelberg
Cc: Kieran Bingham, Umang Jain, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-media, devicetree,
imx, linux-arm-kernel, linux-kernel
On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> Use the reg property instead of text in the description.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/media/i2c/sony,imx283.yaml | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx283.yaml
Same problems.
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property
2024-12-17 3:28 [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property David Heidelberg
2024-12-17 6:53 ` Kieran Bingham
2024-12-17 7:41 ` Krzysztof Kozlowski
@ 2024-12-17 18:25 ` Conor Dooley
2024-12-17 18:27 ` Conor Dooley
2 siblings, 1 reply; 5+ messages in thread
From: Conor Dooley @ 2024-12-17 18:25 UTC (permalink / raw)
To: David Heidelberg
Cc: Kieran Bingham, Umang Jain, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-media, devicetree,
imx, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> Use the reg property instead of text in the description.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property
2024-12-17 18:25 ` Conor Dooley
@ 2024-12-17 18:27 ` Conor Dooley
0 siblings, 0 replies; 5+ messages in thread
From: Conor Dooley @ 2024-12-17 18:27 UTC (permalink / raw)
To: David Heidelberg
Cc: Kieran Bingham, Umang Jain, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Shawn Guo, Sascha Hauer,
Pengutronix Kernel Team, Fabio Estevam, linux-media, devicetree,
imx, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 438 bytes --]
On Tue, Dec 17, 2024 at 06:25:47PM +0000, Conor Dooley wrote:
> On Mon, Dec 16, 2024 at 10:28:17PM -0500, David Heidelberg wrote:
> > Use the reg property instead of text in the description.
> >
> > Signed-off-by: David Heidelberg <david@ixit.cz>
>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
Heh, I was super confused as to why I couldn't find this in patchwork
but then realised Krzk had already acked it, d'oh.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-17 18:28 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-17 3:28 [PATCH] dt-bindings: media: imx283: Describe sensor address using the reg property David Heidelberg
2024-12-17 6:53 ` Kieran Bingham
2024-12-17 7:41 ` Krzysztof Kozlowski
2024-12-17 18:25 ` Conor Dooley
2024-12-17 18:27 ` Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox