Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>,
	Oliver Upton <oliver.upton@linux.dev>,
	Joey Gouly <joey.gouly@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Shuah Khan <shuah@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v3 2/9] arm64/sysreg: Update ID_AA64ISAR3_EL1 to DDI0601 2024-09
Date: Thu, 19 Dec 2024 15:55:48 +0000	[thread overview]
Message-ID: <20241219155547.GC24724@willie-the-truck> (raw)
In-Reply-To: <248dea18-bfad-4ec9-9a7d-5c87c7f48c84@sirena.org.uk>

On Thu, Dec 12, 2024 at 11:33:05AM +0000, Mark Brown wrote:
> On Wed, Dec 11, 2024 at 10:40:15PM +0000, Will Deacon wrote:
> > On Tue, Dec 10, 2024 at 06:43:05PM +0000, Mark Brown wrote:
> 
> > > Yes, the issues here are not technical ones.  Though there are some
> > > complications -  eg, IIRC the XML doesn't encode the signedness of
> > > fields like we do and there's areas where we've deliberately diverged.
> > > Given the amount of review I end up having to do of sysreg changes your
> > > reasoning is especially apparent to me.  I've passed this feedback on
> > > (again).
> 
> > One thing we _could_ do is have a tool (in-tree) that takes two copies
> > of the sysreg file (i.e. before and after applying a diff) along with a
> > copy of the XML and, for the the new fields being added, shows how the
> > XML represents those compared to the diff. It should then be relatively
> > straightforward to flag the use of an unallocated encoding (like we had
> > here) and also things like assigning a field name to a RES0 region.
> 
> > So this wouldn't be generating the patches from the XML, but more like
> > using the XML as an oracle in a linter.
> 
> That'd be useful, yes - unfortunately I think that's still something I
> can't work on myself at the moment for the above mentioned non-technical
> reasons.

Is anybody able to work on it? Without insight into the "non-technical
reasons", I don't know what I'm supposed to do other than write the tool
myself (which means finding some spare cycles...) or refusing to take
wholesale sysreg definitions until it's been ironed out :/

Will


  reply	other threads:[~2024-12-19 15:57 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 12:39 [PATCH v3 0/9] arm64: Support 2024 dpISA extensions Mark Brown
2024-12-03 12:39 ` [PATCH v3 1/9] arm64/sysreg: Update ID_AA64PFR2_EL1 to DDI0601 2024-09 Mark Brown
2024-12-03 12:39 ` [PATCH v3 2/9] arm64/sysreg: Update ID_AA64ISAR3_EL1 " Mark Brown
2024-12-10 17:09   ` Will Deacon
2024-12-10 18:43     ` Mark Brown
2024-12-11 22:40       ` Will Deacon
2024-12-12 11:33         ` Mark Brown
2024-12-19 15:55           ` Will Deacon [this message]
2024-12-19 16:39             ` Mark Brown
2024-12-19 16:49               ` Mark Brown
2024-12-19 16:57                 ` Will Deacon
2024-12-03 12:39 ` [PATCH v3 3/9] arm64/sysreg: Update ID_AA64FPFR0_EL1 " Mark Brown
2024-12-03 12:39 ` [PATCH v3 4/9] arm64/sysreg: Update ID_AA64ZFR0_EL1 " Mark Brown
2024-12-03 12:39 ` [PATCH v3 5/9] arm64/sysreg: Update ID_AA64SMFR0_EL1 " Mark Brown
2024-12-03 12:39 ` [PATCH v3 6/9] arm64/sysreg: Update ID_AA64ISAR2_EL1 " Mark Brown
2024-12-03 12:39 ` [PATCH v3 7/9] arm64/hwcap: Describe 2024 dpISA extensions to userspace Mark Brown
2024-12-03 12:39 ` [PATCH v3 8/9] KVM: arm64: Allow control of dpISA extensions in ID_AA64ISAR3_EL1 Mark Brown
2024-12-03 12:39 ` [PATCH v3 9/9] kselftest/arm64: Add 2024 dpISA extensions to hwcap test Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241219155547.GC24724@willie-the-truck \
    --to=will@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=oliver.upton@linux.dev \
    --cc=shuah@kernel.org \
    --cc=suzuki.poulose@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox