From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29302E7718F for ; Mon, 30 Dec 2024 20:10:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=A5/gaYh7Da/SEUPUwaPV8oGptQpWk6OzkKScJuHrN78=; b=xWyGMKqlOXP5gmijP6Kd+BQfpL 3QMwHnBBglmCK1LD+V2bXa4eYgy8JX+vJMjjO0BYgvRsX5V8c5XaJO6ecOlMEBecL0dzxvesQQh4v PBvuAKyWdNtfUmEA1sg6PNKp5DRXGpILX8uFtFmucWYfHqOT24E2azxiAK1O18XPB7ODfHxLKRXut jl9njNYTwKpoVK3MGYO7lKEDc50EUKdQZc0ELt3Ob5zeKStGn5v2QSSuhvrgpaheR9nEK+grJsVGt XwGc2oW10nt3MxiNk2ZvtENhQ1kQLE6YqGg8ymKjsYxS/zTusQyZb3BuFS3ntO0LEdLgIs2i2A9Zy mngaHDrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tSM5J-00000005msC-3E83; Mon, 30 Dec 2024 20:09:53 +0000 Received: from nyc.source.kernel.org ([147.75.193.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tSM49-00000005mmI-0355; Mon, 30 Dec 2024 20:08:42 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 8223BA40EC4; Mon, 30 Dec 2024 20:06:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B9E8C4CED0; Mon, 30 Dec 2024 20:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735589319; bh=iF55zMP9L3C3aKSEuO3ZPhsPTgILQXLSOfQH2gO0RfQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WnO3JblXuVzBQChHdlG4g7jmRArjY2JM6usCAqyNa1KByG1JIBxjqdBN8eF2Dvozb Ee6a6dJCXB7rnwBOiu99+O/E3Ufp+7ZGjq9r5T8cN7y/QG1lYpsl3IGOg7DemD8o3v ppdWgUoIKv2EPGKEQojkuRuYzlnRc/dz/ZZNYvzruk+A1vf1EmgHybyOLAx9SmvrAW uvAFc4irQxqTB1qfvDIOyPLdhsD4jbLRR8HVnItGpRGY3xIHSYAP8zWjza62puhSqV AepduyBmGTEuOgkbw1LQXgzTJ1f6Ov3rbWOcX+dYCV7DKYDA4SahJVNuwZO0F9OibI XKkRKxxePqT2g== Date: Mon, 30 Dec 2024 14:08:37 -0600 From: Rob Herring To: Michael Riesch Cc: Mehdi Djait , Maxime Chevallier , =?iso-8859-1?Q?Th=E9o?= Lebrun , Thomas Petazzoni , Laurent Pinchart , Mauro Carvalho Chehab , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Kever Yang , Nicolas Dufresne , Sebastian Fricke , Alexander Shiyan , Val Packett , Philipp Zabel , Sakari Ailus , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH v2 3/6] media: dt-bindings: media: add bindings for rockchip rk3568 vicap Message-ID: <20241230200837.GA2477354-robh@kernel.org> References: <20241217-v6-8-topic-rk3568-vicap-v2-0-b1d488fcc0d3@wolfvision.net> <20241217-v6-8-topic-rk3568-vicap-v2-3-b1d488fcc0d3@wolfvision.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241217-v6-8-topic-rk3568-vicap-v2-3-b1d488fcc0d3@wolfvision.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241230_120841_194102_C51DE48D X-CRM114-Status: GOOD ( 20.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 17, 2024 at 04:55:15PM +0100, Michael Riesch wrote: > Add documentation for the Rockchip RK3568 Video Capture (VICAP) unit. > > Signed-off-by: Michael Riesch > --- > .../bindings/media/rockchip,rk3568-vicap.yaml | 168 +++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 169 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > new file mode 100644 > index 000000000000..ef7b14ca6879 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > @@ -0,0 +1,168 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/rockchip,rk3568-vicap.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Rockchip RK3568 Video Capture (VICAP) > + > +maintainers: > + - Michael Riesch > + > +description: > + The Rockchip RK3568 Video Capture (VICAP) block features a digital video > + port (DVP, a parallel video interface) and a MIPI CSI-2 port. It receives > + the data from camera sensors, video decoders, or other companion ICs and > + transfers it into system main memory by AXI bus. > + > +properties: > + compatible: > + const: rockchip,rk3568-vicap > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + clocks: > + items: > + - description: ACLK > + - description: HCLK > + - description: DCLK > + - description: ICLK > + > + clock-names: > + items: > + - const: aclk > + - const: hclk > + - const: dclk > + - const: iclk > + > + rockchip,cif-clk-delaynum: > + $ref: /schemas/types.yaml#/definitions/uint32 > + minimum: 0 > + maximum: 127 > + description: > + Delay the DVP path clock input to align the sampling phase, only valid > + in dual edge sampling mode. > + > + iommus: > + maxItems: 1 > + > + resets: > + items: > + - description: ARST > + - description: HRST > + - description: DRST > + - description: PRST > + - description: IRST > + > + reset-names: > + items: > + - const: arst > + - const: hrst > + - const: drst > + - const: prst > + - const: irst > + > + rockchip,grf: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + Phandle to general register file used for video input block control. > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: input port on the parallel interface What about the CSI-2 interface? > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + bus-type: > + enum: [5, 6] > + > + required: > + - bus-type > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + #include > + #include > + > + parent { > + #address-cells = <2>; > + #size-cells = <2>; > + > + vicap: video-capture@fdfe0000 { > + compatible = "rockchip,rk3568-vicap"; > + reg = <0x0 0xfdfe0000 0x0 0x200>; > + interrupts = ; > + assigned-clocks = <&cru DCLK_VICAP>; > + assigned-clock-rates = <300000000>; > + clocks = <&cru ACLK_VICAP>, <&cru HCLK_VICAP>, > + <&cru DCLK_VICAP>, <&cru ICLK_VICAP_G>; > + clock-names = "aclk", "hclk", "dclk", "iclk"; > + iommus = <&vicap_mmu>; > + power-domains = <&power RK3568_PD_VI>; > + resets = <&cru SRST_A_VICAP>, <&cru SRST_H_VICAP>, > + <&cru SRST_D_VICAP>, <&cru SRST_P_VICAP>, > + <&cru SRST_I_VICAP>; > + reset-names = "arst", "hrst", "drst", "prst", "irst"; > + rockchip,grf = <&grf>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + vicap_dvp: port@0 { > + reg = <0>; > + > + vicap_dvp_input: endpoint { > + bus-type = ; > + bus-width = <16>; > + pclk-sample = ; > + remote-endpoint = <&it6801_output>; > + }; > + }; > + > + vicap_mipi: port@1 { > + reg = <1>; > + }; > + }; > + }; > + > + vicap_mmu: iommu@fdfe0800 { > + compatible = "rockchip,rk3568-iommu"; Not part of this binding, so drop this node. > + reg = <0x0 0xfdfe0800 0x0 0x100>; > + interrupts = ; > + clocks = <&cru ACLK_VICAP>, <&cru HCLK_VICAP>; > + clock-names = "aclk", "iface"; > + #iommu-cells = <0>; > + power-domains = <&power RK3568_PD_VI>; > + rockchip,disable-mmu-reset; > + }; > + }; > +... > diff --git a/MAINTAINERS b/MAINTAINERS > index 1138c8858bc7..8dbeb2927a08 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -20223,6 +20223,7 @@ M: Michael Riesch > L: linux-media@vger.kernel.org > S: Maintained > F: Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml > +F: Documentation/devicetree/bindings/media/rockchip,rk3568-vicap.yaml > > ROCKCHIP CRYPTO DRIVERS > M: Corentin Labbe > > -- > 2.34.1 >