Re: [PATCH 1/3] ASoC: dt-bindings: sun4i-a10-codec: add hp-det-gpios

[Rob Herring <robh@kernel.org>]

On Sun, Dec 22, 2024 at 10:51:24AM -0600, Chris Morgan wrote:
> On Sat, Dec 21, 2024 at 10:26:32PM +1300, Ryan Walklin wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Devices integrating Allwinner SoCs may use line-out or headphone jacks
> > with jack detection circuits attached to a GPIO. Support defining these
> > in DTs.
> > 
> > A number of Anbernic devices featuring the H700 SoC use this mechanism
> > to switch between a headphone jack and an internal speaker, so add these
> > to the allowed routing items.
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > Signed-off-by: Ryan Walklin <ryan@testtoast.com>
> > ---
> >  .../bindings/sound/allwinner,sun4i-a10-codec.yaml           | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> > index ebc9097f936ad..b4b711e80b65a 100644
> > --- a/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> > +++ b/Documentation/devicetree/bindings/sound/allwinner,sun4i-a10-codec.yaml
> > @@ -98,6 +98,10 @@ properties:
> >      maxItems: 1
> >      description: GPIO to enable the external amplifier
> >  
> > +  allwinner,hp-det-gpios:
> > +    maxItems: 1
> > +    description: GPIO for headphone/line-out detection
> > +
> 
> If possible, I wonder if we can keep this without the vendor prefix?
> It looks like for now Nvidia and some Rockchip codecs have the vendor
> prefix, but audio-graph bindings and Freescale codec bindings have this
> as a non-specific property (and it looks like simple-audio-card does it
> either as "hp-det-gpios" or "simple-audio-card,hp-det-gpios" depending
> upon the circumstances).

Yes, drop the vendor prefix.

Rob