Re: [RFC 4/7] dt-bindings: arm: rockchip: Add Xunlong Orange Pi 5 Ultra

[Rob Herring <robh@kernel.org>]

On Sun, Dec 29, 2024 at 12:41:31PM -0600, Jimmy Hon wrote:
> Add devicetree binding for the Xunlong Orange Pi 5 Ultra board.

Why RFC? Looks fine to me.

However, you should have 'v4' on every patch in the series if this is 
v4.

> 
> The Orange Pi 5 Ultra is a single board computer powered by the Rockchip
> RK3588 with similar board layout as the 5 Max but with the HDMI0 swapped
> for HDMI IN.
> 
> Signed-off-by: Jimmy Hon <honyuenkwun@gmail.com>
> ---
>  Documentation/devicetree/bindings/arm/rockchip.yaml | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 2a141d99c533..9dd424265826 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -1075,11 +1075,12 @@ properties:
>            - const: xunlong,orangepi-3b
>            - const: rockchip,rk3566
>  
> -      - description: Xunlong Orange Pi 5 Max/Plus
> +      - description: Xunlong Orange Pi 5 Max/Plus/Ultra
>          items:
>            - enum:
>                - xunlong,orangepi-5-max
>                - xunlong,orangepi-5-plus
> +              - xunlong,orangepi-5-ultra
>            - const: rockchip,rk3588
>  
>        - description: Xunlong Orange Pi R1 Plus / LTS
> -- 
> 2.47.1
>