From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51EF5E77188 for ; Tue, 14 Jan 2025 10:37:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZvAUIm9DRjIEkTFmQhH7cHAGvYQ3AX9FmJcB/mgkw5k=; b=45atv+3Jid7dGkUpsSnXXIO/+9 HXUdG/tnyYweTuEs4bAy7MiyM9YdKDnP4JufAZkHbzua26ACKaK+waNQET8hpZPutFeu7qJz/3K4j GUnpMA118UvmYvjwRBwLr0XVeNvltBn67D7g6I7+FIXDbrFeVyKf7CRrvS2vWpm53EOoyxQTqj1tZ yviBLI4g14ATbkNyw/03gFWVQte0ZhnEq7Wtf26Q8tApfFM8bVHbssmXhmaif5nsDbFRZj6bOINWJ s49VZz4eMFYanE04p0RJH4rGp9psXuOqWcSgbsegScmGHxb/nZ26SfbDKdDfBXw9xK1K3cILgzBPV 6MiHAbNg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tXeIZ-000000087cb-3pas; Tue, 14 Jan 2025 10:37:27 +0000 Received: from nyc.source.kernel.org ([2604:1380:45d1:ec00::3]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tXeFK-000000086z5-02JQ; Tue, 14 Jan 2025 10:34:07 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 9EE47A40C72; Tue, 14 Jan 2025 10:32:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 310DFC4CEE0; Tue, 14 Jan 2025 10:33:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1736850844; bh=PPBTXcmZ9FTKLOavDTSaaCxS+I83L8XKDLxpo1k4qF8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxTH1TVOByRyemy5vzP15NHxHuJlYlyl1hQLGDalk4R7LH2WyA/2gx/XtNbKHP6IE BdijOVzI31N04UC33BwkWxuWMPpjOqJk4YPBcZWpHmsEzVSlAn6n8H3SvPSKjRt4Km MmpAYcYGmR2n+9td9dyxGX+GBgzUR73o9ZemtBsDbfqnix+wupk/YAt26zv5Z/Nt2Q YW8X2WGphjiIh5L1lDgafPSMz5AIFm6Q1aPh8ln+BKEZNUtlb11WMWugcnXi6M0GO3 AVtW7Uph3adO04TefpnPeJyGrUuc2ovvVgVBTVrDhbVONzJzNVIc1qvOPiQR3KVK67 Hr4Mh5R5VIq3w== Date: Tue, 14 Jan 2025 10:33:53 +0000 From: Conor Dooley To: Thomas =?iso-8859-1?Q?Wei=DFschuh?= Cc: "James E.J. Bottomley" , Helge Deller , Andy Lutomirski , Thomas Gleixner , Vincenzo Frascino , Anna-Maria Behnsen , Frederic Weisbecker , Andrew Morton , Catalin Marinas , Will Deacon , Theodore Ts'o , "Jason A. Donenfeld" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Huacai Chen , WANG Xuerui , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Thomas Bogendoerfer , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Arnd Bergmann , Guo Ren , linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-riscv@lists.infradead.org, loongarch@lists.linux.dev, linux-s390@vger.kernel.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-arch@vger.kernel.org, Nam Cao , linux-csky@vger.kernel.org Subject: Re: [PATCH v2 09/18] riscv: vdso: Switch to generic storage implementation Message-ID: <20250114-lustily-nuttiness-3bb7646515d5@spud> References: <20250110-vdso-store-rng-v2-0-350c9179bbf1@linutronix.de> <20250110-vdso-store-rng-v2-9-350c9179bbf1@linutronix.de> <20250113-kissable-monstrous-aace0cf7182e@spud> <20250114093609-6cb25835-f912-4f64-9ba7-54c67d4e2904@linutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jwGvJ1ZaVXfjr5LT" Content-Disposition: inline In-Reply-To: <20250114093609-6cb25835-f912-4f64-9ba7-54c67d4e2904@linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250114_023406_166428_92EF0A18 X-CRM114-Status: GOOD ( 17.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --jwGvJ1ZaVXfjr5LT Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jan 14, 2025 at 09:40:11AM +0100, Thomas Wei=DFschuh wrote: > On Mon, Jan 13, 2025 at 07:48:15PM +0000, Conor Dooley wrote: > > On Fri, Jan 10, 2025 at 04:23:48PM +0100, Thomas Wei=DFschuh wrote: > > > The generic storage implementation provides the same features as the > > > custom one. However it can be shared between architectures, making > > > maintenance easier. > > >=20 > > > Co-developed-by: Nam Cao > > > Signed-off-by: Nam Cao > > > Signed-off-by: Thomas Wei=DFschuh > >=20 > > For rv64, nommu: > > LD vmlinux > > ld.lld: error: undefined symbol: vmf_insert_pfn > > >>> referenced by datastore.c > > >>> lib/vdso/datastore.o:(vvar_fault) in archive vmlinux.a > >=20 > > ld.lld: error: undefined symbol: _install_special_mapping > > >>> referenced by datastore.c > > >>> lib/vdso/datastore.o:(vdso_install_vvar_mapping) in a= rchive vmlinux.a > >=20 > > Later patches in the series don't make it build again. > > rv32 builds now though, so thanks for fixing that. >=20 > Thanks for the report. > Can you try to diff below? Ye, that resolved it. Thanks! --jwGvJ1ZaVXfjr5LT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ4Y9kQAKCRB4tDGHoIJi 0oHDAP9Da+NrCNJE56DtkPFciL+LH3SKSSwOWQ6oFB2bu8GWRQEA9RJt/Is3QV+w +n+t05VKvIADKDk9hc4FHnNawF8GUgg= =tDst -----END PGP SIGNATURE----- --jwGvJ1ZaVXfjr5LT--