From: Christian Marangi <ansuelsmth@gmail.com>
To: Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wenbin Mei <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, upstream@airoha.com
Cc: Christian Marangi <ansuelsmth@gmail.com>
Subject: [PATCH 1/2] dt-bindings: mmc: mtk-sd: Add eMMC for AN7581
Date: Wed, 15 Jan 2025 08:29:50 +0100 [thread overview]
Message-ID: <20250115073026.31552-1-ansuelsmth@gmail.com> (raw)
Document eMMC compatible for AN7581. This eMMC controller doesn't have
regulator exposed to the system and have a single clock only for source
clock and only default pintctrl.
Rework the schema to permit these new requirements and make supply
optional only for airoha,an7581-mmc compatible.
Also provide an example for airoha,an7581-mmc.
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
This depends on patch merged in clk-next
bfe257f9780d8f77045a7da6ec959ee0659d2f98
.../devicetree/bindings/mmc/mtk-sd.yaml | 64 +++++++++++++++++--
1 file changed, 58 insertions(+), 6 deletions(-)
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
index f86ebd81f5a5..6dad5455b369 100644
--- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
+++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
@@ -27,6 +27,7 @@ properties:
- mediatek,mt8183-mmc
- mediatek,mt8196-mmc
- mediatek,mt8516-mmc
+ - airoha,an7581-mmc
- items:
- const: mediatek,mt7623-mmc
- const: mediatek,mt2701-mmc
@@ -48,11 +49,11 @@ properties:
clocks:
description:
Should contain phandle for the clock feeding the MMC controller.
- minItems: 2
+ minItems: 1
maxItems: 7
clock-names:
- minItems: 2
+ minItems: 1
maxItems: 7
interrupts:
@@ -72,7 +73,7 @@ properties:
Should at least contain default and state_uhs. To support SDIO in-band wakeup, dat1 pin
will be switched between GPIO mode and SDIO DAT1 mode, state_eint is mandatory in this
scenario.
- minItems: 2
+ minItems: 1
items:
- const: default
- const: state_uhs
@@ -170,9 +171,6 @@ required:
- clock-names
- pinctrl-names
- pinctrl-0
- - pinctrl-1
- - vmmc-supply
- - vqmmc-supply
allOf:
- $ref: mmc-controller.yaml#
@@ -335,6 +333,40 @@ allOf:
- const: axi_cg
- const: ahb_cg
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: airoha,an7581-mmc
+ then:
+ properties:
+ clocks:
+ items:
+ - description: source clock
+
+ clock-names:
+ items:
+ - const: source
+
+ pinctrl-names:
+ items:
+ - const: default
+ else:
+ properties:
+ clocks:
+ minItems: 2
+
+ clock-names:
+ minItems: 2
+
+ pinctrl-names:
+ minItems: 2
+
+ required:
+ - pinctrl-1
+ - vmmc-supply
+ - vqmmc-supply
+
unevaluatedProperties: false
examples:
@@ -389,5 +421,25 @@ examples:
vqmmc-supply = <&mt6397_vgp3_reg>;
mmc-pwrseq = <&wifi_pwrseq>;
};
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/clock/en7523-clk.h>
+ mmc@1fa0e000 {
+ compatible = "airoha,an7581-mmc";
+ reg = <0x1fa0e000 0x1000>,
+ <0x1fa0c000 0x60>;
+ clocks = <&scuclk EN7581_CLK_EMMC>;
+ clock-names = "source";
+ interrupts = <GIC_SPI 170 IRQ_TYPE_LEVEL_HIGH>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&mmc_pins>;
+ bus-width = <4>;
+ max-frequency = <52000000>;
+ disable-wp;
+ cap-mmc-highspeed;
+ non-removable;
+
+ };
...
--
2.45.2
next reply other threads:[~2025-01-15 7:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-15 7:29 Christian Marangi [this message]
2025-01-15 7:29 ` [PATCH 2/2] mmc: mtk-sd: add support for AN7581 MMC Host Christian Marangi
2025-01-15 9:33 ` Wenbin Mei (梅文彬)
2025-01-15 9:35 ` Christian Marangi
2025-01-16 7:01 ` Andy-ld Lu (卢东)
2025-01-20 17:29 ` Christian Marangi
2025-01-21 6:25 ` Andy-ld Lu (卢东)
2025-01-22 9:32 ` Christian Marangi
2025-01-23 1:42 ` Andy-ld Lu (卢东)
2025-01-27 11:41 ` Christian Marangi
2025-01-15 8:37 ` [PATCH 1/2] dt-bindings: mmc: mtk-sd: Add eMMC for AN7581 Rob Herring (Arm)
2025-01-15 8:39 ` Christian Marangi
2025-01-15 8:48 ` Krzysztof Kozlowski
2025-01-15 8:51 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250115073026.31552-1-ansuelsmth@gmail.com \
--to=ansuelsmth@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chaotian.jing@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=upstream@airoha.com \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).