From: Yenchia Chen <yenchia.chen@mediatek.com>
To: <jirislaby@kernel.org>
Cc: <angelogioacchino.delregno@collabora.com>,
<gregkh@linuxfoundation.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>,
<linux-serial@vger.kernel.org>, <matthias.bgg@gmail.com>,
<tbergstrom@nvidia.com>, <treapking@chromium.org>,
<u.kleine-koenig@baylibre.com>, <yenchia.chen@mediatek.com>,
<yj.chiang@mediatek.com>, <yujiaoliang@vivo.com>
Subject: Re: [PATCH] serial: 8250_mtk: Add ACPI support
Date: Thu, 16 Jan 2025 11:53:38 +0800 [thread overview]
Message-ID: <20250116035340.3838407-1-yenchia.chen@mediatek.com> (raw)
In-Reply-To: <ac3f0efe-c197-4279-9b73-5d7dd3f300fc@kernel.org>
> Wait, ::set_termios() is NOT optional.
Got it, will put it back in next version.
> This is a magic constant. Define a macro for this. Hint: 26 * HZ_PER_MHZ.
> Is it not/cannot it be part of the acpi table? What does MTKI0511 look like?
Currently clock settings are not included in ACPI table, so using fixed clock here.
We'd like to change the flow as shown below to remove the dependency on the ACPI device:
uart.port.set_termios = mtk8250_set_termios;
uart.port.uartclk = clk_get_rate(data->uart_clk);
+ if (!uart.port.uartclk)
+ uart.port.uartclk = 26 * HZ_PER_MZ;
> Why is this only for non-ACPI devices?
In ACPI devices, these registers are inaccessible due to some related settings not being configured.
next prev parent reply other threads:[~2025-01-16 3:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-14 3:33 [PATCH] serial: 8250_mtk: Add ACPI support Yenchia Chen
2025-01-14 7:31 ` Jiri Slaby
2025-01-14 7:35 ` Jiri Slaby
2025-01-16 3:53 ` Yenchia Chen [this message]
2025-01-15 19:45 ` kernel test robot
2025-01-16 12:16 ` Jonathan Cameron
2025-01-15 20:48 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116035340.3838407-1-yenchia.chen@mediatek.com \
--to=yenchia.chen@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=tbergstrom@nvidia.com \
--cc=treapking@chromium.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=yj.chiang@mediatek.com \
--cc=yujiaoliang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).