From: Sean Anderson <sean.anderson@linux.dev>
To: Mark Brown <broonie@kernel.org>,
Michal Simek <michal.simek@amd.com>,
linux-spi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Jinjie Ruan <ruanjinjie@huawei.com>,
linux-arm-kernel@lists.infradead.org,
Amit Kumar Mahapatra <amit.kumar-mahapatra@amd.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Sean Anderson <sean.anderson@linux.dev>
Subject: [PATCH 4/5] spi: zynqmp-gqspi: Allow interrupting operations
Date: Thu, 16 Jan 2025 17:55:20 -0500 [thread overview]
Message-ID: <20250116225521.2688224-5-sean.anderson@linux.dev> (raw)
In-Reply-To: <20250116225521.2688224-1-sean.anderson@linux.dev>
Some operations (such as reading several megabytes of data from a flash)
can take several seconds or more. Users may want to cancel such
operations. Allow them to do so now that we have a way to recover.
Signed-off-by: Sean Anderson <sean.anderson@linux.dev>
---
drivers/spi/spi-zynqmp-gqspi.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c
index cf47466ec982..fa4bff73324e 100644
--- a/drivers/spi/spi-zynqmp-gqspi.c
+++ b/drivers/spi/spi-zynqmp-gqspi.c
@@ -1062,14 +1062,24 @@ static int zynqmp_qspi_wait(struct zynqmp_qspi *xqspi, unsigned long timeout)
{
int ret;
- ret = wait_for_completion_timeout(&xqspi->data_completion, timeout);
- if (ret)
+ /* Only allow interrupting if we can reset the device */
+ if (xqspi->reset)
+ ret = wait_for_completion_interruptible_timeout(&xqspi->data_completion,
+ timeout);
+ else
+ ret = wait_for_completion_timeout(&xqspi->data_completion,
+ timeout);
+ if (ret > 0)
return 0;
- dev_err(xqspi->dev, "Operation timed out\n");
+
+ if (!ret) {
+ dev_err(xqspi->dev, "Operation timed out\n");
+ ret = -ETIMEDOUT;
+ }
/* Attempt to recover as best we can */
zynqmp_qspi_init_hw(xqspi);
- return -ETIMEDOUT;
+ return ret;
}
/**
--
2.35.1.1320.gc452695387.dirty
next prev parent reply other threads:[~2025-01-16 23:02 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 22:55 [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting Sean Anderson
2025-01-16 22:55 ` [PATCH 1/5] dt-bindings: spi: zynqmp-qspi: Add reset Sean Anderson
2025-01-17 7:14 ` Michal Simek
2025-01-17 16:12 ` Sean Anderson
2025-01-23 22:45 ` Rob Herring
2025-01-23 22:57 ` Sean Anderson
2025-01-24 9:06 ` Michal Simek
2025-01-27 17:57 ` Rob Herring
2025-01-27 18:00 ` Sean Anderson
2025-01-16 22:55 ` [PATCH 2/5] spi: zynqmp-gqspi: Reset device in probe Sean Anderson
2025-01-16 22:55 ` [PATCH 3/5] spi: zynqmp-gqspi: Abort operations on timeout Sean Anderson
2025-01-17 7:15 ` Michal Simek
2025-01-16 22:55 ` Sean Anderson [this message]
2025-01-17 8:41 ` [PATCH 4/5] spi: zynqmp-gqspi: Allow interrupting operations Miquel Raynal
2025-01-17 16:12 ` Sean Anderson
2025-01-16 22:55 ` [PATCH 5/5] ARM64: xilinx: zynqmp: Add QSPI reset Sean Anderson
2025-01-17 13:21 ` [PATCH 0/5] spi: zynqmp-gqspi: Improve error recovery by resetting Mark Brown
2025-01-17 16:17 ` Sean Anderson
2025-01-17 16:48 ` Mark Brown
2025-01-17 16:50 ` Sean Anderson
2025-01-17 18:31 ` Miquel Raynal
2025-01-17 18:41 ` Mark Brown
2025-01-17 21:46 ` Sean Anderson
2025-01-20 13:49 ` Mark Brown
2025-01-21 16:51 ` Sean Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250116225521.2688224-5-sean.anderson@linux.dev \
--to=sean.anderson@linux.dev \
--cc=amit.kumar-mahapatra@amd.com \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=miquel.raynal@bootlin.com \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).