From: Krzysztof Kozlowski <krzk@kernel.org>
To: Mao Jinlong <quic_jinlmao@quicinc.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
Mike Leach <mike.leach@linaro.org>,
James Clark <james.clark@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
linux-kernel@vger.kernel.org, coresight@lists.linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: Update compatible for remote etm
Date: Tue, 21 Jan 2025 09:56:24 +0100 [thread overview]
Message-ID: <20250121-prudent-cornflower-owl-261faa@krzk-bin> (raw)
In-Reply-To: <20250121063900.3211-2-quic_jinlmao@quicinc.com>
On Tue, Jan 21, 2025 at 02:38:59PM +0800, Mao Jinlong wrote:
> Use different compatible to distinguish between different remote
> etms.
Why?
Every second time for qcom. Don't say what, we see that easily.
>
> Signed-off-by: Mao Jinlong <quic_jinlmao@quicinc.com>
> ---
> .../bindings/arm/qcom,coresight-remote-etm.yaml | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> index 4fd5752978cd..199f2ca4b8a9 100644
> --- a/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom,coresight-remote-etm.yaml
> @@ -18,7 +18,14 @@ description:
>
> properties:
> compatible:
> - const: qcom,coresight-remote-etm
> + contains:
No, you are now saying this is "qcom,pink-pony" as well...
Sorry, this change is neither explained, nor correct.
> + enum:
> + - qcom,coresight-modem-etm
> + - qcom,coresight-wcn-etm
> + - qcom,coresight-adsp-etm
> + - qcom,coresight-sensor-etm
> + - qcom,coresight-modem2-etma
And how anyone can understand the difference between modem and modem2?
NAK for entire patch in this form.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-21 8:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-21 6:38 [PATCH v4 0/2] coresight: Add remote etm support Mao Jinlong
2025-01-21 6:38 ` [PATCH v4 1/2] dt-bindings: arm: Update compatible for remote etm Mao Jinlong
2025-01-21 8:56 ` Krzysztof Kozlowski [this message]
2025-01-21 6:39 ` [PATCH v4 2/2] coresight: Add remote etm support Mao Jinlong
2025-01-21 9:00 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250121-prudent-cornflower-owl-261faa@krzk-bin \
--to=krzk@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=james.clark@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.leach@linaro.org \
--cc=quic_jinlmao@quicinc.com \
--cc=robh@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox