From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Markus Schneider-Pargmann <msp@baylibre.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Siddharth Vadapalli <s-vadapalli@ti.com>,
Nishanth Menon <nm@ti.com>,
Vignesh Raghavendra <vigneshr@ti.com>,
Tero Kristo <kristo@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] arm64: dts: ti: k3-am62a-wakeup: Add ddr-pmctrl, canuart-wake
Date: Fri, 24 Jan 2025 09:20:38 +0100 [thread overview]
Message-ID: <20250124-spicy-mighty-worm-ece42c@krzk-bin> (raw)
In-Reply-To: <20250122-topic-am62-dt-syscon-v6-13-v1-4-515d56edc35e@baylibre.com>
On Wed, Jan 22, 2025 at 11:24:35AM +0100, Markus Schneider-Pargmann wrote:
> Within the wkup-conf register range there are ddr-pmctrl and
> canuart-wake control registers. Add dedicated subnodes for these.
>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> index 0b1dd5390cd3f42b0ec56bab042388722b4c22a1..a9bcda212c99d2f7669100ca29459eb13172da3e 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62a-wakeup.dtsi
> @@ -36,6 +36,16 @@ usb1_phy_ctrl: syscon@4018 {
> compatible = "ti,am62-usb-phy-ctrl", "syscon";
> reg = <0x4018 0x4>;
> };
> +
> + ddr_pmctrl: syscon@80d0 {
> + compatible = "ti,am62-ddr-pmctrl", "syscon";
> + reg = <0x80d0 0x4>;
No, why do you export single registers? Entire device is syscon, not
single register.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-24 8:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 10:24 [PATCH 0/5] arm64: dts: ti: k3-am62a/p: Add ddr-pmctrl, canuart-wake Markus Schneider-Pargmann
2025-01-22 10:24 ` [PATCH 1/5] dt-bindings: mfd: syscon: Add ti,j784s4-acspcie-proxy-ctrl to second list Markus Schneider-Pargmann
2025-01-22 10:34 ` Siddharth Vadapalli
2025-01-22 10:24 ` [PATCH 2/5] dt-bindings: mfd: syscon: Add ti,am62-ddr-pmctrl Markus Schneider-Pargmann
2025-01-24 8:19 ` Krzysztof Kozlowski
2025-01-24 8:22 ` Krzysztof Kozlowski
2025-01-24 16:05 ` Markus Schneider-Pargmann
2025-01-24 16:48 ` Krzysztof Kozlowski
2025-01-24 22:35 ` Andrew Davis
2025-01-27 12:09 ` Krzysztof Kozlowski
2025-02-07 14:40 ` Markus Schneider-Pargmann
2025-02-09 12:21 ` Krzysztof Kozlowski
2025-02-10 10:35 ` Markus Schneider-Pargmann
2025-02-12 19:35 ` Krzysztof Kozlowski
2025-04-09 17:39 ` Andrew Davis
2025-04-15 5:17 ` Krzysztof Kozlowski
2025-04-21 17:03 ` Andrew Davis
2025-04-22 16:12 ` David Lechner
2025-04-22 16:45 ` Andrew Davis
2025-04-23 12:07 ` Krzysztof Kozlowski
2025-04-23 14:30 ` Andrew Davis
2025-01-22 10:24 ` [PATCH 3/5] dt-bindings: mfd: syscon: Add ti,am62-canuart-wake compatible Markus Schneider-Pargmann
2025-01-24 8:21 ` Krzysztof Kozlowski
2025-01-22 10:24 ` [PATCH 4/5] arm64: dts: ti: k3-am62a-wakeup: Add ddr-pmctrl, canuart-wake Markus Schneider-Pargmann
2025-01-24 8:20 ` Krzysztof Kozlowski [this message]
2025-01-22 10:24 ` [PATCH 5/5] arm64: dts: ti: k3-am62p-j722s-common-wakeup: " Markus Schneider-Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124-spicy-mighty-worm-ece42c@krzk-bin \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox