From: Alexander Dahl <ada@thorsis.com>
To: "Bence Csókás" <csokas.bence@prolan.hu>
Cc: Len Brown <len.brown@intel.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Tudor Ambarus <tudor.ambarus@linaro.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Alexander Dahl <ada@thorsis.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
dmaengine@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
Mark Brown <broonie@kernel.org>, Pavel Machek <pavel@ucw.cz>,
Varshini Rajendran <varshini.rajendran@microchip.com>,
linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/4] Add more devm_ functions to simplify probe path in drivers/spi/atmel-quadspi.c
Date: Fri, 24 Jan 2025 10:08:21 +0100 [thread overview]
Message-ID: <20250124-stumble-unpeeled-165f2211dcfb@thorsis.com> (raw)
In-Reply-To: <20250124085221.766303-4-csokas.bence@prolan.hu>
Hello,
Am Fri, Jan 24, 2025 at 09:52:16AM +0100 schrieb Bence Csókás:
> The probe function of the atmel-quadspi driver got quite convoluted,
> especially since the addition of SAMA7G5 support, that was forward-ported
> from an older vendor kernel. To alleivate this - and similar problems in
> the future - an effort was made to migrate as many functions as possible,
> to their devm_ managed counterparts. The few functions, which did not yet
> have a devm_ variant, are added in patch 1 and 2 of this series. Patch 3
> and 4 then use these APIs to simplify and fix the probe() function.
>
> Change in v2: rebased onto Linus' master, which is:
> commit bc8198dc7ebc ("Merge tag 'sched_ext-for-6.14' of
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext")
You can pass '--base master' or '--base=auto' to `git format-patch`
which adds a machine readable line to your patch or cover letter like
this:
base-commit: bc8198dc7ebc492ec3e9fa1617dcdfbe98e73b17
This way tools can find out which commit your series was based on.
See for reasoning:
https://people.kernel.org/monsieuricon/all-patches-must-include-base-commit-info
I'll look into your patch series in February, after my holidays.
Greets
Alex
next prev parent reply other threads:[~2025-01-24 9:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-24 8:52 [PATCH v2 0/4] Add more devm_ functions to simplify probe path in drivers/spi/atmel-quadspi.c Bence Csókás
2025-01-24 8:52 ` [PATCH v2 1/4] dma: Add devm_dma_request_chan() Bence Csókás
2025-02-03 12:27 ` Alexander Dahl
2025-02-03 13:09 ` Csókás Bence
2025-01-24 8:52 ` [PATCH v2 2/4] pm: runtime: Add new devm functions Bence Csókás
2025-01-24 8:52 ` [PATCH v2 3/4] spi: atmel-quadspi: Use `devm_dma_request_chan()` Bence Csókás
2025-01-24 8:52 ` [PATCH v2 4/4] spi: atmel-quadspi: Fix unbalanced pm_runtime by using devm_ API Bence Csókás
2025-01-24 9:08 ` Alexander Dahl [this message]
2025-01-24 10:50 ` [PATCH v2 0/4] Add more devm_ functions to simplify probe path in drivers/spi/atmel-quadspi.c Csókás Bence
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250124-stumble-unpeeled-165f2211dcfb@thorsis.com \
--to=ada@thorsis.com \
--cc=alexandre.belloni@bootlin.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@tuxon.dev \
--cc=csokas.bence@prolan.hu \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafael@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=varshini.rajendran@microchip.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox