public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: "Ivan T. Ivanov" <iivanov@suse.de>
To: Stanimir Varbanov <svarbanov@suse.de>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Florian Fainelli <florian.fainelli@broadcom.com>,
	Jim Quinlan <jim2101024@gmail.com>,
	Nicolas Saenz Julienne <nsaenz@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Lorenzo Pieralisi <lpieralisi@kernel.org>,
	kw@linux.com, Philipp Zabel <p.zabel@pengutronix.de>,
	Andrea della Porta <andrea.porta@suse.com>,
	Phil Elwell <phil@raspberrypi.com>,
	Jonathan Bell <jonathan@raspberrypi.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v5 -next 00/11] Add PCIe support for bcm2712
Date: Mon, 27 Jan 2025 13:32:51 +0200	[thread overview]
Message-ID: <20250127113251.b2tqacoalcjrtcap@localhost.localdomain> (raw)
In-Reply-To: <20250120130119.671119-1-svarbanov@suse.de>

Hi Stan,

On 01-20 15:01, Stanimir Varbanov wrote:
> 
> Here is v5 of the series which aims to add support for PCIe on bcm2712 SoC
> used by RPi5. Previous v4 can be found at [1].
> 
> Based the series on linux-next because of vc4 gpu node in bcm2712.dtsi.
> 
> v4 -> v5 changes include:
>  - Addressed comments to interrupt-controller driver. (Thomas)
>  - Fixed DTB warnings  broadcom/bcm2712-rpi-5-b.dtb.
>  - New patch in the series to fix missing of_node_put.
>  - New patch to make a softdep to a MIP MSI-X driver.
>  - Dropped the patch which adds MSI-X support in pcie-brcmstb driver,
>    and instead use DT dma-ranges to pass the needed information. (Jim)
> 
> For more detailed info check patches.
> 
> Comments are welcome!
> ~Stan
> 
> [1] https://patchwork.kernel.org/project/linux-pci/cover/20241025124515.14066-1-svarbanov@suse.de/
> 
> Stanimir Varbanov (11):
>   dt-bindings: interrupt-controller: Add bcm2712 MSI-X DT bindings
>   dt-bindings: PCI: brcmstb: Update bindings for PCIe on bcm2712
>   irqchip: Add Broadcom bcm2712 MSI-X interrupt controller
>   PCI: brcmstb: Reuse config structure
>   PCI: brcmstb: Expand inbound window size up to 64GB
>   PCI: brcmstb: Add bcm2712 support
>   PCI: brcmstb: Adjust PHY PLL setup to use a 54MHz input refclk
>   PCI: brcmstb: Adding a softdep to MIP MSI-X driver
>   PCI: brcmstb: Fix for missing of_node_put
>   arm64: dts: broadcom: bcm2712: Add PCIe DT nodes
>   arm64: dts: broadcom: bcm2712-rpi-5-b: Enable PCIe DT nodes
> 
>  .../brcm,bcm2712-msix.yaml                    |  60 ++++
>  .../bindings/pci/brcm,stb-pcie.yaml           |   6 +-
>  .../boot/dts/broadcom/bcm2712-rpi-5-b.dts     |   8 +
>  arch/arm64/boot/dts/broadcom/bcm2712.dtsi     | 147 +++++++++
>  drivers/irqchip/Kconfig                       |  16 +
>  drivers/irqchip/Makefile                      |   1 +
>  drivers/irqchip/irq-bcm2712-mip.c             | 292 ++++++++++++++++++
>  drivers/pci/controller/pcie-brcmstb.c         | 147 ++++++---
>  8 files changed, 632 insertions(+), 45 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/brcm,bcm2712-msix.yaml
>  create mode 100644 drivers/irqchip/irq-bcm2712-mip.c

Thanks! This works fine.

Tested-by: Ivan T. Ivanov <iivanov@suse.de>



  parent reply	other threads:[~2025-01-27 11:34 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-20 13:01 [PATCH v5 -next 00/11] Add PCIe support for bcm2712 Stanimir Varbanov
2025-01-20 13:01 ` [PATCH v5 -next 01/11] dt-bindings: interrupt-controller: Add bcm2712 MSI-X DT bindings Stanimir Varbanov
2025-01-21 18:28   ` Florian Fainelli
2025-01-20 13:01 ` [PATCH v5 -next 02/11] dt-bindings: PCI: brcmstb: Update bindings for PCIe on bcm2712 Stanimir Varbanov
2025-01-21 18:28   ` Florian Fainelli
2025-01-27 17:59   ` Rob Herring (Arm)
2025-01-20 13:01 ` [PATCH v5 -next 03/11] irqchip: Add Broadcom bcm2712 MSI-X interrupt controller Stanimir Varbanov
2025-01-27 18:10   ` Thomas Gleixner
2025-01-28 17:55     ` Florian Fainelli
2025-01-29 10:43       ` Stanimir Varbanov
2025-02-21 16:26         ` Krzysztof Wilczyński
2025-02-21 16:23       ` Krzysztof Wilczyński
2025-01-20 13:01 ` [PATCH v5 -next 04/11] PCI: brcmstb: Reuse config structure Stanimir Varbanov
2025-01-31 16:10   ` Jim Quinlan
2025-02-21 15:36     ` Jim Quinlan
2025-02-21 16:41       ` Krzysztof Wilczyński
2025-02-21 16:44       ` Stanimir Varbanov
2025-02-21 16:50         ` Krzysztof Wilczyński
2025-01-20 13:01 ` [PATCH v5 -next 05/11] PCI: brcmstb: Expand inbound window size up to 64GB Stanimir Varbanov
2025-01-31 16:03   ` Jim Quinlan
2025-02-12 18:00   ` Bjorn Helgaas
2025-02-21 16:18     ` Krzysztof Wilczyński
2025-01-20 13:01 ` [PATCH v5 -next 06/11] PCI: brcmstb: Add bcm2712 support Stanimir Varbanov
2025-01-31 16:05   ` Jim Quinlan
2025-02-12 18:02   ` Bjorn Helgaas
2025-02-21 16:16     ` Krzysztof Wilczyński
2025-01-20 13:01 ` [PATCH v5 -next 07/11] PCI: brcmstb: Adjust PHY PLL setup to use a 54MHz input refclk Stanimir Varbanov
2025-01-31 16:08   ` Jim Quinlan
2025-02-03 11:27     ` Stanimir Varbanov
2025-02-21 21:33   ` Bjorn Helgaas
2025-02-23  9:50     ` Stanimir Varbanov
2025-01-20 13:01 ` [PATCH v5 -next 08/11] PCI: brcmstb: Adding a softdep to MIP MSI-X driver Stanimir Varbanov
2025-01-21 18:29   ` Florian Fainelli
2025-02-21 21:40   ` Bjorn Helgaas
2025-02-23  9:58     ` Stanimir Varbanov
2025-01-20 13:01 ` [PATCH v5 -next 09/11] PCI: brcmstb: Fix for missing of_node_put Stanimir Varbanov
2025-01-21 18:32   ` Florian Fainelli
2025-01-22 16:20     ` Stanimir Varbanov
2025-01-27 16:04       ` Stanimir Varbanov
2025-01-20 13:01 ` [PATCH v5 -next 10/11] arm64: dts: broadcom: bcm2712: Add PCIe DT nodes Stanimir Varbanov
2025-01-28 21:52   ` Florian Fainelli
2025-04-23  9:13     ` Stanimir Varbanov
2025-04-23  9:16       ` Florian Fainelli
2025-01-20 13:01 ` [PATCH v5 -next 11/11] arm64: dts: broadcom: bcm2712-rpi-5-b: Enable " Stanimir Varbanov
2025-01-28 21:53   ` Florian Fainelli
2025-01-27 11:32 ` Ivan T. Ivanov [this message]
2025-02-11 13:30 ` [PATCH v5 -next 00/11] Add PCIe support for bcm2712 Stanimir Varbanov
2025-02-12 18:04   ` Bjorn Helgaas
2025-02-13  8:38     ` Stanimir Varbanov
2025-02-21 16:28 ` Krzysztof Wilczyński

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250127113251.b2tqacoalcjrtcap@localhost.localdomain \
    --to=iivanov@suse.de \
    --cc=andrea.porta@suse.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=devicetree@vger.kernel.org \
    --cc=florian.fainelli@broadcom.com \
    --cc=jim2101024@gmail.com \
    --cc=jonathan@raspberrypi.com \
    --cc=krzk+dt@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=phil@raspberrypi.com \
    --cc=robh@kernel.org \
    --cc=svarbanov@suse.de \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox