* [PATCH v2] arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588
@ 2025-01-30 5:38 Alexander Shiyan
2025-02-03 8:15 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Shiyan @ 2025-01-30 5:38 UTC (permalink / raw)
To: linux-rockchip
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Sebastian Reichel, Alexey Charkov, Cristian Ciocaltea,
Dragan Simic, devicetree, linux-arm-kernel, linux-kernel,
Alexander Shiyan, stable
The tsadc driver does not handle pinctrl "gpio" and "otpout".
Let's use the correct pinctrl names "default" and "sleep".
Additionally, Alexey Charkov's testing [1] has established that
it is necessary for pinctrl state to reference the &tsadc_shut_org
configuration rather than &tsadc_shut for the driver to function correctly.
[1] https://lkml.org/lkml/2025/1/24/966
Fixes: 32641b8ab1a5 ("arm64: dts: rockchip: add rk3588 thermal sensor")
Cc: stable@vger.kernel.org
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
Signed-off-by: Alexander Shiyan <eagle.alexander923@gmail.com>
---
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
index 8cfa30837ce7..978de506d434 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3588-base.dtsi
@@ -2668,9 +2668,9 @@ tsadc: tsadc@fec00000 {
rockchip,hw-tshut-temp = <120000>;
rockchip,hw-tshut-mode = <0>; /* tshut mode 0:CRU 1:GPIO */
rockchip,hw-tshut-polarity = <0>; /* tshut polarity 0:LOW 1:HIGH */
- pinctrl-0 = <&tsadc_gpio_func>;
- pinctrl-1 = <&tsadc_shut>;
- pinctrl-names = "gpio", "otpout";
+ pinctrl-0 = <&tsadc_shut_org>;
+ pinctrl-1 = <&tsadc_gpio_func>;
+ pinctrl-names = "default", "sleep";
#thermal-sensor-cells = <1>;
status = "disabled";
};
--
2.39.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588
2025-01-30 5:38 [PATCH v2] arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588 Alexander Shiyan
@ 2025-02-03 8:15 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-02-03 8:15 UTC (permalink / raw)
To: linux-rockchip, Alexander Shiyan
Cc: Heiko Stuebner, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Sebastian Reichel, Alexey Charkov, Cristian Ciocaltea,
Dragan Simic, devicetree, linux-arm-kernel, linux-kernel, stable
On Thu, 30 Jan 2025 08:38:49 +0300, Alexander Shiyan wrote:
> The tsadc driver does not handle pinctrl "gpio" and "otpout".
> Let's use the correct pinctrl names "default" and "sleep".
> Additionally, Alexey Charkov's testing [1] has established that
> it is necessary for pinctrl state to reference the &tsadc_shut_org
> configuration rather than &tsadc_shut for the driver to function correctly.
>
> [1] https://lkml.org/lkml/2025/1/24/966
>
> [...]
Applied, thanks!
[1/1] arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588
commit: 5c8f9a05336cf5cadbd57ad461621b386aadb762
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-03 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-30 5:38 [PATCH v2] arm64: dts: rockchip: Fix broken tsadc pinctrl names for rk3588 Alexander Shiyan
2025-02-03 8:15 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).