From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Rob Herring <robh@kernel.org>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org, Conor Dooley <conor+dt@kernel.org>,
Claudiu Beznea <claudiu.beznea@tuxon.dev>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] dt-bindings: ARM: at91: add Calao USB boards
Date: Sun, 2 Feb 2025 14:58:48 +0100 [thread overview]
Message-ID: <20250202-horned-singing-cormorant-afdc77@krzk-bin> (raw)
In-Reply-To: <20250131162713.33524-2-wsa+renesas@sang-engineering.com>
On Fri, Jan 31, 2025 at 05:27:13PM +0100, Wolfram Sang wrote:
> They have not been added so far. dtbs_check complains loudly.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 0ec29366e6c2..42469a054a60 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -23,6 +23,9 @@ properties:
> - const: atmel,at91rm9200
> - items:
> - enum:
> + - calao,usb-a9260
> + - calao,usb-a9263
> + - calao,usb-a9g20
I don't undertstand why calao,usb-a9g20 or existing olimex,sam9-l9260
can be fitted with any SoC. If that's expected, mention in commit msg.
If not, then this needs to be fixed, not grew.
> - olimex,sam9-l9260
> - enum:
> - atmel,at91sam9260
> @@ -35,6 +38,11 @@ properties:
> - atmel,at91sam9xe
> - atmel,at91sam9x60
> - const: atmel,at91sam9
Line break.
> + - items:
> + - const: calao,usb-a9g20-lpw
> + - const: calao,usb-a9g20
> + - const: atmel,at91sam9g20
> + - const: atmel,at91sam9
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-02 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 16:27 [PATCH] dt-bindings: ARM: at91: add Calao USB boards Wolfram Sang
2025-02-02 13:58 ` Krzysztof Kozlowski [this message]
2025-02-04 10:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250202-horned-singing-cormorant-afdc77@krzk-bin \
--to=krzk@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=robh@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox