From: Detlev Casanova <detlev.casanova@collabora.com>
To: linux-kernel@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jonas Karlman <jonas@kwiboo.se>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
Alexey Charkov <alchark@gmail.com>,
Cristian Ciocaltea <cristian.ciocaltea@collabora.com>,
Dragan Simic <dsimic@manjaro.org>,
Jianfeng Liu <liujianfeng1994@gmail.com>,
Niklas Cassel <cassel@kernel.org>,
FUKAUMI Naoki <naoki@radxa.com>,
Kever Yang <kever.yang@rock-chips.com>,
Detlev Casanova <detlev.casanova@collabora.com>,
Johan Jonker <jbx6244@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Algea Cao <algea.cao@rock-chips.com>,
Chen-Yu Tsai <wens@csie.org>,
Sugar Zhang <sugar.zhang@rock-chips.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, kernel@collabora.com,
Quentin Schulz <quentin.schulz@cherry.de>
Subject: [PATCH v5 0/3] Add HDMI audio on the rk3588 SoC
Date: Mon, 3 Feb 2025 12:16:30 -0500 [thread overview]
Message-ID: <20250203171925.126309-1-detlev.casanova@collabora.com> (raw)
To support HDMI audio on the rk3588 based devices, the generic HDMI
Codec framework is used in the dw-hdmi-qp DRM bridge driver.
The implementation is mainly based on the downstream driver, ported to the
generic HDMI Codec framework [1] recently merged in the master branch.
The parameters computation has been kept as is and the data stored in the
dw_hdmi_qp struct as been cleaned up.
The table for the N values has been edited to reflect N recommended values
as well as CTS recommended values.
The downstream kernel also implements a machine driver for HDMI audio but
it is doing exactly what the simple-audio-card driver does, so use that
instead in the RK3588 SoC device tree.
Based on Linus' master branch.
[1]: https://lore.kernel.org/all/20241224-drm-bridge-hdmi-connector-v10-0-dc89577cd438@linaro.org/
Changes since v4:
- Moved hdmi0_audio node the rk3588-base.dtsi
- Enable hdmi0_audio in rk3588-rock-5b.dts
Changes since v3:
- Renamed function to start with dw_hdmi_qp
Changes since v2:
- Also clear the audio infoframe
- Write AUDI_CONTENTS0 to its default value in case it gets overwritten.
- Store tmds_char_rate in the dw_hdmi_qp struct in atomic_enable
- Clear tmds_char_rate in atomic_disable and only write registers when
tmds_char_rate is not 0.
- Do not use connector_state duplicates
Changes since v1:
- Remove useless audio_mutex (was used downstream for multiple drivers access
to audio functions)
- Let hdmi_codec build and setup audio infoframes
- Only access audio registers when connector is connected
- Rebased on master branch
Detlev Casanova (2):
arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC
arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B
Sugar Zhang (1):
drm/bridge: synopsys: Add audio support for dw-hdmi-qp
arch/arm64/boot/dts/rockchip/rk3588-base.dtsi | 17 +
.../boot/dts/rockchip/rk3588-rock-5b.dts | 8 +
drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c | 497 ++++++++++++++++++
3 files changed, 522 insertions(+)
--
2.48.1
next reply other threads:[~2025-02-03 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 17:16 Detlev Casanova [this message]
2025-02-03 17:16 ` [PATCH v5 1/3] drm/bridge: synopsys: Add audio support for dw-hdmi-qp Detlev Casanova
2025-02-04 9:59 ` Quentin Schulz
2025-02-06 20:40 ` Detlev Casanova
2025-02-07 8:46 ` Quentin Schulz
2025-02-03 17:16 ` [PATCH v5 2/3] arm64: dts: rockchip: Add HDMI0 audio output for rk3588 SoC Detlev Casanova
2025-02-04 10:14 ` Quentin Schulz
2025-02-06 17:17 ` Detlev Casanova
2025-02-07 10:23 ` Heiko Stübner
2025-02-03 17:16 ` [PATCH v5 3/3] arm64: dts: rockchip: Enable HDMI0 audio output for Rock 5B Detlev Casanova
2025-02-04 10:15 ` Quentin Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250203171925.126309-1-detlev.casanova@collabora.com \
--to=detlev.casanova@collabora.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alchark@gmail.com \
--cc=algea.cao@rock-chips.com \
--cc=andrzej.hajda@intel.com \
--cc=cassel@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsimic@manjaro.org \
--cc=geert+renesas@glider.be \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=kernel@collabora.com \
--cc=kever.yang@rock-chips.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=liujianfeng1994@gmail.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=naoki@radxa.com \
--cc=neil.armstrong@linaro.org \
--cc=quentin.schulz@cherry.de \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=simona@ffwll.ch \
--cc=sugar.zhang@rock-chips.com \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).