* [PATCH] dt-bindings: rockchip: pmu: Ensure all properties are defined
@ 2025-02-03 21:30 Rob Herring (Arm)
2025-02-10 10:39 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Rob Herring (Arm) @ 2025-02-03 21:30 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Elaine Zhang
Cc: devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
Device specific schemas should not allow undefined properties which is
what 'additionalProperties: true' allows. Add the missing child nodes
and fix this constraint.
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
---
Documentation/devicetree/bindings/arm/rockchip/pmu.yaml | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml b/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml
index 932f981265cc..52016a141227 100644
--- a/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip/pmu.yaml
@@ -53,11 +53,17 @@ properties:
reg:
maxItems: 1
+ power-controller:
+ type: object
+
+ reboot-mode:
+ type: object
+
required:
- compatible
- reg
-additionalProperties: true
+additionalProperties: false
examples:
- |
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] dt-bindings: rockchip: pmu: Ensure all properties are defined
2025-02-03 21:30 [PATCH] dt-bindings: rockchip: pmu: Ensure all properties are defined Rob Herring (Arm)
@ 2025-02-10 10:39 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-02-10 10:39 UTC (permalink / raw)
To: Krzysztof Kozlowski, Conor Dooley, Elaine Zhang,
Rob Herring (Arm)
Cc: Heiko Stuebner, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On Mon, 03 Feb 2025 15:30:56 -0600, Rob Herring (Arm) wrote:
> Device specific schemas should not allow undefined properties which is
> what 'additionalProperties: true' allows. Add the missing child nodes
> and fix this constraint.
>
>
Applied, thanks!
[1/1] dt-bindings: rockchip: pmu: Ensure all properties are defined
commit: b921f66ccf5e8cf1b8a5052b35ceda454f19f5dd
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-02-10 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-02-03 21:30 [PATCH] dt-bindings: rockchip: pmu: Ensure all properties are defined Rob Herring (Arm)
2025-02-10 10:39 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).