From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 87B37C02196 for ; Tue, 4 Feb 2025 21:46:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=klzFW5qufSNhopssaHB67PSC4MM864bFLdh0AdosYTI=; b=NxwTXjYVORlkCy6gwWPLFJBE0w 9+RuOnwAPdOLece1YVPmDSQFWN7NP2oDRQFX1Cu8gdtsPTYgwR6SJ4fKcq+Wa58AaoSNCN1elb93C jtm8Od6EipoSzSpl1cFqNEu50l8t8Kn3PWF23GMoqOHAa1XdyeyL+FaarBEzmRr1GtxOJzU6QVCoj ydFeD7hvGWJxpgqGKyaubd0U0jRW+upzyEo28BdwBXt0V+gIKWKuzFTWmm0ncQBnOszowADoxFUuM ZxUu3BkWbvDPVRBPGa4jua1Bc9f9xGhTFe0wZq+H+nQVU7vPIbygIr12PS+xIEziB9FV1YeRfDRCE KnK5HXGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfQk7-00000001dOC-2UcH; Tue, 04 Feb 2025 21:46:03 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfOcb-00000001Mgo-0bww for linux-arm-kernel@lists.infradead.org; Tue, 04 Feb 2025 19:30:10 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 6BCF25C67BB; Tue, 4 Feb 2025 19:29:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46AC9C4CEE9; Tue, 4 Feb 2025 19:30:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738697407; bh=dp3KkiRbpI5jTq31jDz9RRKWBTNV3PSWERsFVIuYVUE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PJ28FiwKrc8NJPI/UEnZa67oUEmxwlDSox0/vLcuo50zurUwA2+ytfQnM6Bv4u0PK vAoehoqdy9VadUapFOhWNyKJeVT++wKSeKmI7OkjbiXd6uV4midvRdJZancpyQ/RFe iHJ9n9P7LXMc5SUQiCKC5Leqbdieg7Yh1vV1vN4UFk+3/zV2NcTwFK9e/Js+zHfCKH B4bGIZak2YsfPaoAp0ADRNr0gPsZR2oevAC0Zda/tE85Zf2fsfTN/re9Xd6/r3qCiF 7w7Rze4iYR5KCqJ4/giOPWK9lTqwVCOzrq61Sgtpt4Bcd0Y2Pb3bE41emxsTaPxzeq csBuOwM6KBsKg== Date: Tue, 4 Feb 2025 19:30:03 +0000 From: Conor Dooley To: Jammy Huang Cc: eajames@linux.ibm.com, mchehab@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dt-bindings: media: convert aspeed-video.txt to dt-schema Message-ID: <20250204-acronym-unshaved-18b89a389091@spud> References: <20250204062822.3738037-1-jammy_huang@aspeedtech.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="i8IRvi06tcsVtedw" Content-Disposition: inline In-Reply-To: <20250204062822.3738037-1-jammy_huang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_113009_270672_B910AFAC X-CRM114-Status: GOOD ( 28.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --i8IRvi06tcsVtedw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 04, 2025 at 02:28:22PM +0800, Jammy Huang wrote: > Convert aspeed-video.txt to yaml format. > Update aspeed-video.txt to aspeed,video-engine.yaml in MAINTAINER file. >=20 > Signed-off-by: Jammy Huang > --- > .../bindings/media/aspeed,video-engine.yaml | 84 +++++++++++++++++++ > .../bindings/media/aspeed-video.txt | 33 -------- > MAINTAINERS | 2 +- > 3 files changed, 85 insertions(+), 34 deletions(-) > create mode 100644 Documentation/devicetree/bindings/media/aspeed,video-= engine.yaml > delete mode 100644 Documentation/devicetree/bindings/media/aspeed-video.= txt >=20 > diff --git a/Documentation/devicetree/bindings/media/aspeed,video-engine.= yaml b/Documentation/devicetree/bindings/media/aspeed,video-engine.yaml > new file mode 100644 > index 000000000000..c66ae6b53cbb > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/aspeed,video-engine.yaml > @@ -0,0 +1,84 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/aspeed,video-engine.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: ASPEED Video Engine > + > +maintainers: > + - Eddie James > + > +description: > + The Video Engine (VE) embedded in the ASPEED SOCs can be configured to > + capture and compress video data from digital or analog sources. > + > +properties: > + compatible: > + enum: > + - aspeed,ast2400-video-engine > + - aspeed,ast2500-video-engine > + - aspeed,ast2600-video-engine > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: vclk > + - const: eclk > + > + resets: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + memory-region: > + maxItems: 1 > + description: | > + Phandle to the reserved memory nodes to be associated with the > + VE. VE will acquires memory space for 3 purposes: > + 1. JPEG header > + 2. Compressed result > + 3. Temporary transformed image data > + > + aspeed,scu: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + Specifies the scu node that is needed if video wants to capture > + from sources other than Host VGA. > + > + aspeed,gfx: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: | > + Specifies the Soc Display(gfx) node that needs to be queried to get > + related information if video wants to use gfx as capture source. These two phandle properties are new and not mentioned in your commit message. Why have they been added? > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + video@1e700000 { > + compatible =3D "aspeed,ast2600-video-engine"; > + reg =3D <0x1e700000 0x1000>; > + clocks =3D <&syscon ASPEED_CLK_GATE_VCLK>, > + <&syscon ASPEED_CLK_GATE_ECLK>; > + clock-names =3D "vclk", "eclk"; > + interrupts =3D ; > + aspeed,scu =3D <&syscon>; > + aspeed,gfx =3D <&gfx>; > + }; > diff --git a/Documentation/devicetree/bindings/media/aspeed-video.txt b/D= ocumentation/devicetree/bindings/media/aspeed-video.txt > deleted file mode 100644 > index d2ca32512272..000000000000 > --- a/Documentation/devicetree/bindings/media/aspeed-video.txt > +++ /dev/null > @@ -1,33 +0,0 @@ > -* Device tree bindings for Aspeed Video Engine > - > -The Video Engine (VE) embedded in the Aspeed AST2400/2500/2600 SOCs can > -capture and compress video data from digital or analog sources. > - > -Required properties: > - - compatible: "aspeed,ast2400-video-engine" or > - "aspeed,ast2500-video-engine" or > - "aspeed,ast2600-video-engine" > - - reg: contains the offset and length of the VE memory region > - - clocks: clock specifiers for the syscon clocks associated with > - the VE (ordering must match the clock-names property) > - - clock-names: "vclk" and "eclk" > - - resets: reset specifier for the syscon reset associated with > - the VE > - - interrupts: the interrupt associated with the VE on this platform > - > -Optional properties: > - - memory-region: > - phandle to a memory region to allocate from, as defined in > - Documentation/devicetree/bindings/reserved-memory/reserved-memory.txt > - > -Example: > - > -video-engine@1e700000 { > - compatible =3D "aspeed,ast2500-video-engine"; > - reg =3D <0x1e700000 0x20000>; > - clocks =3D <&syscon ASPEED_CLK_GATE_VCLK>, <&syscon ASPEED_CLK_GATE_= ECLK>; > - clock-names =3D "vclk", "eclk"; > - resets =3D <&syscon ASPEED_RESET_VIDEO>; > - interrupts =3D <7>; > - memory-region =3D <&video_engine_memory>; > -}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 896a307fa065..7e59daa1e89d 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -3549,7 +3549,7 @@ M: Eddie James > L: linux-media@vger.kernel.org > L: openbmc@lists.ozlabs.org (moderated for non-subscribers) > S: Maintained > -F: Documentation/devicetree/bindings/media/aspeed-video.txt > +F: Documentation/devicetree/bindings/media/aspeed,video-engine.yaml > F: drivers/media/platform/aspeed/ > =20 > ASUS EC HARDWARE MONITOR DRIVER >=20 > base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b > --=20 > 2.25.1 >=20 --i8IRvi06tcsVtedw Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ6JqugAKCRB4tDGHoIJi 0mCkAQDv+QJAtLQu581nLzkejap/mpHejKb7ON+oLm+XbsuanwD/XWZyc+D15A2m NvFwrl1iWOd3s3nRf2VSuRWBz8w31wk= =GNL1 -----END PGP SIGNATURE----- --i8IRvi06tcsVtedw--