From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64022C02194 for ; Thu, 6 Feb 2025 19:06:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=OjgJynL9P8TzsMC7BETb4fwFvURXZKJwxcO5/PJBE2s=; b=lm/3Xd31uI61IBxvWvdg5JIP7d Bv6q64xTDt0c4QPwLvknjsrTXiW01LCNzLZ6B2s8K1X+u94Uiypa+01Mv+kSXjFhajVQ6CnwZbq73 CO1OF57QkbrnijMrrRcX1W2pB6t1SeOwNlgpd6LG23DCsvKua9zLXHUyUbRdENA/LU3XHDZqkTa5v +8m7h1oAxBA1hFtks1jlsvOfZBrFl9/Xqe+uUp8t7xP3u0knsqJEvtBsvYOuWpvg5Fv0rKhdCdFUc +8Li7ZBT9psqaxMRgG85sF0p14qnWlWojSRgL50BE7xG/fn3FM6gnpHNECh0Qf+kaNFY0d8HMjQSJ h3jhfz1A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tg7D5-00000007JoN-0Vf6; Thu, 06 Feb 2025 19:06:47 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tg6a0-00000007BMc-3K2D; Thu, 06 Feb 2025 18:26:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4C3BF5C5520; Thu, 6 Feb 2025 18:25:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 37F9AC4CEDD; Thu, 6 Feb 2025 18:26:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738866383; bh=zEiLpGTnN6szvqIO03zj6Wy4GsFDV17QfFRszwprihM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NLCjgvCBU5utmTUv/A0sJ4Bl1ywl3snuOUZcQxXnbeZlEky0i3YfrYdMH/uCFxK7T duh+T0WjlAsIjICFUOImtv4h8H5a/O1GC4OFsUSEe6Fs8kOl25ivhH10br5dV2pmrl Sec5GPwylbbHAqOI11XEzRGf0rSI/Quu4pg2gSlUBpEHDCrOvIosc//bmuHT/86oV2 GqXlpyQPGmuoPZli7X/WH74lndy5JJexe2qohaFmx63Bm0JnN7PsS7Q0rQwDKvs1WI DxVIdlSYfSzj+1qZY+kz3UlHqr5rvnRXq/nYv196JIW9CiTbvTEpL7cSi9NQ4o1Mfc Q67ALrU4H2owA== Date: Thu, 6 Feb 2025 18:26:18 +0000 From: Conor Dooley To: Lorenzo Bianconi Cc: Lorenzo Bianconi , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Felix Fietkau , Sean Wang , Matthias Brugger , AngeloGioacchino Del Regno , Philipp Zabel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, upstream@airoha.com Subject: Re: [PATCH net-next 09/13] dt-bindings: net: airoha: Add airoha,npu phandle property Message-ID: <20250206-sabbath-carded-2bd52c03440d@spud> References: <20250205-airoha-en7581-flowtable-offload-v1-0-d362cfa97b01@kernel.org> <20250205-airoha-en7581-flowtable-offload-v1-9-d362cfa97b01@kernel.org> <20250205-cleaver-evaluator-648c8f0b99bb@spud> <20250205-disagree-motive-517efca2b90c@spud> <20250205-patronage-finisher-bbfbdb5b7dbc@spud> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="/oPBRXOgxxcoZEVI" Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250206_102624_923408_ED58D2DB X-CRM114-Status: GOOD ( 34.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --/oPBRXOgxxcoZEVI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 05, 2025 at 09:54:43PM +0100, Lorenzo Bianconi wrote: > > On Wed, Feb 05, 2025 at 08:01:26PM +0000, Conor Dooley wrote: > > > On Wed, Feb 05, 2025 at 08:33:13PM +0100, Lorenzo Bianconi wrote: > > > > > On Wed, Feb 05, 2025 at 07:21:28PM +0100, Lorenzo Bianconi wrote: > > > > > > Introduce the airoha,npu property for the npu syscon node avail= able on > > > > > > EN7581 SoC. The airoha Network Processor Unit (NPU) is used to = offload > > > > > > network traffic forwarded between Packet Switch Engine (PSE) po= rts. > > > > > >=20 > > > > > > Signed-off-by: Lorenzo Bianconi > > > > > > --- > > > > > > Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml |= 8 ++++++++ > > > > > > 1 file changed, 8 insertions(+) > > > > > >=20 > > > > > > diff --git a/Documentation/devicetree/bindings/net/airoha,en758= 1-eth.yaml b/Documentation/devicetree/bindings/net/airoha,en7581-eth.yaml > > > > > > index c578637c5826db4bf470a4d01ac6f3133976ae1a..6388afff64e990a= 20230b0c4e58534aa61f984da 100644 > > > > > > --- a/Documentation/devicetree/bindings/net/airoha,en7581-eth.y= aml > > > > > > +++ b/Documentation/devicetree/bindings/net/airoha,en7581-eth.y= aml > > > > > > @@ -63,6 +63,12 @@ properties: > > > > > > "#size-cells": > > > > > > const: 0 > > > > > > =20 > > > > > > + airoha,npu: > > > > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > > > > + description: > > > > > > + Phandle to the syscon node used to configure the NPU mod= ule > > > > > > + used for traffic offloading. > > > > >=20 > > > > > Why do you need a phandle for this, instead of a lookup by compat= ible? > > > > > Do you have multiple instances of this ethernet controller on the > > > > > device, that each need to look up a different npu? > > > >=20 > > > > actually not, but looking up via the compatible string has been nak= ed by > > > > Krzysztof on a different series [0]. > > >=20 > > > Hmm, I disagree with adding phandles that are not needed. I don't agr= ee > > > that there's no reuse, if you can treat the phandle identically on a = new > > > device, in all likelihood, that node should have a fallback to the > > > existing one. > >=20 > > Also, where is the binding for this npu? It looks like a brand-new > > module that you're adding a driver for in this series and a phandle to > > the node for here but I see no binding for it. >=20 > The driver loads the NPU node just as syscon so I have not added the bind= ing > for it to the series. I will add it in v2. I don't think it is "just as syscon", you've got an entire driver for it that you're loading via the phandle, it's not just some generic syscon that you're looking up here - at least that's what it seemed like to me after my scan of the driver patches. --/oPBRXOgxxcoZEVI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZ6T+ygAKCRB4tDGHoIJi 0lDVAP99szIZe8LIhGzbAEpswbE479dnuYBrXx+O1D4nO3LFswEAzPfV05o49+gc Cw7wCHXzFPQRZM3PDwkaaW819kcBPAw= =t8sA -----END PGP SIGNATURE----- --/oPBRXOgxxcoZEVI--