linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Aren Moynihan <aren@peacevolution.org>
To: Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>
Cc: "Aren Moynihan" <aren@peacevolution.org>,
	"Kaustabh Chakraborty" <kauschluss@disroot.org>,
	"Barnabás Czémán" <trabarni@gmail.com>,
	"Julien Stephan" <jstephan@baylibre.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, "Ondrej Jirman" <megi@xff.cz>,
	"Dragan Simic" <dsimic@manjaro.org>,
	phone-devel@vger.kernel.org
Subject: [PATCH v5 7/8] iio: light: stk3310: log error if reading the chip id fails
Date: Sat,  8 Feb 2025 16:13:25 -0500	[thread overview]
Message-ID: <20250208211325.992280-9-aren@peacevolution.org> (raw)
In-Reply-To: <20250208211325.992280-2-aren@peacevolution.org>

If the chip isn't powered, this call is likely to return an error.
Without a log here the driver will silently fail to probe. Potential
errors include ENXIO (when the chip isn't powered) and ETIMEDOUT (when
the i2c bus isn't powered).

This function is only called from stk3310_probe, and this condition
should return an error, which fits what dev_err_probe is designed for.

Signed-off-by: Aren Moynihan <aren@peacevolution.org>
---

Notes:
    Changes in v4:
     - get a struct device ahead of time so it can be passed as "dev"
       instead of "&client->dev"
    
    Changes in v2:
     - use dev_err_probe

 drivers/iio/light/stk3310.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c
index 9d517d51f6bae..3a06852cb0ab4 100644
--- a/drivers/iio/light/stk3310.c
+++ b/drivers/iio/light/stk3310.c
@@ -496,7 +496,7 @@ static int stk3310_init(struct iio_dev *indio_dev)
 
 	ret = regmap_read(data->regmap, STK3310_REG_ID, &chipid);
 	if (ret < 0)
-		return ret;
+		return dev_err_probe(dev, ret, "failed to read chip id\n");
 
 	ret = stk3310_check_chip_id(chipid);
 	if (ret < 0)
-- 
2.48.1



  parent reply	other threads:[~2025-02-08 21:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-08 21:13 [PATCH v5 0/8] iio: light: stk3310: support powering off during suspend Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 1/8] dt-bindings: iio: light: stk33xx: add vdd and leda regulators Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 2/8] iio: light: stk3310: handle all remove logic with devm callbacks Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 3/8] iio: light: stk3310: implement vdd and leda supplies Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 4/8] iio: light: stk3310: simplify and inline STK3310_REGFIELD macro Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 5/8] iio: light: stk3310: refactor to always make dev a variable Aren Moynihan
2025-02-08 21:13 ` [PATCH v5 6/8] iio: light: stk3310: use dev_err_probe where possible Aren Moynihan
2025-02-09 14:47   ` Andy Shevchenko
2025-02-11 19:43     ` Jonathan Cameron
2025-02-12 10:43       ` Andy Shevchenko
2025-02-15 20:16     ` Aren
2025-02-08 21:13 ` Aren Moynihan [this message]
2025-02-08 21:13 ` [PATCH v5 8/8] arm64: dts: allwinner: pinephone: add power supplies to stk3311 Aren Moynihan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250208211325.992280-9-aren@peacevolution.org \
    --to=aren@peacevolution.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dsimic@manjaro.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jic23@kernel.org \
    --cc=jstephan@baylibre.com \
    --cc=kauschluss@disroot.org \
    --cc=krzk+dt@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=megi@xff.cz \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=samuel@sholland.org \
    --cc=trabarni@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).