From: Christoph Hellwig <hch@lst.de>
To: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Cc: Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
Philipp Zabel <p.zabel@pengutronix.de>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] apple-nvme: defer cache flushes by a specified amount
Date: Thu, 13 Feb 2025 07:20:13 +0100 [thread overview]
Message-ID: <20250213062013.GC19608@lst.de> (raw)
In-Reply-To: <20250211-nvme-fixes-v1-3-6958b3aa49fe@rosenzweig.io>
On Tue, Feb 11, 2025 at 01:25:59PM -0500, Alyssa Rosenzweig wrote:
> From: Jens Axboe <axboe@kernel.dk>
>
> Cache flushes on the M1 nvme are really slow, taking 17-18 msec to
> complete. This can slow down workloads considerably, pure random writes
> end up being bound by the flush latency and hence run at 55-60 IOPS.
>
> Add a deferred flush work around to provide better performance, at a
> minimal risk. By default, flushes are delayed at most 1 second, but this
> is configurable.
>
> With this work-around, a pure random write workload runs at ~12K IOPS
> rather than 56 IOPS.
Just as last time this really is not a driver feature. Cache flushes
are slow on consumer hardware, it's just apple is worse than usual.
Breaking file system transactional guarantee by ignoring data integrity
command in the driver is a no-go.
If we want to allow an opt-in policy for those whole feel adventurous,
it belongs into the core flush state machine. Fortunately the patch
author seems qualified to touch that :)
next prev parent reply other threads:[~2025-02-13 6:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-11 18:25 [PATCH 0/3] apple-nvme: bug and perf fixes Alyssa Rosenzweig
2025-02-11 18:25 ` [PATCH 1/3] apple-nvme: Support coprocessors left idle Alyssa Rosenzweig
2025-02-11 18:25 ` [PATCH 2/3] apple-nvme: Release power domains when probe fails Alyssa Rosenzweig
2025-02-11 18:25 ` [PATCH 3/3] apple-nvme: defer cache flushes by a specified amount Alyssa Rosenzweig
2025-02-11 19:50 ` Jens Axboe
2025-02-13 6:20 ` Christoph Hellwig [this message]
2025-02-13 16:09 ` Alyssa Rosenzweig
2025-02-11 18:38 ` [PATCH 0/3] apple-nvme: bug and perf fixes Keith Busch
2025-02-12 15:41 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250213062013.GC19608@lst.de \
--to=hch@lst.de \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=marcan@marcan.st \
--cc=p.zabel@pengutronix.de \
--cc=sagi@grimberg.me \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).