Re: [PATCH] arm64: rust: clean Rust 1.85.0 warning using softfloat target

[Gary Guo <gary@garyguo.net>]

On Thu, 13 Feb 2025 16:46:22 +0100
Ralf Jung <post@ralfj.de> wrote:

> Hi all,
> 
> > We have to carefully make the distinction here between codegen and ABI.
> > 
> > The arm64 C code in the kernel is built with -mgeneral-regs-only
> > because FP/SIMD registers are not preserved/restored like GPRs, and so
> > they must be used only in carefully controlled circumstances, i.e., in
> > assembler code called under kernel_neon_begin()/kernel_neon_end()
> > [modulo some exceptions related to NEON intrinsics]
> > 
> > This does not impact the ABI, which remains hard-float [this was the
> > only arm64 calling convention that existed until about a year ago].
> > Any function that takes or returns floats or doubles (or NEON
> > intrinsic types) is simply rejected by the compiler.  
> 
> That's how C works. It is not how Rust works. Rust does not reject using floats 
> ever. Instead, Rust offers softfloat targets where you can still use floats, but 
> it won't use float registers. Obviously, that needs to use a different ABI.

That's today's situation, although we do prefer to be able to turn off
floats completely (and also not have to compile parts of libcore that's
related to floats).

We mentioned this to the lang team a couple of times, and they do
acknolwedge there might be a need for it, although it's not something
that today's Rust can handle well (i.e. no feature disabling for
libcore).

We have also listed this in
https://github.com/Rust-for-Linux/linux/issues/2 and
https://github.com/Rust-for-Linux/linux/issues/514.

> As you said, aarch64 does not have an official softfloat ABI, but LLVM 
> implements a de-facto softfloat ABI if you ask it to generate functions that 
> take/return float types while disabling the relevant target features. (Maybe 
> LLVM should just refuse to generate such code, and then Rust may have ended up 
> with a different design. But now this would all be quite tricky to change.)
> 
> > Changing this to softfloat for Rust modifies this calling convention,
> > i.e., it will result in floats and doubles being accepted as function
> > parameters and return values, but there is no code in the kernel that
> > actually supports/implements that.  
> 
> As explained above, f32/f64 were already accepted as function parameters and 
> return values in Rust code before this change. So this patch does not change 
> anything here. (In fact, the ABI used for these functions should be exactly the 
> same before and after this patch.)
> 
> > Also, it should be clarified
> > whether using a softfloat ABI permits the compiler to use FP/SIMD
> > registers in codegen. We might still need -Ctarget-feature="-neon"
> > here afaict.  
> 
> Rust's softfloat targets do not use FP/SIMD registers by default. Ideally these 
> targets allow selectively using FP/SIMD registers within certain functions; for 
> aarch64, this is not properly supported by LLVM and therefore Rust.
> 
> > Ideally, we'd have a target/target-feature combo that makes this more
> > explicit: no FP/SIMD codegen at all, without affecting the ABI,
> > therefore making float/double types in function prototypes illegal.
> > AIUI, this change does something different.  
> 
> Having targets without float support would be a significant departure from past 
> language decisions in Rust -- that doesn't mean it's impossible, but it would 
> require a non-trivial effort (starting with an RFC to lay down the motivation 
> and design).
> 
> Kind regards,
> Ralf
> 
>