From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wilson Ding <dingwei@marvell.com>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, andrew@lunn.ch,
gregory.clement@bootlin.com, sebastian.hesselbarth@gmail.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
p.zabel@pengutronix.de, salee@marvell.com, gakula@marvell.com
Subject: Re: [PATCH 4/4] [PATCH 4/4] arm64: dts: marvell: cp11x: Add reset controller node
Date: Fri, 14 Feb 2025 09:48:57 +0100 [thread overview]
Message-ID: <20250214-famous-rainbow-pig-d4bd3b@krzk-bin> (raw)
In-Reply-To: <20250214065833.530276-6-dingwei@marvell.com>
On Thu, Feb 13, 2025 at 10:58:33PM -0800, Wilson Ding wrote:
> The unit soft-reset configuration register is part of the system
> controller register.
>
> Signed-off-by: Wilson Ding <dingwei@marvell.com>
> ---
> arch/arm64/boot/dts/marvell/armada-cp11x.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> index 161beec0b6b0..b82003df15e0 100644
> --- a/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> +++ b/arch/arm64/boot/dts/marvell/armada-cp11x.dtsi
> @@ -273,6 +273,12 @@ CP11X_LABEL(gpio2): gpio@140 {
> <&CP11X_LABEL(clk) 1 17>;
> status = "disabled";
> };
> +
> + CP11X_LABEL(soft_reset): soft-reset@268 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Usually: reset-controller
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-02-14 8:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 6:58 [PATCH 0/4] Add Armada8K reset controller support Wilson Ding
2025-02-14 6:58 ` Wilson Ding
2025-02-14 6:58 ` [PATCH 1/4] [PATCH 1/4] reset: simple: Add syscon device compatible Wilson Ding
2025-02-14 8:48 ` Krzysztof Kozlowski
2025-02-14 11:54 ` Philipp Zabel
2025-02-14 17:13 ` Wilson Ding
2025-02-14 18:03 ` Philipp Zabel
2025-02-14 18:40 ` [EXTERNAL] " Wilson Ding
2025-02-14 6:58 ` [PATCH 2/4] [PATCH 2/4] reset: simple: Add support for Armada8K reset controller Wilson Ding
2025-02-14 8:48 ` Krzysztof Kozlowski
2025-02-14 6:58 ` [PATCH 3/4] [PATCH 3/4] dt-bindings: cp110: Document the " Wilson Ding
2025-02-14 8:45 ` Krzysztof Kozlowski
2025-02-14 6:58 ` [PATCH 4/4] [PATCH 4/4] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-14 8:48 ` Krzysztof Kozlowski [this message]
2025-02-19 0:42 ` [PATCH 0/4] Add Armada8K reset controller support Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214-famous-rainbow-pig-d4bd3b@krzk-bin \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=gakula@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=salee@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox