From: Regis Dargent <regis.dargent@gmail.com>
Cc: Regis Dargent <regis.dargent@gmail.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>, Chen-Yu Tsai <wens@csie.org>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Samuel Holland <samuel@sholland.org>,
linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH v2] watchdog: sunxi_wdt: Allow watchdog to remain enabled after probe
Date: Fri, 14 Feb 2025 12:22:54 +0100 [thread overview]
Message-ID: <20250214112255.97099-2-regis.dargent@gmail.com> (raw)
In-Reply-To: <20250214112255.97099-1-regis.dargent@gmail.com>
If the watchdog is already running during probe, let it run on, read its
configured timeout, and set its status so that it is correctly handled by the
kernel.
Signed-off-by: Regis Dargent <regis.dargent@gmail.com>
---
drivers/watchdog/sunxi_wdt.c | 48 +++++++++++++++++++++++++++++++++---
1 file changed, 45 insertions(+), 3 deletions(-)
diff --git a/drivers/watchdog/sunxi_wdt.c b/drivers/watchdog/sunxi_wdt.c
index b85354a99582..0094bcd063c5 100644
--- a/drivers/watchdog/sunxi_wdt.c
+++ b/drivers/watchdog/sunxi_wdt.c
@@ -140,6 +140,7 @@ static int sunxi_wdt_set_timeout(struct watchdog_device *wdt_dev,
timeout++;
sunxi_wdt->wdt_dev.timeout = timeout;
+ sunxi_wdt->wdt_dev.max_hw_heartbeat_ms = 0;
reg = readl(wdt_base + regs->wdt_mode);
reg &= ~(WDT_TIMEOUT_MASK << regs->wdt_timeout_shift);
@@ -152,6 +153,32 @@ static int sunxi_wdt_set_timeout(struct watchdog_device *wdt_dev,
return 0;
}
+static int sunxi_wdt_read_timeout(struct watchdog_device *wdt_dev)
+{
+ struct sunxi_wdt_dev *sunxi_wdt = watchdog_get_drvdata(wdt_dev);
+ void __iomem *wdt_base = sunxi_wdt->wdt_base;
+ const struct sunxi_wdt_reg *regs = sunxi_wdt->wdt_regs;
+ int i;
+ u32 reg;
+
+ reg = readl(wdt_base + regs->wdt_mode);
+ reg >>= regs->wdt_timeout_shift;
+ reg &= WDT_TIMEOUT_MASK;
+
+ /* Start at 0 which actually means 0.5s */
+ for (i = 0; ((i < WDT_MAX_TIMEOUT) && (wdt_timeout_map[i] != reg)); i++)
+ ;
+ if (i == 0) {
+ wdt_dev->timeout = 1;
+ wdt_dev->max_hw_heartbeat_ms = 500;
+ } else {
+ wdt_dev->timeout = i;
+ wdt_dev->max_hw_heartbeat_ms = 0;
+ }
+
+ return 0;
+}
+
static int sunxi_wdt_stop(struct watchdog_device *wdt_dev)
{
struct sunxi_wdt_dev *sunxi_wdt = watchdog_get_drvdata(wdt_dev);
@@ -192,11 +219,22 @@ static int sunxi_wdt_start(struct watchdog_device *wdt_dev)
return 0;
}
+static bool sunxi_wdt_enabled(struct sunxi_wdt_dev *wdt)
+{
+ u32 reg;
+ void __iomem *wdt_base = wdt->wdt_base;
+ const struct sunxi_wdt_reg *regs = wdt->wdt_regs;
+
+ reg = readl(wdt_base + regs->wdt_mode);
+ return !!(reg & WDT_MODE_EN);
+}
+
static const struct watchdog_info sunxi_wdt_info = {
.identity = DRV_NAME,
.options = WDIOF_SETTIMEOUT |
WDIOF_KEEPALIVEPING |
- WDIOF_MAGICCLOSE,
+ WDIOF_MAGICCLOSE |
+ WDIOF_SETTIMEOUT,
};
static const struct watchdog_ops sunxi_wdt_ops = {
@@ -275,8 +313,12 @@ static int sunxi_wdt_probe(struct platform_device *pdev)
watchdog_set_drvdata(&sunxi_wdt->wdt_dev, sunxi_wdt);
- sunxi_wdt_stop(&sunxi_wdt->wdt_dev);
-
+ if (sunxi_wdt_enabled(sunxi_wdt)) {
+ sunxi_wdt_read_timeout(&sunxi_wdt->wdt_dev);
+ set_bit(WDOG_HW_RUNNING, &sunxi_wdt->wdt_dev.status);
+ } else {
+ sunxi_wdt_stop(&sunxi_wdt->wdt_dev);
+ }
watchdog_stop_on_reboot(&sunxi_wdt->wdt_dev);
err = devm_watchdog_register_device(dev, &sunxi_wdt->wdt_dev);
if (unlikely(err))
--
2.25.1
next prev parent reply other threads:[~2025-02-14 11:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-06 9:39 [PATCH]: watchdog: Allow watchdog to remain enabled after probe Regis Dargent
2025-02-06 10:14 ` Chen-Yu Tsai
2025-02-14 11:22 ` [PATCH v2]: watchdog: sunxi: " Regis Dargent
2025-02-14 11:22 ` Regis Dargent [this message]
2025-02-20 18:54 ` [PATCH v2] watchdog: sunxi_wdt: " Jernej Škrabec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250214112255.97099-2-regis.dargent@gmail.com \
--to=regis.dargent@gmail.com \
--cc=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).